Changes to pass through sqlparser options#15349
Merged
rschlussel merged 1 commit intoprestodb:masterfrom Nov 16, 2020
Merged
Conversation
|
|
Contributor
Author
rschlussel
reviewed
Oct 26, 2020
Contributor
rschlussel
left a comment
rschlussel
left a comment
There was a problem hiding this comment.
Please squash all your commits together and rebase on master (we don't do merge commits, so you need to rebase rather than merge.)
presto-main/src/main/java/com/facebook/presto/server/protocol/QueuedStatementResource.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/server/protocol/QueuedStatementResource.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/com/facebook/presto/server/TestHttpRequestSessionContext.java
Outdated
Show resolved
Hide resolved
BlueberryDS
force-pushed
the
sql-parser-options-passthrough
branch
5 times, most recently
from
6285bde to
dac427e
Compare
…atements.
Parsing for prepared statements has differences from the regular statement handler in that configured parsing options are not performed consistently. This change passes the SqlParsingOptions through to the prepared statement handling code to make that logic consistent.
BlueberryDS
force-pushed
the
sql-parser-options-passthrough
branch
from
dac427e to
34bd7ba
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing for prepared statements has differences from the regular statement handler in that configured parsing options are not performed consistently. This change passes the SqlParsingOptions through to the prepared statement handling code to make that logic consistent.
Test Plan - Unit tests