Skip to content

Add query schema to ConnectorSession#15495

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
mayankgarg1990:block_cross
Dec 3, 2020
Merged

Add query schema to ConnectorSession#15495
tdcmeehan merged 1 commit intoprestodb:masterfrom
mayankgarg1990:block_cross

Conversation

@mayankgarg1990
Copy link
Copy Markdown

@mayankgarg1990 mayankgarg1990 commented Dec 3, 2020 •
edited
Loading

Having access to this information will allow us to make decisions based on the schema
in the metadata layers

Test plan - This is a simple change that flows the schema to the connector. Just ensured that
the current tests continue to succeed.

== RELEASE NOTES ==

SPI Changes
* Add ``getSchema`` to ``ConnectorSession``

Depended by https://github.com/facebookexternal/presto-facebook/pull/1341

ajaygeorge
ajaygeorge approved these changes Dec 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ajaygeorge ajaygeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayankgarg1990 mayankgarg1990 marked this pull request as ready for review December 3, 2020 17:43
@mayankgarg1990
Copy link
Copy Markdown
Author

mayankgarg1990 commented Dec 3, 2020

@tdcmeehan can you help with reviewing this PR :)

tdcmeehan
tdcmeehan approved these changes Dec 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add query schema to ConnectorSession
bd5bc81 
Having access to this information will allow us to make decisions based on the schema
in the metadata layers
@mayankgarg1990
Copy link
Copy Markdown
Author

mayankgarg1990 commented Dec 3, 2020

@tdcmeehan - I have made a change to TestingConnectorSession - once the tests complete successfully, I will comment here again so that you can take a look and merge the PR

@mayankgarg1990
Copy link
Copy Markdown
Author

mayankgarg1990 commented Dec 3, 2020

@tdcmeehan - this PR is ready to be merged. Also, it has extra changes in the test code which was added after your review

@tdcmeehan tdcmeehan merged commit 8e1384e into prestodb:master Dec 3, 2020
@mayankgarg1990 mayankgarg1990 deleted the block_cross branch December 3, 2020 23:35
@caithagoras caithagoras mentioned this pull request Dec 4, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajaygeorge ajaygeorge ajaygeorge approved these changes

@tdcmeehan tdcmeehan tdcmeehan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mayankgarg1990 @ajaygeorge @tdcmeehan