Fix split cacheable setting for affinity scheduling#15464
Merged
shixuan-fan merged 1 commit intoprestodb:masterfrom Nov 20, 2020
Merged
Conversation
As of now, when we schedule a scan for bucketed table which then joins with a remote, we don't set the cacheable to true even if we enable affinity scheduling
shixuan-fan
reviewed
Nov 20, 2020
Contributor
shixuan-fan
left a comment
shixuan-fan
left a comment
There was a problem hiding this comment.
Do we want to mention this in release note?
| switch (nodeSelectionStrategy) { | ||
| case HARD_AFFINITY: | ||
| bucketToNode = getFixedMapping(connectorBucketNodeMap); | ||
| cacheable = false; |
Contributor
There was a problem hiding this comment.
I might miss something, but why is hard affinity not cacheable?
Collaborator
Author
There was a problem hiding this comment.
Hard affinity is for connectors that use its own storage like Raptor, we don't want to do cache for them
Contributor
There was a problem hiding this comment.
Okay, sounds good. I thought hard affinity could also apply for disaggregated storage (though should never be more preferable than soft affinity), but let's not worry about it for now.
shixuan-fan
approved these changes
Nov 20, 2020
kewang1024
deleted the
fix_split_cachable_setting_for_affinity_scheduling
branch
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of now, when we schedule a scan for bucketed table which then joins with a remote,
we don't set the cacheable to true even if we enable affinity scheduling, this PR introduce the support for it