Fix LongEnum deserialization in map keys#15450
Merged
caithagoras merged 1 commit intoprestodb:masterfrom Nov 20, 2020
Merged
Conversation
Contributor
daniel-ohayon
commented
Nov 18, 2020
daniel-ohayon
commented
rongrong
reviewed
Nov 18, 2020
| return String.class.cast(value); | ||
| } | ||
| if (signature.isLongEnum()) { | ||
| if (value instanceof String) { |
Contributor
There was a problem hiding this comment.
Why would the value be string is the enum is long?
Contributor
Author
There was a problem hiding this comment.
that happens because of JSON serialization – in JSON, keys are always strings (this is why we have a similar check a few lines below – line 138).
rongrong
approved these changes
Nov 19, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.