[saphid]

Problem

When a review diff is larger than 120 KB, the Changes panel loads each file on its own. If the workspace contains an untracked nested Git repository that has commits (for example a library cloned into the project but not yet added as a submodule), that repository's row never loads. It shows an error, and Retry fails every time.

The full review already lists the repository as a new Subproject commit entry. The per-file request asks for nested/clone, but git ls-files --others names a nested repository nested/clone/, with a trailing slash. The exact-match filter in prepareUntrackedReviewIndex dropped it, so no temporary index was built and the server returned no files for that row.

Change

The per-file filter also accepts <path>/. Only nested repositories are listed with a trailing slash, so other paths match as before.

Scope and approval

Very small, focused fix for an obvious bug, so no prior issue: the full and per-file review paths disagree about one entry, and the fix is a one-line match.

Overlap search: #28632 (open) handles nested repositories with no commits in prepareReviewIndex, and keeps repositories with commits in the review on purpose. It does not touch this filter. #1000 (open) is about submodule files in workspace search. Nothing else found for the per-file nested-repository case.

Verification

• Red on main: extended GitVcsDriverCore.test.ts "loads repository-relative files from a nested project directory" with an untracked nested repository that has a commit. It failed with AssertionError: expected [] to deeply equal [ { path: 'nested/clone', …(3) } ].
• Green: vp test run src/vcs/GitVcsDriverCore.test.ts: 223 passed. The one failure, "keeps generated worktree folders short without changing long branch names", is a macOS /var vs /private/var failure that also fails on clean main.
• vp run check:changed: format, lint, knip, graphql and typecheck pass. The test step fails only on that same known test.
• Not checked in a real client. The web path is useReviewFilePatches for truncated sources.

Reviewed with sol-loop: 1 round with GPT-6.1 Sol on high. Sol verdict: approved.

Created with Claude Opus 5.5 in Claude Code (T3 Code).

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 3f6b745

Macroscope's review found this PR approvable — This fixes nested-repository review rows by accepting Git’s trailing-slash path representation. The change remains confined to review preparation using a temporary index, with existing limits unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The change updates untracked-path matching for nested repositories. It also adds a nested repository to the review preview test and changes the expected working-tree file count to three.

Changes: Nested repository preview

Layer / File(s)	Summary
Match nested repository paths apps/server/src/vcs/GitVcsDriverCore.ts, apps/server/src/vcs/GitVcsDriverCore.test.ts	prepareUntrackedReviewIndex accepts an exact onlyPath match or a match with a trailing slash. The preview test initializes a nested clone repository and expects three working-tree files.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: only21mil

Merge Risk: Minimal · up to 3f6b7

No actionable merge-blocking risk was identified.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the server fix for loading review rows from nested repositories in large diffs.
Description check		The description includes all required sections. It explains the problem, the exact filter change, scope and approval rationale, focused verification results, known test limitations, and untested clien…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description includes all required sections. It explains the problem, the exact filter change, scope and approval rationale, focused verification results, known test limitations, and untested client paths.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ast-grep (0.51.1)

ast-grep could not parse rule config: /ast-grep-rules/ast-grep-essentials/rules/scala/security/scala-jwt-hardcoded-secret-scala.yml

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 61c3794
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 720ce143-f87d-43b2-8d4a-e4337d0a040a

Commits

Reviewing files that changed from the base of the PR and between 972f926 and 3f6b745.

Files selected for processing: 2

• apps/server/src/vcs/GitVcsDriverCore.test.ts
• apps/server/src/vcs/GitVcsDriverCore.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

merge readiness at 3f6b7459d2ba835fff1e6eda01064ea923d7a03f

merged current main (61c3794c32) without rebasing. resolved the existing test conflict by retaining main's symlink and newline-path coverage plus this pr's nested-repository case. production fix unchanged; final diff remains two files, seven insertions and two deletions. pushed to the original contributor branch without force.

blacksmith-check passed vp run check:changed 61c3794c32b0eeebfac09add43e403618c65d2d7: format, lint, both knip checks, graphql, three affected typechecks, and 234 tests across two files. the nested-directory/alias regression passed. two independent read-only reviews found no issues on this exact head.

all 33 git.cafe checks passed; github reports mergeable and no review threads remain. no new bot findings. not merged.

this pass verified the merged backend through its existing integration tests. the real-client captures below are from the original unchanged production fix; the browser/provider scenario was not rerun after merging main.

Verified in a real dev environment

verified unchanged head 972f9266e0e38cdff6ae0c2a27eac3f91cd3aa40 on a linux boat vm using the real dev web app, repository playwright, and /usr/bin/google-chrome.

created a project and thread through the app. a real codex gpt-6.1-sol turn created a committed outer repository, a committed untracked nested/clone repository, a 3500-line untracked file, an ordinary untracked file, and a tracked edit. no mocks or seeded demo data. a second real codex turn on the pr confirmed the same files and nested commit without modifying them.

reproduced on github/main at 57cd05904d: both full review sources truncate at 120,000 bytes and list nested/clone, but its individual request returns files: [] and an empty patch. the row cannot expand; retry repeats the failure.

on this pr, the same client requests return the 192-byte nested repository patch and render Subproject commit 69d2f0193d483148e150db639e84f6ec1d743a8a. verified both Changes and Uncommitted, expanding/collapsing rows, refreshing, the ordinary untracked file, and the tracked old/new contents. no retry errors. only one dev server ran at a time.

vp run check:changed 55e25385619c7680dad0b0f34f5185187806c57a passed through blacksmith-check: format, lint, both knip checks, graphql, affected typechecks, and 225 tests across two files, including all 224 GitVcsDriverCore tests. github checks are green. no source changes were needed.

before, main:

after, same repository data:

short runtime transcript with actual client websocket requests and server responses

Not verified

native ios/android and the electron shell were not exercised on this linux web verification pass. macos/windows filesystem behavior, remote relay/tunnel connections, and other providers were not exercised. no external service is required by the changed local git review path.

Dismissing prior approval to re-evaluate 3f6b745