[saphid]

Problem

On web and desktop, selecting a long stretch of terminal output (for example a big build log) and choosing "Add selection to chat" accepts any size. The message contract caps terminal context text at 64,000 characters. Mobile already refuses larger selections, but web passed the text through unchanged. A selection over the cap made a context record that fails the schema, so sending the message failed with "Schema validation failed" and the draft stayed in the composer. The user couldn't send that selection at all. maria-rcks reproduced this on main with a real 99,545-character terminal log.

Change

terminalContextRecord now runs the text through clampContextText with COMPOSER_CONTEXT_TERMINAL_TEXT_MAX_CHARS. Review comments already do this with their own bounds. Long selections keep the first 64,000 characters and end with the existing … truncated … marker.

clampContextText cuts at a UTF-16 index, so it now steps back one unit instead of ending on a lone high surrogate. A split emoji would otherwise send invalid text to the provider. This is the same guard packages/shared/src/terminalOutput.ts uses.

Scope and approval

Very small, focused fix for an obvious bug, so no prior issue: the contract bound and the clamp helper both exist, and the sibling review-comment record already uses them. Terminal records were the one kind the helper missed. 9 non-test lines.

Overlap search: local PR index and gh search prs for "terminal context truncated", "terminalContextRecord", and oversized terminal selections. The closest match is #27843 (inverted terminal ranges), which fixes something else. No open PR touches this.

Verification

• Red on main: extended composerContextRecords.test.ts > "clamps oversized review and terminal selections so the records still encode". It fails with AssertionError: expected false to be true because the text is not truncated. With only the clamp and no surrogate guard, it fails on the string comparison.
• Green: vp test run src/lib/composerContextRecords.test.ts gives 14 passed.
• vp run check:changed: format, lint, knip, typecheck (2 packages), test and react compiler all pass.
• Not checked: no real-client run. The chip still shows the full selection until send; only the record sent over the wire is clamped.

Reviewed with sol-loop: 1 round with GPT-6.1 Sol on high. Sol verdict: approved.

Created with Claude Opus 5.5 in Claude Code (T3 Code).

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 2dbe217

Macroscope's review found this PR approvable — Oversized terminal selections are truncated to the existing message-context limit with a visible marker, preventing send failures. The change also preserves Unicode surrogate pairs at truncation boundaries and leaves within-limit selections unchanged.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

Terminal context records now truncate normalized text to the configured maximum. Truncation reserves space for its marker and avoids ending retained text with a lone high surrogate. Tests cover oversized terminal text and successful record decoding.

Changes: Composer context text bounds

Layer / File(s)	Summary
Clamp terminal context text apps/web/src/lib/composerContextRecords.ts, apps/web/src/lib/composerContextRecords.test.ts	Terminal records truncate normalized text to the configured maximum. The truncation logic reserves space for the marker and removes a trailing high surrogate. Tests cover oversized terminal text and successful record decoding.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to 2dbe2

The change addresses oversized terminal selections, and the regression test verifies that the resulting record remains decodable.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the main change: terminal selections that exceed the message-contract limit no longer break sending. It is a conventional commit with a scope and states the user-visible effect. It mat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description check		The pull request description includes all required sections. It clearly explains the problem, the implementation, scope and approval rationale, verification results, limitations, and tool usage. It al…

Full details: Title check

Explanation

The title names the main change: terminal selections that exceed the message-contract limit no longer break sending. It is a conventional commit with a scope and states the user-visible effect. It matches the summary, which clamps terminal context text to COMPOSER_CONTEXT_TERMINAL_TEXT_MAX_CHARS. The title does not mention the surrogate-pair guard, which is a secondary detail.

Full details: Description check

Explanation

The pull request description includes all required sections. It clearly explains the problem, the implementation, scope and approval rationale, verification results, limitations, and tool usage. It also reports specific test commands and outcomes.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ast-grep (0.51.1)

ast-grep could not parse rule config: /ast-grep-rules/ast-grep-essentials/rules/python/security/no-render-template-string.yml

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: f6503f0
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 995d3962-7f87-457c-9e67-b092ac438c8a

Commits

Reviewing files that changed from the base of the PR and between 977c0ab and 2dbe217.

Files selected for processing: 1

• apps/web/src/lib/composerContextRecords.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

[coderabbitai]

• Fix comments: Fix CodeRabbit comments on this PR

Dismissing prior approval to re-evaluate 2dbe217

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified unchanged head 2dbe2171501d5492acc7f5239d84274805a1cc0e on linux with the real dev web client, repository Playwright, /usr/bin/google-chrome, and real Codex gpt-6.1-sol turns through the local proxy. projects, threads, terminal output and messages were created through the app. no mocks or seeded data.

• on github/main (61c3794c32), selected a 99,545-character terminal log using Select all → Add to chat. send failed with "Schema validation failed" and retained the draft. a plain Codex turn returned PROVIDER_READY, confirming that the provider path worked independently.
• on the PR, repeated the flow with the same log and random token. the 99,398-character selection became exactly 64,000 characters in the real orchestration.launchThread WebSocket request, ending in … truncated …. Codex returned ATTACHMENT_257385ddf35f9a73 truncation marker: yes without using tools.
• a neighboring 235-character attachment crossed orchestration.dispatchCommand unchanged. Codex returned SMALL_f2fc7ca6c5d8272c 😀 café SMALL_END truncated: no.
• after reloading the client, opened both sent excerpt chips. the large record remained 64,000 characters with the marker; the small record still matched its draft exactly.

short runtime/check transcript:

main: git worktree add ../main github/main; vp i; vp run dev --no-seed
      server 16733 / web 8693; stopped before starting PR
PR:   git switch -c fix/terminal-context-clamp 2dbe2171501d5492acc7f5239d84274805a1cc0e
      vp i; vp run dev --home-dir /home/user/t3code/.t3 --no-seed
      server 13773 / web 5733
WebSocket: terminal record length=64000, suffix="\n… truncated …"
Codex: ATTACHMENT_257385ddf35f9a73 truncation marker: yes
Codex: SMALL_f2fc7ca6c5d8272c 😀 café SMALL_END truncated: no
Blacksmith: vp test run apps/web/src/lib/composerContextRecords.test.ts
            14 passed, including the split-surrogate regression
Blacksmith: vp run check:changed verification/main
            format, lint, knip, typecheck, focused tests, react compiler passed
GitHub: latest-head checks passed; applicable jobs green

before, on main:

after, with the same terminal log on the PR:

Not verified

native Electron, iOS and Android clients; macOS and Windows; relay/tunnel connections; other providers. this VM verification used the Linux web client and Codex. the precise emoji split boundary was covered by the existing regression test, while the real-client Unicode check exercised a within-limit emoji and accented text.

no source changes or pushes were needed. no merge, rebase, force-push, label changes or other PR changes.