[juliusmarminge]

Problem

#22523 added a resetPointer browser command so a test no longer inherits Playwright's mouse from the previous test (the ComposerBannerStack hover flake). It only ran when a render() screen from apps/web/test/render.tsx disposed, so two gaps remained:

1. These 8 browser test files mount without test/render and never reset the pointer:
   • apps/web/src/composer-list-split.browser.test.ts
   • apps/web/src/markdown-clipboard.math.browser.test.ts
   • apps/web/src/components/chat/composerFocusRedirect.browser.test.ts
   • apps/web/src/components/chat/timelineMinimapWheel.browser.test.ts
   • apps/web/src/components/chat/MermaidDiagram.browser.test.tsx
   • apps/web/src/components/chat/threadFindPosition.browser.test.ts
   • apps/web/src/components/settings/settingsLayout.browser.test.tsx
   • apps/web/src/lib/editableFocus.browser.test.ts
2. Because the reset happened on dispose, the first test of any file that ran after one of those files still started with the mouse wherever it had been left.

Fix

The browser project now has a setup file, apps/web/test/browserSetup.ts, that registers a global beforeEach calling commands.resetPointer(). Every browser test file gets it, whether or not it uses render(). The hook runs before each test rather than after, because a test that times out keeps running and can move the mouse after its own afterEach has already run. Resetting before each test means every test starts with the mouse off the page, whatever ran before it. The BrowserCommands type augmentation moved there with it. render()'s dispose no longer calls the reset, since the global hook covers every test. The command definition in vite.config.ts from #22523 is unchanged.

Verification

• Scratch test pair, not committed. File A clicks a full-viewport element. File B mounts a full-viewport element and asserts no pointerenter and no :hover. Both were run in one vp test run --project browser --no-file-parallelism invocation, with A first:
  • with the setup file: both pass
  • with setupFiles: []: B fails with { entered: 1, hovered: true }
• ComposerBannerStack.browser.test.tsx: 5 out of 5 runs passed with the earlier afterEach version and 3 out of 3 with beforeEach.
• tsc --noEmit for apps/web and vp lint on the touched files: clean.

Made with Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 84e1de4

Macroscope's review found this PR approvable — This small change improves browser-test isolation by resetting Playwright's pointer before each browser test, including tests that do not use the shared render helper. All affected code is test-only and has no production runtime or product-default impact.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 84e1de4

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 2d6ba512-a63e-4f9f-9d06-6eeeeae956a4

📥 Commits

Reviewing files that changed from the base of the PR and between f9dd259 and 84e1de4.

📒 Files selected for processing: 3

• apps/web/test/browserSetup.ts
• apps/web/test/render.tsx
• apps/web/vite.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Browser tests now load a dedicated setup file that declares and invokes resetPointer before each test. The render helper no longer resets the pointer during disposal.

Changes: Browser Test Pointer Reset

Layer / File(s)	Summary
Configure per-test pointer reset apps/web/test/browserSetup.ts, apps/web/vite.config.ts, apps/web/test/render.tsx	The setup file declares and invokes resetPointer before each test, and the browser test project loads it. The render helper removes its command augmentation and disposal call.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: t3dotgg

Merge Risk: ⚪ Minimal · up to 84e1d

No concrete merge-blocking defect is established by the available evidence.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description clearly explains the problem, implementation, scope of the code changes, and focused verification results. It does not include the required Scope and approval section or an explicit is…	Add a Scope and approval section. Link the triaged issue or maintainer approval, or explain why this focused fix qualifies for an exemption from prior approval.

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: ensuring every browser test starts with the mouse off the page.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains the problem, implementation, scope of the code changes, and focused verification results. It does not include the required Scope and approval section or an explicit issue, approval, or small-fix exemption rationale.

Resolution

Add a Scope and approval section. Link the triaged issue or maintainer approval, or explain why this focused fix qualifies for an exemption from prior approval.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}