Skip to content

Comments

feat: Alloy migration#4737

Merged
DaniPopes merged 27 commits intomainfrom
alloy
Sep 28, 2023
Merged

feat: Alloy migration#4737
DaniPopes merged 27 commits intomainfrom
alloy

Conversation

@DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 23, 2023

Migrate all primitive types, ABI, RLP, and EIP-712 logic to Alloy.

See tracking issue #4715.

@codecov

This comment was marked as outdated.

@DaniPopes DaniPopes self-assigned this Sep 23, 2023
@DaniPopes DaniPopes mentioned this pull request Sep 23, 2023
@DaniPopes DaniPopes marked this pull request as ready for review September 28, 2023 00:13
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

awesome work!

@DaniPopes
Copy link
Member Author

cc @gakonst

@mattsse
Copy link
Collaborator

mattsse commented Sep 28, 2023

@DaniPopes new conflicts -.-

@DaniPopes
Copy link
Member Author

DaniPopes commented Sep 28, 2023

Needs also bluealloy/revm#724 rebase
Using Evalir/revm#4 for now

Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send it once conflicts resolved. amazing...

@DaniPopes DaniPopes enabled auto-merge September 28, 2023 15:48
@DaniPopes DaniPopes added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 5f9a917 Sep 28, 2023
@DaniPopes DaniPopes deleted the alloy branch September 28, 2023 16:09
@bocalhky bocalhky mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants