use reth_primitives instead of revm_primitives#5434
Merged
mattsse merged 1 commit intoparadigmxyz:mainfrom Nov 15, 2023
Merged
Conversation
supernovahs
requested review from
Rjected,
gakonst and
mattsse
as code owners
mattsse
approved these changes
Nov 15, 2023
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this looks reasonable, no need to pull in revm_primitives, yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #4737
Also, wanted to know what else needs to be done in 4737.