Skip to content

feat(primitives): remove mod ethers_compat#4771

Merged
DaniPopes merged 4 commits intoparadigmxyz:mainfrom
tcoratger:ethers-compat
Sep 26, 2023
Merged

feat(primitives): remove mod ethers_compat#4771
DaniPopes merged 4 commits intoparadigmxyz:mainfrom
tcoratger:ethers-compat

Conversation

@tcoratger
Copy link
Contributor

@tcoratger tcoratger commented Sep 25, 2023

Should close #4738.

@tcoratger
Copy link
Contributor Author

This is just a draft here, I'm not that familiar with alloy but I think that we need to change GethInstance in:

pub struct CliqueGethInstance {
/// The spawned [`GethInstance`](ethers_core::utils::GethInstance).
pub instance: GethInstance,
/// The provider who can talk to this instance
pub provider: SignerMiddleware<Provider<Ws>, Wallet<SigningKey>>,
}

in order to remove the ethers_core dependency here. Maybe this is is part of #4737 or to be included here after the merge?

@DaniPopes
Copy link
Member

Ah they're used for tests. This is fine for now, you can make the modules #[cfg(feature = "test-utils")]

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #4771 (f225336) into main (272f062) will decrease coverage by 0.19%.
Report is 19 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

Files Coverage Δ
crates/primitives/src/genesis.rs 97.38% <ø> (+0.02%) ⬆️
crates/primitives/src/header.rs 94.88% <ø> (ø)

... and 34 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.18% <ø> (-0.34%) ⬇️
unit-tests 63.27% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.11% <ø> (+0.03%) ⬆️
blockchain tree 83.69% <ø> (ø)
pipeline 88.45% <ø> (-0.09%) ⬇️
storage (db) 73.47% <ø> (-0.02%) ⬇️
trie 94.52% <ø> (+0.03%) ⬆️
txpool 49.51% <ø> (ø)
networking 76.47% <ø> (-0.59%) ⬇️
rpc 57.71% <ø> (+0.04%) ⬆️
consensus 62.59% <ø> (-0.26%) ⬇️
revm 28.33% <ø> (ø)
payload builder 8.20% <ø> (ø)
primitives 86.37% <ø> (-0.17%) ⬇️

@tcoratger tcoratger marked this pull request as ready for review September 26, 2023 18:41
@tcoratger
Copy link
Contributor Author

Ah they're used for tests. This is fine for now, you can make the modules #[cfg(feature = "test-utils")]

@DaniPopes Done.

@DaniPopes DaniPopes enabled auto-merge September 26, 2023 19:02
@DaniPopes DaniPopes added this pull request to the merge queue Sep 26, 2023
Merged via the queue into paradigmxyz:main with commit 4dbd883 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ethers conversions (mod ethers_compat etc) in reth-primitives

2 participants