Skip to content

Comments

chore: simplify trie root bench#4802

Merged
mattsse merged 2 commits intoalloyfrom
dani/simpler-bench
Sep 26, 2023
Merged

chore: simplify trie root bench#4802
mattsse merged 2 commits intoalloyfrom
dani/simpler-bench

Conversation

@DaniPopes
Copy link
Member

No description provided.

@DaniPopes DaniPopes requested a review from gakonst as a code owner September 26, 2023 15:19
@mattsse mattsse added C-debt A clean up/refactor of existing code C-test A change that impacts how or what we test labels Sep 26, 2023
Copy link
Contributor

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #4802 (44f7ef4) into alloy (a4a62ec) will increase coverage by 1.10%.
The diff coverage is n/a.

Impacted file tree graph

see 65 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.97% <ø> (+2.11%) ⬆️
unit-tests 62.75% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.23% <ø> (+0.78%) ⬆️
blockchain tree 83.76% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 73.55% <ø> (+0.85%) ⬆️
trie 94.48% <ø> (ø)
txpool 49.52% <ø> (+0.17%) ⬆️
networking 76.62% <ø> (+2.45%) ⬆️
rpc 57.67% <ø> (+1.90%) ⬆️
consensus 62.77% <ø> (-0.13%) ⬇️
revm 28.40% <ø> (ø)
payload builder 8.20% <ø> (ø)
primitives 85.35% <ø> (+1.15%) ⬆️

@mattsse mattsse merged commit 452ebf4 into alloy Sep 26, 2023
@mattsse mattsse deleted the dani/simpler-bench branch September 26, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-debt A clean up/refactor of existing code C-test A change that impacts how or what we test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants