Skip to content

Comments

chore: drop smol_str#4751

Merged
DaniPopes merged 2 commits intoalloyfrom
dani/drop-smol_str
Sep 23, 2023
Merged

chore: drop smol_str#4751
DaniPopes merged 2 commits intoalloyfrom
dani/drop-smol_str

Conversation

@DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 23, 2023

Only used in one place, and is easily replaced by standard String.

Based on #4737 to avoid future conflicts.

@DaniPopes DaniPopes added the A-dependencies Pull requests or issues that are about dependencies label Sep 23, 2023
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good call, is negligible

pending clippy nit

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #4751 (edfb90d) into alloy (dbd877a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/net/eth-wire/src/capability.rs 76.25% <100.00%> (ø)

... and 15 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.98% <100.00%> (+<0.01%) ⬆️
unit-tests 62.98% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.11% <ø> (ø)
blockchain tree 83.80% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 73.76% <ø> (ø)
trie 94.69% <ø> (-0.04%) ⬇️
txpool 50.29% <ø> (+0.78%) ⬆️
networking 77.07% <100.00%> (-0.04%) ⬇️
rpc 57.55% <ø> (-0.01%) ⬇️
consensus 63.15% <ø> (ø)
revm 28.40% <ø> (ø)
payload builder 8.32% <ø> (ø)
primitives 85.61% <ø> (+0.02%) ⬆️

@DaniPopes DaniPopes merged commit 3a37ad9 into alloy Sep 23, 2023
@DaniPopes DaniPopes deleted the dani/drop-smol_str branch September 23, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-dependencies Pull requests or issues that are about dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants