Skip to content

Comments

feat: migrate RLP to alloy-rlp (take 2)#4749

Merged
DaniPopes merged 4 commits intoalloyfrom
dani/alloy-rlp
Sep 23, 2023
Merged

feat: migrate RLP to alloy-rlp (take 2)#4749
DaniPopes merged 4 commits intoalloyfrom
dani/alloy-rlp

Conversation

@DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 23, 2023

Supersedes #3939
Based on #4737

Contains no functional changes, just a clean migration

  • from reth_rlp{,derive} to alloy_rlp (_derive imports replaced by "derive" feature)
  • DecodeError has been deprecated; replaced by either alloy_rlp::Result, alloy_rlp::Error or use alloy_rlp::Error as RlpError
  • small breaking change in global encode functions generics order

@DaniPopes DaniPopes added the C-enhancement New feature or request label Sep 23, 2023
@DaniPopes DaniPopes self-assigned this Sep 23, 2023
@DaniPopes DaniPopes changed the base branch from main to alloy September 23, 2023 14:57
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #4749 (726292e) into alloy (ccae4eb) will decrease coverage by 0.36%.
The diff coverage is 61.53%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/cli/config.rs 0.00% <ø> (ø)
crates/net/discv4/src/config.rs 54.69% <ø> (ø)
crates/net/discv4/src/error.rs 0.00% <ø> (ø)
crates/net/discv4/src/lib.rs 64.82% <0.00%> (-0.21%) ⬇️
crates/net/dns/src/lib.rs 79.09% <ø> (ø)
...ates/net/downloaders/src/test_utils/file_client.rs 80.97% <ø> (ø)
...rates/net/downloaders/src/test_utils/file_codec.rs 100.00% <ø> (ø)
crates/net/ecies/src/error.rs 0.00% <0.00%> (ø)
crates/net/eth-wire/src/capability.rs 76.25% <0.00%> (ø)
crates/net/eth-wire/src/errors/p2p.rs 70.00% <ø> (-10.00%) ⬇️
... and 62 more

... and 5 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.98% <37.76%> (-0.56%) ⬇️
unit-tests 62.98% <52.44%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.11% <ø> (ø)
blockchain tree 83.80% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 73.76% <100.00%> (ø)
trie 94.69% <100.00%> (-0.04%) ⬇️
txpool 50.29% <ø> (+0.46%) ⬆️
networking 77.08% <48.88%> (-0.04%) ⬇️
rpc 57.55% <0.00%> (-0.03%) ⬇️
consensus 63.15% <ø> (ø)
revm 28.40% <ø> (ø)
payload builder 8.32% <ø> (ø)
primitives 85.58% <66.66%> (-0.77%) ⬇️

@DaniPopes DaniPopes merged commit dbd877a into alloy Sep 23, 2023
@DaniPopes DaniPopes deleted the dani/alloy-rlp branch September 23, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant