Skip to content

Comments

chore: add alloy-rlp, remove {rlp,primitive_types} features from ruint#4798

Merged
mattsse merged 1 commit intoalloyfrom
dani/alloy-ruint-features
Sep 26, 2023
Merged

chore: add alloy-rlp, remove {rlp,primitive_types} features from ruint#4798
mattsse merged 1 commit intoalloyfrom
dani/alloy-ruint-features

Conversation

@DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 26, 2023

Removes rlp dep from ruint

@DaniPopes DaniPopes requested a review from gakonst as a code owner September 26, 2023 13:26
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #4798 (db2442c) into alloy (4bd8cdd) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

Files Coverage Δ
crates/primitives/src/genesis.rs 97.36% <100.00%> (ø)
crates/primitives/src/header.rs 94.75% <100.00%> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.98% <100.00%> (+<0.01%) ⬆️
unit-tests 62.81% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.23% <ø> (ø)
blockchain tree 83.65% <ø> (-0.11%) ⬇️
pipeline 88.53% <ø> (ø)
storage (db) 73.54% <ø> (-0.01%) ⬇️
trie 94.48% <ø> (ø)
txpool 49.52% <ø> (ø)
networking 76.87% <ø> (+0.01%) ⬆️
rpc 57.67% <ø> (+<0.01%) ⬆️
consensus 62.56% <ø> (-0.34%) ⬇️
revm 28.40% <ø> (ø)
payload builder 8.20% <ø> (ø)
primitives 85.43% <100.00%> (-0.08%) ⬇️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Sep 26, 2023
@mattsse mattsse merged commit 5dce2ec into alloy Sep 26, 2023
@mattsse mattsse deleted the dani/alloy-ruint-features branch September 26, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-dependencies Pull requests or issues that are about dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants