refactor(ast): simplify serializing SourceType#8936
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 7, 2025
Merged
Conversation
Member
Author
c7915c5 to
49be7ae
Compare
Member
Author
|
cc @hi-ogawa. When I say "simplify", it's not actually simpler! But the complexity is moved into the codegen (previous PR), rather than in code around the AST itself. But that's in line with the DST approach, which we're aiming for. |
CodSpeed Performance ReportMerging #8936 will not alter performanceComparing Summary
|
This was referenced Feb 6, 2025
Contributor
|
Nice! I didn't think of combining all macros 😮 I checked through your other refactoring and all make sense 👍 |
Contributor
Merge activity
|
Dunqing
approved these changes
Feb 7, 2025
#8919 fixed serialization of the `Program::source_type` field. Remove the custom `Serialize` impl for this - use `#[estree(flatten)]` and `#[estree(skip)]` attributes to achieve the same thing. Also, remove extraneous TS type definitions for the parts of `SourceType` which aren't part of the ESTree AST.
28b0e3e to
43746a2
Compare
49be7ae to
c58f785
Compare
Base automatically changed from
02-06-feat_ast_tools_typescript_define_fields_inline_for_flattened_types_with_only_a_single_field
to
main
February 7, 2025 03:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

#8919 fixed serialization of the
Program::source_typefield.Remove the custom
Serializeimpl for this - use#[estree(flatten)]and#[estree(skip)]attributes to achieve the same thing. Also, remove extraneous TS type definitions for the parts ofSourceTypewhich aren't part of the ESTree AST.