Skip to content

refactor(ast_tools): remove Def::file_id method, add StructDef::file and EnumDef::file methods instead#8933

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-06-refactor_ast_tools_remove_def_file_id_method_add_structdef_file_and_enumdef_file_methods_instead
Feb 7, 2025
Merged

refactor(ast_tools): remove Def::file_id method, add StructDef::file and EnumDef::file methods instead#8933
graphite-app[bot] merged 1 commit intomainfrom
02-06-refactor_ast_tools_remove_def_file_id_method_add_structdef_file_and_enumdef_file_methods_instead

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 6, 2025

Refactor. Remove methods that weren't useful, and replace them with ones which are!

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 6, 2025
Copy link
Member Author

overlookmotel commented Feb 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 7, 2025

Merge activity

…le` and `EnumDef::file` methods instead (#8933)

Refactor. Remove methods that weren't useful, and replace them with ones which are!
@graphite-app graphite-app bot force-pushed the 02-06-refactor_ast_tools_remove_def_file_id_method_add_structdef_file_and_enumdef_file_methods_instead branch from 274e09d to 0c0e208 Compare February 7, 2025 02:46
@graphite-app graphite-app bot merged commit 0c0e208 into main Feb 7, 2025
15 checks passed
@graphite-app graphite-app bot deleted the 02-06-refactor_ast_tools_remove_def_file_id_method_add_structdef_file_and_enumdef_file_methods_instead branch February 7, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant