Skip to content

refactor(ast): shorten TS type definitions for enums#8938

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-06-refactor_ast_shorten_ts_type_definitions_for_enums
Feb 7, 2025
Merged

refactor(ast): shorten TS type definitions for enums#8938
graphite-app[bot] merged 1 commit intomainfrom
02-06-refactor_ast_shorten_ts_type_definitions_for_enums

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 6, 2025

Where one enum inherits the variants of another, express that in TS type definitions, rather than repeating all the inherited variants.

Copy link
Member Author

overlookmotel commented Feb 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 6, 2025 22:28
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 7, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 7, 2025

Merge activity

Where one enum inherits the variants of another, express that in TS type definitions, rather than repeating all the inherited variants.
@graphite-app graphite-app bot force-pushed the 02-06-refactor_ast_simplify_serializing_literal_types branch from 27757e6 to a6884e4 Compare February 7, 2025 02:48
@graphite-app graphite-app bot force-pushed the 02-06-refactor_ast_shorten_ts_type_definitions_for_enums branch from 8b48391 to 66f0afb Compare February 7, 2025 02:49
Base automatically changed from 02-06-refactor_ast_simplify_serializing_literal_types to main February 7, 2025 03:07
@graphite-app graphite-app bot merged commit 66f0afb into main Feb 7, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 02-06-refactor_ast_shorten_ts_type_definitions_for_enums branch February 7, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant