Skip to content

refactor(ast): simplify serializing literal types#8937

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-06-refactor_ast_simplify_serializing_literal_types
Feb 7, 2025
Merged

refactor(ast): simplify serializing literal types#8937
graphite-app[bot] merged 1 commit intomainfrom
02-06-refactor_ast_simplify_serializing_literal_types

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 6, 2025

Minimize the amount of hand-written serialization code for literal types (BooleanLiteral etc), mostly by using #[estree(add_fields(...))].

Also correct the TS type def for RegExpLiteral.

Copy link
Member Author

overlookmotel commented Feb 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 6, 2025 21:52
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #8937 will not alter performance

Comparing 02-06-refactor_ast_simplify_serializing_literal_types (a6884e4) with 02-06-refactor_ast_simplify_serializing_sourcetype_ (c58f785)

Summary

✅ 33 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 7, 2025

Merge activity

Minimize the amount of hand-written serialization code for literal types (`BooleanLiteral` etc), mostly by using `#[estree(add_fields(...))]`.

Also correct the TS type def for `RegExpLiteral`.
@graphite-app graphite-app bot force-pushed the 02-06-refactor_ast_simplify_serializing_sourcetype_ branch from 49be7ae to c58f785 Compare February 7, 2025 02:48
@graphite-app graphite-app bot force-pushed the 02-06-refactor_ast_simplify_serializing_literal_types branch from 27757e6 to a6884e4 Compare February 7, 2025 02:48
Base automatically changed from 02-06-refactor_ast_simplify_serializing_sourcetype_ to main February 7, 2025 03:03
@graphite-app graphite-app bot merged commit a6884e4 into main Feb 7, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 02-06-refactor_ast_simplify_serializing_literal_types branch February 7, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant