refactor(ast): simplify serializing literal types#8937
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 7, 2025
Merged
refactor(ast): simplify serializing literal types#8937graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
This was referenced Feb 6, 2025
Member
Author
CodSpeed Performance ReportMerging #8937 will not alter performanceComparing Summary
|
This was referenced Feb 6, 2025
Contributor
Merge activity
|
Minimize the amount of hand-written serialization code for literal types (`BooleanLiteral` etc), mostly by using `#[estree(add_fields(...))]`. Also correct the TS type def for `RegExpLiteral`.
49be7ae to
c58f785
Compare
27757e6 to
a6884e4
Compare
Base automatically changed from
02-06-refactor_ast_simplify_serializing_sourcetype_
to
main
February 7, 2025 03:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Minimize the amount of hand-written serialization code for literal types (
BooleanLiteraletc), mostly by using#[estree(add_fields(...))].Also correct the TS type def for
RegExpLiteral.