fix(ast_tools): do not flatten struct fields inline if fields are inaccessible from crate where Serialize impl is generated#8934
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 7, 2025
Conversation
Member
Author
This was referenced Feb 6, 2025
Contributor
Merge activity
|
…ccessible from crate where `Serialize` impl is generated (#8934) Fix a bug where ESTree codegen would generate a `Serialize` impl in one crate which attempts to access a private field of a struct defined in another crate.
274e09d to
0c0e208
Compare
3079511 to
088bb6c
Compare
Base automatically changed from
02-06-refactor_ast_tools_remove_def_file_id_method_add_structdef_file_and_enumdef_file_methods_instead
to
main
February 7, 2025 02:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix a bug where ESTree codegen would generate a
Serializeimpl in one crate which attempts to access a private field of a struct defined in another crate.