Skip to content

fix(ast_tools): do not flatten struct fields inline if fields are inaccessible from crate where Serialize impl is generated#8934

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-06-fix_ast_tools_do_not_flatten_struct_fields_inline_if_fields_are_inaccessible_from_crate_where_serialize_impl_is_generated
Feb 7, 2025
Merged

fix(ast_tools): do not flatten struct fields inline if fields are inaccessible from crate where Serialize impl is generated#8934
graphite-app[bot] merged 1 commit intomainfrom
02-06-fix_ast_tools_do_not_flatten_struct_fields_inline_if_fields_are_inaccessible_from_crate_where_serialize_impl_is_generated

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 6, 2025

Fix a bug where ESTree codegen would generate a Serialize impl in one crate which attempts to access a private field of a struct defined in another crate.

Copy link
Member Author

overlookmotel commented Feb 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 7, 2025

Merge activity

…ccessible from crate where `Serialize` impl is generated (#8934)

Fix a bug where ESTree codegen would generate a `Serialize` impl in one crate which attempts to access a private field of a struct defined in another crate.
@graphite-app graphite-app bot force-pushed the 02-06-refactor_ast_tools_remove_def_file_id_method_add_structdef_file_and_enumdef_file_methods_instead branch from 274e09d to 0c0e208 Compare February 7, 2025 02:46
@graphite-app graphite-app bot force-pushed the 02-06-fix_ast_tools_do_not_flatten_struct_fields_inline_if_fields_are_inaccessible_from_crate_where_serialize_impl_is_generated branch from 3079511 to 088bb6c Compare February 7, 2025 02:47
Base automatically changed from 02-06-refactor_ast_tools_remove_def_file_id_method_add_structdef_file_and_enumdef_file_methods_instead to main February 7, 2025 02:51
@graphite-app graphite-app bot merged commit 088bb6c into main Feb 7, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 02-06-fix_ast_tools_do_not_flatten_struct_fields_inline_if_fields_are_inaccessible_from_crate_where_serialize_impl_is_generated branch February 7, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant