feat(ast_tools/typescript): define fields inline for flattened types with only a single field#8935
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 7, 2025
Conversation
Member
Author
This was referenced Feb 6, 2025
Contributor
Merge activity
|
…with only a single field (#8935) Where a type has only a single field (not including fields which are skipped), and the child type is flattened, don't extend the child type, just inline that one field into the parent's type definition.
3079511 to
088bb6c
Compare
28b0e3e to
43746a2
Compare
Base automatically changed from
02-06-fix_ast_tools_do_not_flatten_struct_fields_inline_if_fields_are_inaccessible_from_crate_where_serialize_impl_is_generated
to
main
February 7, 2025 02:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Where a type has only a single field (not including fields which are skipped), and the child type is flattened, don't extend the child type, just inline that one field into the parent's type definition.