Skip to content

feat(ast_tools/typescript): define fields inline for flattened types with only a single field#8935

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-06-feat_ast_tools_typescript_define_fields_inline_for_flattened_types_with_only_a_single_field
Feb 7, 2025
Merged

feat(ast_tools/typescript): define fields inline for flattened types with only a single field#8935
graphite-app[bot] merged 1 commit intomainfrom
02-06-feat_ast_tools_typescript_define_fields_inline_for_flattened_types_with_only_a_single_field

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 6, 2025

Where a type has only a single field (not including fields which are skipped), and the child type is flattened, don't extend the child type, just inline that one field into the parent's type definition.

Copy link
Member Author

overlookmotel commented Feb 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 7, 2025

Merge activity

…with only a single field (#8935)

Where a type has only a single field (not including fields which are skipped), and the child type is flattened, don't extend the child type, just inline that one field into the parent's type definition.
@graphite-app graphite-app bot force-pushed the 02-06-fix_ast_tools_do_not_flatten_struct_fields_inline_if_fields_are_inaccessible_from_crate_where_serialize_impl_is_generated branch from 3079511 to 088bb6c Compare February 7, 2025 02:47
@graphite-app graphite-app bot force-pushed the 02-06-feat_ast_tools_typescript_define_fields_inline_for_flattened_types_with_only_a_single_field branch from 28b0e3e to 43746a2 Compare February 7, 2025 02:47
Base automatically changed from 02-06-fix_ast_tools_do_not_flatten_struct_fields_inline_if_fields_are_inaccessible_from_crate_where_serialize_impl_is_generated to main February 7, 2025 02:58
@graphite-app graphite-app bot merged commit 43746a2 into main Feb 7, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 02-06-feat_ast_tools_typescript_define_fields_inline_for_flattened_types_with_only_a_single_field branch February 7, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant