fix(ast): estree compat Program.sourceType#8919
Merged
overlookmotel merged 2 commits intooxc-project:mainfrom Feb 6, 2025
Merged
fix(ast): estree compat Program.sourceType#8919overlookmotel merged 2 commits intooxc-project:mainfrom
Program.sourceType#8919overlookmotel merged 2 commits intooxc-project:mainfrom
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Performance ReportMerging #8919 will not alter performanceComparing Summary
|
hi-ogawa
changed the title
Prograrm.sourceType with estreePrograrm.sourceType
overlookmotel
changed the title
Prograrm.sourceTypeProgram.sourceType
overlookmotel
approved these changes
Feb 6, 2025
Member
overlookmotel
left a comment
overlookmotel
left a comment
There was a problem hiding this comment.
I think we can simplify this. I'll do a follow-up PR if I can make it work.
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
#8919 fixed serialization of the `Program::source_type` field. Remove the custom `Serialize` impl for this - use `#[estree(flatten)]` and `#[estree(skip)]` attributes to achieve the same thing. Also, remove extraneous TS type definitions for the parts of `SourceType` which aren't part of the ESTree AST.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #2854
ref: https://github.com/estree/estree/blob/master/es2015.md#programs
I tried to move
viacustomization onstruct SourceType, but couldn't find a way maybe because struct is defined inoxc_span. For now, I made this asviaonProgram::source_typefield.