perf(transformer/arrow-functions): move arguments transform checks to aid inlining

[overlookmotel]

Move the cheap "does arguments need to be transformed" checks introduced in #7321 into enter_identifier_reference and enter_binding_identifier, and mark those methods #[inline]. These hot paths can then usually execute without a function call.

This wins back the other half of the perf hit of #7234.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• perf(transformer/arrow-function): reduce string comparisons #7318
• test(transformer/async-to-generator): failing test for nested supers #7314
• perf(transformer/arrow-functions): move arguments transform checks to aid inlining #7322 👈 (View in Graphite)
• perf(transformer/arrow-functions): store state of whether arguments needs transform #7321
• refactor(transformer/arrow-function): comments on possible improvement #7320
• refactor(transformer/arrow-function): reserve correct capacity for Vec #7319
• perf(transformer/arrow-function): create super method binding names lazily #7313
• refactor(transformer/arrow-functions): use IndexMap for super getter/setters #7317
• perf(transformer/arrow-function): optimize generate_super_binding_name #7312
• fix(transformer/arrow-function): handle unicode when capitalizing property name #7311
• refactor(transformer/arrow-function): generate_super_binding_name take &str and &TraverseCtx #7310
• fix(transformer/async-to-generator): arguments isn't correct after transformation #7234
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #7322 will improve performances by 10.12%

_{Comparing 11-17-perf_transformer_arrow-functions_move_arguments_transform_checks_to_aid_inlining (44fd962) with main (ea08c1f)}

Summary

⚡ 3 improvements
✅ 27 untouched benchmarks

Benchmarks breakdown

	Benchmark	main	11-17-perf_transformer_arrow-functions_move_arguments_transform_checks_to_aid_inlining	Change
⚡	transformer[antd.js]	48.6 ms	45.6 ms	+6.6%
⚡	transformer[checker.ts]	20 ms	18.2 ms	+10.12%
⚡	transformer[pdf.mjs]	7 ms	6.6 ms	+6.03%

[Dunqing]

Merge activity

• Nov 17, 12:04 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Nov 17, 12:05 AM EST: A user added this pull request to the Graphite merge queue.
• Nov 17, 12:15 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #7310.
• Nov 17, 12:16 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #7310.
• Nov 17, 5:03 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Nov 17, 5:32 AM EST: A user added this pull request to the Graphite merge queue.
• Nov 17, 6:00 AM EST: A user merged this pull request with the Graphite merge queue.