Skip to content

Comments

fix(transformer/arrow-function): handle unicode when capitalizing property name#7311

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-16-fix_transformer_arrow-function_handle_unicode_when_capitalizing_property_name
Nov 17, 2024
Merged

fix(transformer/arrow-function): handle unicode when capitalizing property name#7311
graphite-app[bot] merged 1 commit intomainfrom
11-16-fix_transformer_arrow-function_handle_unicode_when_capitalizing_property_name

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 16, 2024

Previously was assuming property name starts with an ASCII character. If it started with a multi-byte unicode char, &property[1..] would panic.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 16, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 16, 2024

CodSpeed Performance Report

Merging #7311 will not alter performance

Comparing 11-16-fix_transformer_arrow-function_handle_unicode_when_capitalizing_property_name (389b84e) with main (7d75130)

Summary

✅ 30 untouched benchmarks

Copy link
Member

Dunqing commented Nov 17, 2024

Merge activity

@Dunqing Dunqing force-pushed the 11-16-refactor_transformer_arrow-function_generate_super_binding_name_take_str_and_traversectx_ branch from 1c61f62 to a92521d Compare November 17, 2024 05:09
Dunqing pushed a commit that referenced this pull request Nov 17, 2024
…perty name (#7311)

Previously was assuming property name starts with an ASCII character. If it started with a multi-byte unicode char, `&property[1..]` would panic.
@Dunqing Dunqing force-pushed the 11-16-fix_transformer_arrow-function_handle_unicode_when_capitalizing_property_name branch from ddbe935 to 50c18c7 Compare November 17, 2024 05:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 17, 2024
@overlookmotel overlookmotel force-pushed the 11-16-refactor_transformer_arrow-function_generate_super_binding_name_take_str_and_traversectx_ branch from a92521d to 7fc8905 Compare November 17, 2024 10:01
overlookmotel added a commit that referenced this pull request Nov 17, 2024
…perty name (#7311)

Previously was assuming property name starts with an ASCII character. If it started with a multi-byte unicode char, `&property[1..]` would panic.
@overlookmotel overlookmotel force-pushed the 11-16-fix_transformer_arrow-function_handle_unicode_when_capitalizing_property_name branch from 50c18c7 to c4d5c2d Compare November 17, 2024 10:01
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 17, 2024
…perty name (#7311)

Previously was assuming property name starts with an ASCII character. If it started with a multi-byte unicode char, `&property[1..]` would panic.
@overlookmotel overlookmotel force-pushed the 11-16-refactor_transformer_arrow-function_generate_super_binding_name_take_str_and_traversectx_ branch from 7fc8905 to 5cfe0b6 Compare November 17, 2024 10:08
@overlookmotel overlookmotel force-pushed the 11-16-fix_transformer_arrow-function_handle_unicode_when_capitalizing_property_name branch from c4d5c2d to 389b84e Compare November 17, 2024 10:09
Base automatically changed from 11-16-refactor_transformer_arrow-function_generate_super_binding_name_take_str_and_traversectx_ to main November 17, 2024 10:16
@graphite-app graphite-app bot merged commit 389b84e into main Nov 17, 2024
@graphite-app graphite-app bot deleted the 11-16-fix_transformer_arrow-function_handle_unicode_when_capitalizing_property_name branch November 17, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants