test(transformer/async-to-generator): failing test for nested supers

[overlookmotel]

Failing test for async-to-generator transform.

When exiting a function which has super bindings, need to restore previous state of super_methods. It probably needs to be a stack. But not sure if renamed_arguments_symbol_ids needs to be a stack too? I don't really understand this transform, so am not attempting to fix myself.

Babel REPL

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• perf(transformer/arrow-function): reduce string comparisons #7318
• test(transformer/async-to-generator): failing test for nested supers #7314 👈 (View in Graphite)
• perf(transformer/arrow-functions): move arguments transform checks to aid inlining #7322
• perf(transformer/arrow-functions): store state of whether arguments needs transform #7321
• refactor(transformer/arrow-function): comments on possible improvement #7320
• refactor(transformer/arrow-function): reserve correct capacity for Vec #7319
• perf(transformer/arrow-function): create super method binding names lazily #7313
• refactor(transformer/arrow-functions): use IndexMap for super getter/setters #7317
• perf(transformer/arrow-function): optimize generate_super_binding_name #7312
• fix(transformer/arrow-function): handle unicode when capitalizing property name #7311
• refactor(transformer/arrow-function): generate_super_binding_name take &str and &TraverseCtx #7310
• fix(transformer/async-to-generator): arguments isn't correct after transformation #7234
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #7314 will not alter performance

_{Comparing 11-16-tests_transformer_async-to-generator_failing_test_for_nested_supers (63b95fd) with 11-17-perf_transformer_arrow-functions_move_arguments_transform_checks_to_aid_inlining (5e6cbe1)}

Summary

✅ 30 untouched benchmarks

[Dunqing]

renamed_arguments_symbol_ids is used to rename arguments. As for this case, I don't think we need to transform it into a stack.

[Boshen]

Merge activity

• Nov 26, 10:42 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Nov 26, 10:43 AM EST: A user added this pull request to the Graphite merge queue.
• Nov 26, 10:59 AM EST: A user merged this pull request with the Graphite merge queue.