perf(transformer/arrow-functions): store state of whether arguments needs transform

[overlookmotel]

Track whether arguments needs to be transformed. If it doesn't, can skip expensive checks for whether IdentifierReferences and BindingIdentifiers names are arguments or not.

This recovers about half the performance hit of #7234.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• perf(transformer/arrow-function): reduce string comparisons #7318
• test(transformer/async-to-generator): failing test for nested supers #7314
• perf(transformer/arrow-functions): move arguments transform checks to aid inlining #7322
• perf(transformer/arrow-functions): store state of whether arguments needs transform #7321 👈 (View in Graphite)
• refactor(transformer/arrow-function): comments on possible improvement #7320
• refactor(transformer/arrow-function): reserve correct capacity for Vec #7319
• perf(transformer/arrow-function): create super method binding names lazily #7313
• refactor(transformer/arrow-functions): use IndexMap for super getter/setters #7317
• perf(transformer/arrow-function): optimize generate_super_binding_name #7312
• fix(transformer/arrow-function): handle unicode when capitalizing property name #7311
• refactor(transformer/arrow-function): generate_super_binding_name take &str and &TraverseCtx #7310
• fix(transformer/async-to-generator): arguments isn't correct after transformation #7234
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #7321 will create unknown performance changes

_{Comparing 11-17-perf_transformer_arrow-functions_store_state_of_whether_arguments_needs_transform (26d3e96) with main (ea08c1f)}

Summary

🆕 30 new benchmarks

Benchmarks breakdown

	Benchmark	main	11-17-perf_transformer_arrow-functions_store_state_of_whether_arguments_needs_transform	Change
🆕	codegen[checker.ts]	N/A	24.6 ms	N/A
🆕	codegen_sourcemap[checker.ts]	N/A	77.4 ms	N/A
🆕	isolated-declarations[vue-id.ts]	N/A	397.5 ms	N/A
🆕	lexer[RadixUIAdoptionSection.jsx]	N/A	24.1 µs	N/A
🆕	lexer[antd.js]	N/A	22.3 ms	N/A
🆕	lexer[cal.com.tsx]	N/A	5.5 ms	N/A
🆕	lexer[checker.ts]	N/A	13.3 ms	N/A
🆕	lexer[pdf.mjs]	N/A	3.6 ms	N/A
🆕	linter[RadixUIAdoptionSection.jsx]	N/A	2.4 ms	N/A
🆕	linter[cal.com.tsx]	N/A	1.1 s	N/A
🆕	linter[checker.ts]	N/A	2.6 s	N/A
🆕	minifier[antd.js]	N/A	437.2 ms	N/A
🆕	minifier[react.development.js]	N/A	2.9 ms	N/A
🆕	minifier[typescript.js]	N/A	545.4 ms	N/A
🆕	parser[RadixUIAdoptionSection.jsx]	N/A	77.7 µs	N/A
🆕	parser[antd.js]	N/A	106.5 ms	N/A
🆕	parser[cal.com.tsx]	N/A	24.6 ms	N/A
🆕	parser[checker.ts]	N/A	53.5 ms	N/A
🆕	parser[pdf.mjs]	N/A	17.4 ms	N/A
🆕	semantic[RadixUIAdoptionSection.jsx]	N/A	98.6 µs	N/A
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

[Dunqing]

Merge activity

• Nov 17, 12:04 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Nov 17, 12:04 AM EST: A user added this pull request to the Graphite merge queue.
• Nov 17, 12:15 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #7310.
• Nov 17, 12:16 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #7310.
• Nov 17, 5:31 AM EST: A user added this pull request to the Graphite merge queue.
• Nov 17, 5:56 AM EST: A user merged this pull request with the Graphite merge queue.