Skip to content

Comments

perf(transformer/arrow-function): optimize generate_super_binding_name#7312

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-16-perf_transformer_arrow-function_optimize_generate_super_binding_name_
Nov 17, 2024
Merged

perf(transformer/arrow-function): optimize generate_super_binding_name#7312
graphite-app[bot] merged 1 commit intomainfrom
11-16-perf_transformer_arrow-function_optimize_generate_super_binding_name_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 16, 2024

Optimize this function in various ways:

  • Return a static Atom (rather than allocating into arena) if no property.
  • Reserve capacity for ArenaString at start.
  • Make path for unicode identifiers (very rare case) #[cold] and #[inline(never)].
  • Slightly faster uppercase conversion.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 16, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance labels Nov 16, 2024
@overlookmotel overlookmotel force-pushed the 11-16-perf_transformer_arrow-function_optimize_generate_super_binding_name_ branch from af7a5cf to d51e25a Compare November 16, 2024 17:04
@overlookmotel overlookmotel marked this pull request as ready for review November 16, 2024 17:07
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 16, 2024

CodSpeed Performance Report

Merging #7312 will not alter performance

Comparing 11-16-perf_transformer_arrow-function_optimize_generate_super_binding_name_ (0a24703) with main (7d75130)

Summary

✅ 30 untouched benchmarks

Copy link
Member

Dunqing commented Nov 17, 2024

Merge activity

@Dunqing Dunqing force-pushed the 11-16-fix_transformer_arrow-function_handle_unicode_when_capitalizing_property_name branch from ddbe935 to 50c18c7 Compare November 17, 2024 05:09
Dunqing pushed a commit that referenced this pull request Nov 17, 2024
…me` (#7312)

Optimize this function in various ways:

* Return a static `Atom` (rather than allocating into arena) if no `property`.
* Reserve capacity for `ArenaString` at start.
* Make path for unicode identifiers (very rare case) `#[cold]` and `#[inline(never)]`.
* Slightly faster uppercase conversion.
@Dunqing Dunqing force-pushed the 11-16-perf_transformer_arrow-function_optimize_generate_super_binding_name_ branch from d8e397f to 4892875 Compare November 17, 2024 05:10
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 17, 2024
@overlookmotel overlookmotel force-pushed the 11-16-fix_transformer_arrow-function_handle_unicode_when_capitalizing_property_name branch from 50c18c7 to c4d5c2d Compare November 17, 2024 10:01
overlookmotel added a commit that referenced this pull request Nov 17, 2024
…me` (#7312)

Optimize this function in various ways:

* Return a static `Atom` (rather than allocating into arena) if no `property`.
* Reserve capacity for `ArenaString` at start.
* Make path for unicode identifiers (very rare case) `#[cold]` and `#[inline(never)]`.
* Slightly faster uppercase conversion.
@overlookmotel overlookmotel force-pushed the 11-16-perf_transformer_arrow-function_optimize_generate_super_binding_name_ branch from 4892875 to 061207d Compare November 17, 2024 10:01
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 17, 2024
…me` (#7312)

Optimize this function in various ways:

* Return a static `Atom` (rather than allocating into arena) if no `property`.
* Reserve capacity for `ArenaString` at start.
* Make path for unicode identifiers (very rare case) `#[cold]` and `#[inline(never)]`.
* Slightly faster uppercase conversion.
@overlookmotel overlookmotel force-pushed the 11-16-fix_transformer_arrow-function_handle_unicode_when_capitalizing_property_name branch from c4d5c2d to 389b84e Compare November 17, 2024 10:09
@overlookmotel overlookmotel force-pushed the 11-16-perf_transformer_arrow-function_optimize_generate_super_binding_name_ branch from 061207d to 0a24703 Compare November 17, 2024 10:10
Base automatically changed from 11-16-fix_transformer_arrow-function_handle_unicode_when_capitalizing_property_name to main November 17, 2024 10:31
@graphite-app graphite-app bot merged commit 0a24703 into main Nov 17, 2024
@graphite-app graphite-app bot deleted the 11-16-perf_transformer_arrow-function_optimize_generate_super_binding_name_ branch November 17, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants