fix(transformer/async-to-generator): arguments isn't correct after transformation

[Dunqing]

Fix due to this plugin transforming the async method and async arrow function, it caused arguments no longer point the original function.

For example:

Before

class Cls {
  async method() {
    () => {
    	console.log(arguments)
    }
  }
}

After:

class Cls {
  method() {
    var _arguments = arguments;
    return babelHelpers.asyncToGenerator(function* () {
      () => {
        console.log(_arguments);
      };
    })();
  }
}

In this way, the _arguments is its original function's arguments

For performance regression

It seems we need to check the IdentifierReference and BindingIdentifier if it's an arguments, that causes a significant regression, we may need a cheap way to do checking

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[Dunqing]

• perf(transformer/arrow-function): reduce string comparisons #7318
• test(transformer/async-to-generator): failing test for nested supers #7314
• perf(transformer/arrow-functions): move arguments transform checks to aid inlining #7322
• perf(transformer/arrow-functions): store state of whether arguments needs transform #7321
• refactor(transformer/arrow-function): comments on possible improvement #7320
• refactor(transformer/arrow-function): reserve correct capacity for Vec #7319
• perf(transformer/arrow-function): create super method binding names lazily #7313
• refactor(transformer/arrow-functions): use IndexMap for super getter/setters #7317
• perf(transformer/arrow-function): optimize generate_super_binding_name #7312
• fix(transformer/arrow-function): handle unicode when capitalizing property name #7311
• refactor(transformer/arrow-function): generate_super_binding_name take &str and &TraverseCtx #7310
• fix(transformer/async-to-generator): arguments isn't correct after transformation #7234 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #7234 will degrade performances by 10.17%

_{Comparing 11-11-feat_transformer_async-to-generator_arguments_isn_t_correct_after_transformation (7d75130) with main (d445e0f)}

Summary

❌ 3 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	11-11-feat_transformer_async-to-generator_arguments_isn_t_correct_after_transformation	Change
❌	transformer[antd.js]	45.3 ms	48.7 ms	-6.84%
❌	transformer[checker.ts]	18 ms	20 ms	-10.17%
❌	transformer[pdf.mjs]	6.6 ms	7.1 ms	-6.57%

[overlookmotel]

I've squashed the 3 commits and rebased on main, updating the code to take into account #7300. I caused that problem by delaying in reviewing this, so I've cleaned up the mess I made!

I can't say I really understand the logic of async function transform, so can't give a review on the "meat" of this PR. I've pushed a few commits with small optimizations and style nits. Feel free to revert any of them that you don't like.

I assume the perf impact is due to string comparisons on every single IdentifierReference and BindingIdentifier. Not much we can do about that at present I don't think.

I do think the fixtures should be altered, but @Dunqing feel free to merge and then do that in follow-up PR if you prefer.

[Dunqing]

Merge activity

• Nov 17, 12:01 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Nov 17, 12:01 AM EST: A user added this pull request to the Graphite merge queue.
• Nov 17, 12:06 AM EST: A user merged this pull request with the Graphite merge queue.