Skip to content

perf(transformer/arrow-functions): inline hot visitors#7329

Closed
overlookmotel wants to merge 1 commit intomainfrom
11-17-perf_transformer_arrow-functions_inline_hot_visitors
Closed

perf(transformer/arrow-functions): inline hot visitors#7329
overlookmotel wants to merge 1 commit intomainfrom
11-17-perf_transformer_arrow-functions_inline_hot_visitors

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 17, 2024

Follow-on after #7322. Add more #[inline] attrs to make absolutely sure these methods are inlined.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Nov 17, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Nov 17, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #7329 will not alter performance

Comparing 11-17-perf_transformer_arrow-functions_inline_hot_visitors (af50c68) with main (44fd962)

Summary

✅ 30 untouched benchmarks

@overlookmotel
Copy link
Member Author

Not clear this is an improvement.

@overlookmotel overlookmotel deleted the 11-17-perf_transformer_arrow-functions_inline_hot_visitors branch November 17, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant