fix(oxlint/lsp): error on unknown command

[Sysix]

Pull request overview

Adjusts LSP workspace command execution so unknown/unsupported commands surface as errors (instead of silently returning null), by removing the pre-dispatch “responsible tool” check and updating tests accordingly.

[Sysix]

• fix(oxlint/lsp): error on unknown command #20841 👈 (View in Graphite)
• refactor(lsp): accept only one Tool & ToolBuilder #20840
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

Adjusts LSP workspace command execution so unknown/unsupported commands surface as errors (instead of silently returning null), by removing the pre-dispatch “responsible tool” check and updating tests accordingly.

Changes:

• Remove Tool::is_responsible_for_command and always delegate command execution to Tool::execute_command.
• Update worker- and integration-level tests to expect an error for unknown commands.
• Remove now-unused is_responsible_for_command implementations in test and linter tools.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
crates/oxc_language_server/src/worker.rs	Always forwards commands to the tool; worker test updated for unknown-command error.
crates/oxc_language_server/src/tool.rs	Removes responsibility hook from the Tool trait.
crates/oxc_language_server/src/tests.rs	Updates LSP integration test to expect an error for invalid command.
apps/oxlint/src/lsp/server_linter.rs	Removes responsibility hook implementation for the linter tool.

Comments suppressed due to low confidence (2)

apps/oxlint/src/lsp/server_linter.rs:560

• ServerLinter::execute_command currently returns Ok(None) for unknown commands. With is_responsible_for_command removed and the PR goal being to error on unknown commands, this should return Err(ErrorCode::MethodNotFound) when command is not recognized; otherwise the LSP will still respond with a null result for invalid commands.

    /// Tries to execute the given command with the provided arguments.
    /// If the command is not recognized, returns `Ok(None)`.
    /// If the command is recognized and executed it can return:
    /// - `Ok(Some(WorkspaceEdit))` if the command was executed successfully and produced a workspace edit.
    /// - `Ok(None)` if the command was executed successfully but did not produce any workspace edit.
    ///
    /// # Errors
    /// Returns an `ErrorCode::InvalidParams` if the command arguments are invalid.
    fn execute_command(
        &self,
        command: &str,
        arguments: Vec<serde_json::Value>,
    ) -> Result<Option<WorkspaceEdit>, ErrorCode> {
        if command != FIX_ALL_COMMAND_ID {
            return Ok(None);
        }

crates/oxc_language_server/src/tool.rs:74

• Tool::execute_command docs and default implementation still indicate unknown commands should return Ok(None), but after removing is_responsible_for_command the worker now relies on execute_command to signal unknown commands (tests expect ErrorCode::MethodNotFound). Align the contract by updating the doc comment and changing the default implementation to return Err(ErrorCode::MethodNotFound) for unrecognized commands (or otherwise document the intended behavior clearly).

    /// Tries to execute the given command with the provided arguments.
    /// If the command is not recognized, returns `Ok(None)`.
    /// If the command is recognized and executed it can return:
    /// - `Ok(Some(WorkspaceEdit))` if the command was executed successfully and produced a workspace edit.
    /// - `Ok(None)` if the command was executed successfully but did not produce any workspace edit.
    ///
    /// # Errors
    /// If there was an error executing the command, returns an `Err(ErrorCode)`.
    fn execute_command(
        &self,
        _command: &str,
        _arguments: Vec<serde_json::Value>,
    ) -> Result<Option<WorkspaceEdit>, ErrorCode> {
        Ok(None)
    }

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

crates/oxc_language_server/src/tool.rs:74

• The docs now state that unrecognized commands should return Err(ErrorCode), but the default Tool::execute_command implementation still returns Ok(None). Either update the docs to reflect the default behavior, or change the default implementation to return an error (and adjust Backend::execute_command dispatch semantics accordingly).

    /// Tries to execute the given command with the provided arguments.
    /// If the command is not recognized, returns `Err(ErrorCode)`.
    /// If the command is recognized and executed it can return:
    /// - `Ok(Some(WorkspaceEdit))` if the command was executed successfully and produced a workspace edit.
    /// - `Ok(None)` if the command was executed successfully but did not produce any workspace edit.
    ///
    /// # Errors
    /// If there was an error executing the command, returns an `Err(ErrorCode)`.
    fn execute_command(
        &self,
        _command: &str,
        _arguments: Vec<serde_json::Value>,
    ) -> Result<Option<WorkspaceEdit>, ErrorCode> {
        Ok(None)
    }

[camc314]

Merge activity

• Mar 29, 7:50 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 29, 7:50 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Mar 29, 7:54 PM UTC: Merged by the Graphite merge queue.