fix(diagnostics): skip minified fallback for single-line reporters by camc314 · Pull Request #20716 · oxc-project/oxc

camc314 · 2026-03-24T21:47:55Z

fixes #20712

camc314 · 2026-03-24T21:48:12Z

fix(diagnostics): skip minified fallback for single-line reporters #20716 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-03-24T21:51:17Z

Merging this PR will not alter performance

✅ 53 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing c/03-24-fix_diagnostics_skip_minified_fallback_for_single-line_reporters (c281e8f) with main (0dc620d)²}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (e15ea3f) during the generation of this report, so 0dc620d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull request overview

This PR addresses truncated/missing output in CI by preventing DiagnosticService from replacing long single-line reporter output with the synthetic “minified file” warning, which can suppress subsequent diagnostics for formats like GitHub Actions annotations.

Changes:

Add DiagnosticReporter::supports_minified_file_fallback() (defaulting to true) to let reporters opt out of the long-line “minified” fallback.
Gate the long-line fallback in DiagnosticService::run() behind that reporter capability.
Disable the fallback for single-line reporters (github, unix) and add regression tests.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
crates/oxc_diagnostics/src/service.rs	Gates minified fallback behind reporter support; adds unit tests for fallback on/off behavior.
crates/oxc_diagnostics/src/reporter.rs	Extends `DiagnosticReporter` trait with `supports_minified_file_fallback()` and documentation.
apps/oxlint/src/output_formatter/unix.rs	Opts Unix reporter out of minified fallback.
apps/oxlint/src/output_formatter/github.rs	Opts GitHub reporter out of minified fallback; adds a regression test.

crates/oxc_diagnostics/src/service.rs

apps/oxlint/src/output_formatter/github.rs

camc314 · 2026-03-24T22:07:09Z

Merge activity

Mar 24, 10:07 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 24, 10:18 PM UTC: camc314 added this pull request to the Graphite merge queue.
Mar 24, 10:22 PM UTC: Merged by the Graphite merge queue.

…20716) fixes #20712

# Oxlint ### 💥 BREAKING CHANGES - c0ebbce linter: [**BREAKING**] Report error on unknown builtin rule (#20464) (camc314) ### 🚀 Features - 04f85e5 linter/no-unused-vars: Add safe-fix option for import fixes (#20839) (Marcell Toth) - 32a3706 linter/eslint-vitest-plugin: Implements `require-test-timeout` rule (#20806) (Said Atrahouch) - ae03653 linter: Implement suggestion for `eslint/no-useless-computed-key` rule (#20805) (Mikhail Baev) - 6624513 linter/prefer-string-starts-ends-with: Move rule from nursery to style (#20797) (camc314) - 58941f8 linter/prefer-readonly: Move rule from nursery to style (#20796) (camc314) - 8837ffd linter/prefer-regexp-exec: Move rule from nursery to style (#20795) (camc314) - 7e88871 linter/prefer-find: Move rule out of nursery (#20794) (camc314) - ca6e5bc linter/vitest: Implement prefer-called-exactly-once-with (#17562) (Said Atrahouch) - e80c0bf linter/eslint-plugin-vitest: Implement `require-mock-type-parameters` (#20785) (Said Atrahouch) - cec8b8f linter/vitest: Implement require-awaited-expect-poll rule (#20702) (Said Atrahouch) - d8e9d01 linter/eslint-plugin-vitest: Set `prefer-to-have-been-called-times` compatible with jest (#20703) (Said Atrahouch) - caf8231 linter: Enhance import plugin diagnostics with help messages (#20766) (离谱) - f44adfa linter: Improve the oxlint config generated by `--init`. (#20632) (connorshea) - 43f4827 linter: Add help text to jest and promise diagnostics (#20640) (kszongic) - 16516de linter: Enhance types for `DummyRule` (#20751) (camc314) - 27374e8 linter: Add hint about node version when ts config fail to import (#20570) (camc314) - 8e34150 linter/eslint-plugin-vitest: Sync rule with JS implementation (#20679) (Said Atrahouch) ### 🐛 Bug Fixes - df057d5 linter/no-noninteractive-tabindex: Add missing composite widget … (#20860) (bab) - bb34073 linter: Mark vitest/valid-title as a compatible jest rules (#20463) (Nicolas Le Cam) - bd2c76b linter: Handle shadowed locals in no-restricted-globals (#20811) (Ulrich Stark) - 62e39be linter: Sort nested object keys in fix of `eslint/sort-keys` in one pass (#20838) (Ulrich Stark) - 3ef37da oxlint/lsp: Error on unknown command (#20841) (Sysix) - ab1070d oxlint/cli: Skip parsing base config again for nested config search (#20809) (Sysix) - 2be3728 oxlint/lsp: Skip parsing base config again for nested config search (#20808) (Sysix) - 6171217 oxlint: Respect `NO_COLOR` env for `format=stylish` (#20804) (Sysix) - d89ae8f linter/plugins: Patch `WeakMap` to emulate `WeakMap`s keyed by `sourceCode` (#20799) (overlookmotel) - c610666 linter/no-shadow: Respect env settings when builtinGlobals is enabled (#20429) (vvnikita74) - 6bb502f linter/no-invalid-void-type: Allow void generic args in heritage clauses (#20780) (camc314) - 365bb7d linter: Skip typed nested literals in explicit-module-boundary-types (#20776) (camc314) - 0aa1ff0 linter/plugins: Ensure `after` hook is always called in ESLint compat mode (#20721) (overlookmotel) - 31145a9 linter/plugins: Fire `after` hook after CFG events in ESLint compat (#20720) (overlookmotel) - c09a5ab diagnostics: Skip minified fallback for single-line reporters (#20716) (camc314) - e4dc9a1 linter: Isolate `--init` config writes from parallel tests (#20717) (camc314) - 7e394ec linter: Clarify empty replacement fixer help text (#20698) (camc314) - d15a99c linter/jsx-curly-brace-presence: Flag empty string literals (#20690) (camc314) ### 📚 Documentation - c722495 linter: Update JS Plugins + LS references (#20843) (camc314) - e1f9748 linter/jsdoc/require-property: Fix typo (#20792) (Benjaming61001) - be3dcc1 linter: Add note about node version + custom TS plugin (#19381) (camc314) # Oxfmt ### 🚀 Features - 6ef440a oxfmt: Support bool for object style options (#20853) (leaysgur) - 23050fa oxfmt: Support markdown-in-js substitution (#20683) (leaysgur) - 4087295 oxfmt: Support angular-in-js substitution (#20676) (leaysgur)

github-actions bot added A-linter Area - Linter A-cli Area - CLI C-bug Category - Bug labels Mar 24, 2026

camc314 marked this pull request as ready for review March 24, 2026 21:49

Copilot AI review requested due to automatic review settings March 24, 2026 21:49

Copilot started reviewing on behalf of camc314 March 24, 2026 21:50 View session

camc314 force-pushed the c/03-24-fix_diagnostics_skip_minified_fallback_for_single-line_reporters branch from 489d7b6 to cb6c67c Compare March 24, 2026 21:50

Copilot AI reviewed Mar 24, 2026

View reviewed changes

crates/oxc_diagnostics/src/service.rs Outdated Show resolved Hide resolved

apps/oxlint/src/output_formatter/github.rs Show resolved Hide resolved

camc314 force-pushed the c/03-24-fix_diagnostics_skip_minified_fallback_for_single-line_reporters branch from cb6c67c to cdffef2 Compare March 24, 2026 21:56

camc314 self-assigned this Mar 24, 2026

github-actions bot added the A-linter-plugins Area - Linter JS plugins label Mar 24, 2026

camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 24, 2026

fix(diagnostics): skip minified fallback for single-line reporters (#…

c09a5ab

…20716) fixes #20712

graphite-app bot force-pushed the c/03-24-fix_diagnostics_skip_minified_fallback_for_single-line_reporters branch from 2925f43 to c09a5ab Compare March 24, 2026 22:18

graphite-app bot merged commit c09a5ab into main Mar 24, 2026
26 checks passed

graphite-app bot deleted the c/03-24-fix_diagnostics_skip_minified_fallback_for_single-line_reporters branch March 24, 2026 22:22

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 24, 2026

This was referenced Mar 30, 2026

release(crates): oxc v0.123.0 #20862

Merged

release(apps): oxlint v1.58.0 && oxfmt v0.43.0 #20867

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(diagnostics): skip minified fallback for single-line reporters#20716

fix(diagnostics): skip minified fallback for single-line reporters#20716
graphite-app[bot] merged 1 commit intomainfrom
c/03-24-fix_diagnostics_skip_minified_fallback_for_single-line_reporters

camc314 commented Mar 24, 2026

Uh oh!

camc314 commented Mar 24, 2026

Uh oh!

codspeed-hq bot commented Mar 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

camc314 commented Mar 24, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

camc314 commented Mar 24, 2026

Uh oh!

camc314 commented Mar 24, 2026

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

camc314 commented Mar 24, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq bot commented Mar 24, 2026 •

edited

Loading

camc314 commented Mar 24, 2026 •

edited by graphite-app bot

Loading