feat(linter): implement eslint-plugin-vitest/prefer-called-exactly-once-with#17562
Open
Afsoon wants to merge 21 commits intooxc-project:mainfrom
Open
feat(linter): implement eslint-plugin-vitest/prefer-called-exactly-once-with#17562Afsoon wants to merge 21 commits intooxc-project:mainfrom
Afsoon wants to merge 21 commits intooxc-project:mainfrom
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
a381eae to
d392f84
Compare
Contributor
Author
|
Conflicts resolved |
bdcf7a7 to
f609d86
Compare
144c32f to
6d7e89d
Compare
Contributor
Author
6d7e89d to
a4aad15
Compare
…sts. Missing nested block statements of test and related methods
…ing against strings
…line of code to his own function
…heck to outer and deleted the duplication of logic
…cs, one stating the replacing value and the other one the deletion. The fixes are isolated per diagnostic. Using the default help text
…ostics and method to extract matcher and identefier name.
a4aad15 to
e12cee6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4656
Summary
The PR implement
prefer-called-exactly-once-withwhich is a missing recommended vitest rules. The decisions that I took are:- 1 diagnostic for the substitution
- 1 diagnostic for the deletion of the second expect.
Questions
should_runto run this rule only on test files or not? Only if it's possible.