fix(oxlint/cli): skip parsing base config again for nested config search by Sysix · Pull Request #20809 · oxc-project/oxc

Sysix · 2026-03-27T17:27:10Z

Added a skip check for the base config to avoid parsing it again. Very useful for JS config or JS plugins, where we need roundtrips to JS integrations.

closes #16356

Sysix · 2026-03-27T17:27:22Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

Updates oxlint’s CLI/config-loading behavior to avoid re-processing the base/root config when searching for nested configs, and refreshes related golden snapshots.

Changes:

Add base_config_path filtering to discover_configs_in_ancestors to skip re-discovering the base config.
Update CLI/snapshot outputs to include “with rules” in the finishing line.
Standardize several configuration failure messages in fixture snapshots.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
apps/oxlint/src/config_loader.rs	Skips returning the base config during ancestor discovery to prevent duplicate loading.
apps/oxlint/test/fixtures/settings/output.snap.md	Snapshot update for new “with rules” summary text.
apps/oxlint/test/fixtures/plugin_name_alias_reserved/output.snap.md	Snapshot error message changed to a more generic parse failure.
apps/oxlint/test/fixtures/plugin_name_alias_invalid/output.snap.md	Snapshot error message changed to a more generic parse failure.
apps/oxlint/test/fixtures/overrides_missing_rule/output.snap.md	Snapshot error message changed to a more generic build failure.
apps/oxlint/test/fixtures/nested_config_duplicate/output.snap.md	Snapshot update for new “with rules” summary text.
apps/oxlint/test/fixtures/nested_config/output.snap.md	Snapshot update for new “with rules” summary text.
apps/oxlint/test/fixtures/lint_createOnce_error/output.snap.md	Snapshot error message changed to a more generic parse failure.
apps/oxlint/test/fixtures/js_config_extends_js_plugins_relative_banned_string/output.snap.md	Snapshot error message changed to a more generic parse failure.
apps/oxlint/test/fixtures/js_config_extends_js_plugins_relative_banned_override/output.snap.md	Snapshot error message changed to a more generic parse failure.
apps/oxlint/test/fixtures/js_config_extends_js_plugins_relative_banned_object/output.snap.md	Snapshot error message changed to a more generic parse failure.
apps/oxlint/src/snapshots/fixtures__cli__ignore_patterns_empty_nested_ .@oxlint.snap	Snapshot update for new “with rules” summary text.
apps/oxlint/src/snapshots/fixtures__cli__ignore_pattern_non_glob_syntax_ .@oxlint.snap	Snapshot update for new “with rules” summary text.

apps/oxlint/src/config_loader.rs

apps/oxlint/test/fixtures/plugin_name_alias_reserved/output.snap.md

apps/oxlint/test/fixtures/overrides_missing_rule/output.snap.md

apps/oxlint/src/snapshots/fixtures__cli__ignore_pattern_non_glob_syntax_ .@oxlint.snap

codspeed-hq · 2026-03-27T18:33:29Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks¹

_{Comparing 03-27-fix_oxlint_cli_skip_parsing_base_config_again_for_nested_config_search (8da080d) with main (6624513)²}

52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on 03-27-fix_oxlint_lsp_skip_parsing_base_config_again_for_nested_config_search (b295b31) during the generation of this report, so main (6624513) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

apps/oxlint/src/snapshots/fixtures__cli_issue_10054@oxlint.snap

camc314 · 2026-03-27T19:13:10Z

Merge activity

Mar 27, 7:13 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 27, 7:13 PM UTC: camc314 added this pull request to the Graphite merge queue.
Mar 27, 7:22 PM UTC: Merged by the Graphite merge queue.

…rch (#20809) Added a skip check for the base config to avoid parsing it again. Very useful for JS config or JS plugins, where we need roundtrips to JS integrations. closes #16356

# Oxlint ### 💥 BREAKING CHANGES - c0ebbce linter: [**BREAKING**] Report error on unknown builtin rule (#20464) (camc314) ### 🚀 Features - 04f85e5 linter/no-unused-vars: Add safe-fix option for import fixes (#20839) (Marcell Toth) - 32a3706 linter/eslint-vitest-plugin: Implements `require-test-timeout` rule (#20806) (Said Atrahouch) - ae03653 linter: Implement suggestion for `eslint/no-useless-computed-key` rule (#20805) (Mikhail Baev) - 6624513 linter/prefer-string-starts-ends-with: Move rule from nursery to style (#20797) (camc314) - 58941f8 linter/prefer-readonly: Move rule from nursery to style (#20796) (camc314) - 8837ffd linter/prefer-regexp-exec: Move rule from nursery to style (#20795) (camc314) - 7e88871 linter/prefer-find: Move rule out of nursery (#20794) (camc314) - ca6e5bc linter/vitest: Implement prefer-called-exactly-once-with (#17562) (Said Atrahouch) - e80c0bf linter/eslint-plugin-vitest: Implement `require-mock-type-parameters` (#20785) (Said Atrahouch) - cec8b8f linter/vitest: Implement require-awaited-expect-poll rule (#20702) (Said Atrahouch) - d8e9d01 linter/eslint-plugin-vitest: Set `prefer-to-have-been-called-times` compatible with jest (#20703) (Said Atrahouch) - caf8231 linter: Enhance import plugin diagnostics with help messages (#20766) (离谱) - f44adfa linter: Improve the oxlint config generated by `--init`. (#20632) (connorshea) - 43f4827 linter: Add help text to jest and promise diagnostics (#20640) (kszongic) - 16516de linter: Enhance types for `DummyRule` (#20751) (camc314) - 27374e8 linter: Add hint about node version when ts config fail to import (#20570) (camc314) - 8e34150 linter/eslint-plugin-vitest: Sync rule with JS implementation (#20679) (Said Atrahouch) ### 🐛 Bug Fixes - df057d5 linter/no-noninteractive-tabindex: Add missing composite widget … (#20860) (bab) - bb34073 linter: Mark vitest/valid-title as a compatible jest rules (#20463) (Nicolas Le Cam) - bd2c76b linter: Handle shadowed locals in no-restricted-globals (#20811) (Ulrich Stark) - 62e39be linter: Sort nested object keys in fix of `eslint/sort-keys` in one pass (#20838) (Ulrich Stark) - 3ef37da oxlint/lsp: Error on unknown command (#20841) (Sysix) - ab1070d oxlint/cli: Skip parsing base config again for nested config search (#20809) (Sysix) - 2be3728 oxlint/lsp: Skip parsing base config again for nested config search (#20808) (Sysix) - 6171217 oxlint: Respect `NO_COLOR` env for `format=stylish` (#20804) (Sysix) - d89ae8f linter/plugins: Patch `WeakMap` to emulate `WeakMap`s keyed by `sourceCode` (#20799) (overlookmotel) - c610666 linter/no-shadow: Respect env settings when builtinGlobals is enabled (#20429) (vvnikita74) - 6bb502f linter/no-invalid-void-type: Allow void generic args in heritage clauses (#20780) (camc314) - 365bb7d linter: Skip typed nested literals in explicit-module-boundary-types (#20776) (camc314) - 0aa1ff0 linter/plugins: Ensure `after` hook is always called in ESLint compat mode (#20721) (overlookmotel) - 31145a9 linter/plugins: Fire `after` hook after CFG events in ESLint compat (#20720) (overlookmotel) - c09a5ab diagnostics: Skip minified fallback for single-line reporters (#20716) (camc314) - e4dc9a1 linter: Isolate `--init` config writes from parallel tests (#20717) (camc314) - 7e394ec linter: Clarify empty replacement fixer help text (#20698) (camc314) - d15a99c linter/jsx-curly-brace-presence: Flag empty string literals (#20690) (camc314) ### 📚 Documentation - c722495 linter: Update JS Plugins + LS references (#20843) (camc314) - e1f9748 linter/jsdoc/require-property: Fix typo (#20792) (Benjaming61001) - be3dcc1 linter: Add note about node version + custom TS plugin (#19381) (camc314) # Oxfmt ### 🚀 Features - 6ef440a oxfmt: Support bool for object style options (#20853) (leaysgur) - 23050fa oxfmt: Support markdown-in-js substitution (#20683) (leaysgur) - 4087295 oxfmt: Support angular-in-js substitution (#20676) (leaysgur)

Sysix mentioned this pull request Mar 27, 2026

fix(oxlint/lsp): skip parsing base config again for nested config search #20808

Merged

github-actions bot added A-linter Area - Linter A-cli Area - CLI C-bug Category - Bug labels Mar 27, 2026

Sysix changed the title ~~fix(oxlint(cli): skip parsing base config again for nested config search~~ fix(oxlint/cli): skip parsing base config again for nested config search Mar 27, 2026

Sysix force-pushed the 03-27-fix_oxlint_cli_skip_parsing_base_config_again_for_nested_config_search branch from 82d82fb to a3fad3c Compare March 27, 2026 17:34

github-actions bot added the A-linter-plugins Area - Linter JS plugins label Mar 27, 2026

Sysix requested a review from Copilot March 27, 2026 17:36

Copilot AI reviewed Mar 27, 2026

View reviewed changes

Sysix force-pushed the 03-27-fix_oxlint_cli_skip_parsing_base_config_again_for_nested_config_search branch from a3fad3c to fb6f367 Compare March 27, 2026 17:53

Sysix force-pushed the 03-27-fix_oxlint_lsp_skip_parsing_base_config_again_for_nested_config_search branch from c4f3d0f to b295b31 Compare March 27, 2026 17:53

Sysix marked this pull request as ready for review March 27, 2026 17:54

Sysix requested a review from camc314 as a code owner March 27, 2026 17:54

Sysix assigned camc314 Mar 27, 2026

Sysix marked this pull request as draft March 27, 2026 18:21

Sysix force-pushed the 03-27-fix_oxlint_cli_skip_parsing_base_config_again_for_nested_config_search branch from fb6f367 to 8da080d Compare March 27, 2026 18:27

Sysix commented Mar 27, 2026

View reviewed changes

apps/oxlint/src/snapshots/fixtures__cli_issue_10054@oxlint.snap Show resolved Hide resolved

Sysix marked this pull request as ready for review March 27, 2026 18:35

camc314 approved these changes Mar 27, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 27, 2026

graphite-app bot changed the base branch from 03-27-fix_oxlint_lsp_skip_parsing_base_config_again_for_nested_config_search to graphite-base/20809 March 27, 2026 19:12

graphite-app bot changed the base branch from graphite-base/20809 to main March 27, 2026 19:17

github-actions bot added the A-editor Area - Editor and Language Server label Mar 27, 2026

fix(oxlint/cli): skip parsing base config again for nested config sea…

ab1070d

…rch (#20809) Added a skip check for the base config to avoid parsing it again. Very useful for JS config or JS plugins, where we need roundtrips to JS integrations. closes #16356

graphite-app bot force-pushed the 03-27-fix_oxlint_cli_skip_parsing_base_config_again_for_nested_config_search branch from 8da080d to ab1070d Compare March 27, 2026 19:18

graphite-app bot merged commit ab1070d into main Mar 27, 2026
26 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 27, 2026

graphite-app bot deleted the 03-27-fix_oxlint_cli_skip_parsing_base_config_again_for_nested_config_search branch March 27, 2026 19:22

Sysix mentioned this pull request Mar 27, 2026

linter/perf: move/skip base config search when searching inside a directory #20812

Open

Boshen mentioned this pull request Mar 30, 2026

release(apps): oxlint v1.58.0 && oxfmt v0.43.0 #20867

Merged

camc314 mentioned this pull request Mar 31, 2026

linter: .oxlintrc.json in parent directory overrides config in current directory #20904

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(oxlint/cli): skip parsing base config again for nested config search#20809

fix(oxlint/cli): skip parsing base config again for nested config search#20809
graphite-app[bot] merged 1 commit intomainfrom
03-27-fix_oxlint_cli_skip_parsing_base_config_again_for_nested_config_search

Sysix commented Mar 27, 2026 •

edited

Loading

Uh oh!

Sysix commented Mar 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Mar 27, 2026

Uh oh!

Uh oh!

camc314 commented Mar 27, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Sysix commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Mar 27, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

camc314 commented Mar 27, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sysix commented Mar 27, 2026 •

edited

Loading

Sysix commented Mar 27, 2026 •

edited

Loading

camc314 commented Mar 27, 2026 •

edited by graphite-app bot

Loading