Skip to content

feat(oxfmt): Support markdown-in-js substitution#20683

Merged
1 commit merged intomainfrom
03-24-feat_oxfmt_support_markdown-in-js_substitution
Mar 24, 2026
Merged

feat(oxfmt): Support markdown-in-js substitution#20683
1 commit merged intomainfrom
03-24-feat_oxfmt_support_markdown-in-js_substitution

Conversation

@leaysgur
Copy link
Copy Markdown
Member

@leaysgur leaysgur commented Mar 24, 2026

Part of #15180, and the last piece...!

Copy link
Copy Markdown
Member Author

leaysgur commented Mar 24, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter labels Mar 24, 2026
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Mar 24, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 24, 2026

Merging this PR will not alter performance

✅ 49 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing 03-24-feat_oxfmt_support_markdown-in-js_substitution (804f2b7) with 03-24-feat_oxfmt_support_angular-in-js_substitution (21affeb)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@leaysgur leaysgur force-pushed the 03-24-feat_oxfmt_support_markdown-in-js_substitution branch from 96a052a to b2930c2 Compare March 24, 2026 08:15
@leaysgur leaysgur force-pushed the 03-24-feat_oxfmt_support_angular-in-js_substitution branch from 97a0a79 to 21affeb Compare March 24, 2026 08:15
@leaysgur leaysgur force-pushed the 03-24-feat_oxfmt_support_markdown-in-js_substitution branch from b2930c2 to 804f2b7 Compare March 24, 2026 08:28
@leaysgur
Copy link
Copy Markdown
Member Author

leaysgur commented Mar 24, 2026

Oxfmt Ecosystem CI

suite oxfmt@latest 804f2b7 branch
vercel/turborepo
eggjs/egg
monkeytypegame/monkeytype
actualbudget/actual
fuma-nama/fumadocs
formatjs/formatjs
fastify/fastify-vite
vuejs/pinia
vuejs/core
AmanVarshney01/create-better-t-stack
huggingface/huggingface.js
tale/headplane
Comfy-Org/ComfyUI_frontend
cnpm/cnpmcore
lichess-org/lila
npmx-dev/npmx.dev
aidenybai/react-grab
openclaw/openclaw
cloudflare/agents
rolldown/rolldown
getsentry/sentry-javascript
dyad-sh/dyad
mastodon/mastodon

@leaysgur
Copy link
Copy Markdown
Member Author

leaysgur commented Mar 24, 2026

  • openclaw/openclaw: Diff by html-in-js, v0.42 is not yet released
  • getsentry/sentry-javascript: Diff by angular-in-js

👌🏻


Now I'm wondering should we add it as v0.42 or defer it...?

@leaysgur leaysgur marked this pull request as ready for review March 24, 2026 08:50
@leaysgur leaysgur requested a review from Dunqing as a code owner March 24, 2026 08:50
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Mar 24, 2026
Copy link
Copy Markdown
Member

Dunqing commented Mar 24, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 03-24-feat_oxfmt_support_angular-in-js_substitution branch from 21affeb to 4087295 Compare March 24, 2026 13:13
@graphite-app graphite-app bot force-pushed the 03-24-feat_oxfmt_support_markdown-in-js_substitution branch from 804f2b7 to 23050fa Compare March 24, 2026 13:14
Base automatically changed from 03-24-feat_oxfmt_support_angular-in-js_substitution to main March 24, 2026 13:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 24, 2026
@Boshen Boshen closed this pull request by merging all changes into main in f47502b Mar 24, 2026
@Boshen Boshen deleted the 03-24-feat_oxfmt_support_markdown-in-js_substitution branch March 24, 2026 15:32
graphite-app bot pushed a commit that referenced this pull request Mar 30, 2026
# Oxlint
### 💥 BREAKING CHANGES

- c0ebbce linter: [**BREAKING**] Report error on unknown builtin rule (#20464) (camc314)

### 🚀 Features

- 04f85e5 linter/no-unused-vars: Add safe-fix option for import fixes (#20839) (Marcell Toth)
- 32a3706 linter/eslint-vitest-plugin: Implements `require-test-timeout` rule (#20806) (Said Atrahouch)
- ae03653 linter: Implement suggestion for `eslint/no-useless-computed-key` rule (#20805) (Mikhail Baev)
- 6624513 linter/prefer-string-starts-ends-with: Move rule from nursery to style (#20797) (camc314)
- 58941f8 linter/prefer-readonly: Move rule from nursery to style (#20796) (camc314)
- 8837ffd linter/prefer-regexp-exec: Move rule from nursery to style (#20795) (camc314)
- 7e88871 linter/prefer-find: Move rule out of nursery (#20794) (camc314)
- ca6e5bc linter/vitest: Implement prefer-called-exactly-once-with (#17562) (Said Atrahouch)
- e80c0bf linter/eslint-plugin-vitest: Implement `require-mock-type-parameters` (#20785) (Said Atrahouch)
- cec8b8f linter/vitest: Implement require-awaited-expect-poll rule (#20702) (Said Atrahouch)
- d8e9d01 linter/eslint-plugin-vitest: Set `prefer-to-have-been-called-times` compatible with jest (#20703) (Said Atrahouch)
- caf8231 linter: Enhance import plugin diagnostics with help messages (#20766) (离谱)
- f44adfa linter: Improve the oxlint config generated by `--init`. (#20632) (connorshea)
- 43f4827 linter: Add help text to jest and promise diagnostics (#20640) (kszongic)
- 16516de linter: Enhance types for `DummyRule` (#20751) (camc314)
- 27374e8 linter: Add hint about node version when ts config fail to import (#20570) (camc314)
- 8e34150 linter/eslint-plugin-vitest: Sync rule with JS implementation (#20679) (Said Atrahouch)

### 🐛 Bug Fixes

- df057d5 linter/no-noninteractive-tabindex: Add missing composite widget … (#20860) (bab)
- bb34073 linter: Mark vitest/valid-title as a compatible jest rules (#20463) (Nicolas Le Cam)
- bd2c76b linter: Handle shadowed locals in no-restricted-globals (#20811) (Ulrich Stark)
- 62e39be linter: Sort nested object keys in fix of `eslint/sort-keys` in one pass (#20838) (Ulrich Stark)
- 3ef37da oxlint/lsp: Error on unknown command (#20841) (Sysix)
- ab1070d oxlint/cli: Skip parsing base config again for nested config search (#20809) (Sysix)
- 2be3728 oxlint/lsp: Skip parsing base config again for nested config search (#20808) (Sysix)
- 6171217 oxlint: Respect `NO_COLOR` env for `format=stylish` (#20804) (Sysix)
- d89ae8f linter/plugins: Patch `WeakMap` to emulate `WeakMap`s keyed by `sourceCode` (#20799) (overlookmotel)
- c610666 linter/no-shadow: Respect env settings when builtinGlobals is enabled (#20429) (vvnikita74)
- 6bb502f linter/no-invalid-void-type: Allow void generic args in heritage clauses (#20780) (camc314)
- 365bb7d linter: Skip typed nested literals in explicit-module-boundary-types (#20776) (camc314)
- 0aa1ff0 linter/plugins: Ensure `after` hook is always called in ESLint compat mode (#20721) (overlookmotel)
- 31145a9 linter/plugins: Fire `after` hook after CFG events in ESLint compat (#20720) (overlookmotel)
- c09a5ab diagnostics: Skip minified fallback for single-line reporters (#20716) (camc314)
- e4dc9a1 linter: Isolate `--init` config writes from parallel tests (#20717) (camc314)
- 7e394ec linter: Clarify empty replacement fixer help text (#20698) (camc314)
- d15a99c linter/jsx-curly-brace-presence: Flag empty string literals (#20690) (camc314)

### 📚 Documentation

- c722495 linter: Update JS Plugins + LS references (#20843) (camc314)
- e1f9748 linter/jsdoc/require-property: Fix typo (#20792) (Benjaming61001)
- be3dcc1 linter: Add note about node version + custom TS plugin (#19381) (camc314)
# Oxfmt
### 🚀 Features

- 6ef440a oxfmt: Support bool for object style options (#20853) (leaysgur)
- 23050fa oxfmt: Support markdown-in-js substitution (#20683) (leaysgur)
- 4087295 oxfmt: Support angular-in-js substitution (#20676) (leaysgur)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants