fix(linter): isolate `--init` config writes from parallel tests by camc314 · Pull Request #20717 · oxc-project/oxc

camc314 · 2026-03-24T21:53:40Z

run_init wrote .oxlintrc.json to the process current directory instead of
the CliRunner cwd. In the oxlint test suite, test_init_config relied on
that behavior and created/deleted a real config file under apps/oxlint.

That leaked shared filesystem state across tests. In parallel runs, ancestor
config discovery for test_import_plugin_detects_cycles_with_auto_discovered_tsconfig_paths
could briefly observe the temporary crate-level .oxlintrc.json, then fail when
it had already been removed by another test. This showed up as a flaky
InvalidOptionConfig/snapshot failure instead of the expected import/no-cycle
diagnostic.

Fix this by writing --init output relative to the runner cwd, and update
test_init_config to use an isolated temporary directory rather than mutating
repo state.

fixes #20684

camc314 · 2026-03-24T21:53:54Z

fix(linter): isolate --init config writes from parallel tests #20717 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR fixes oxlint --init writing .oxlintrc.json into the process current directory (instead of the CliRunner working directory), which was leaking filesystem state across the oxlint test suite and causing flaky parallel test failures due to config auto-discovery.

Changes:

Write --init output to cwd/.oxlintrc.json (runner cwd) instead of the process CWD.
Update test_init_config to run in an isolated temporary directory rather than mutating repo state.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
apps/oxlint/src/mode/init.rs	Makes `run_init` write the generated config file relative to the runner’s `cwd`.
apps/oxlint/src/lint.rs	Updates `test_init_config` to validate init behavior using a temp directory, avoiding shared repo state and parallel-test interference.

camc314 · 2026-03-24T22:07:49Z

Merge activity

Mar 24, 10:07 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 24, 10:07 PM UTC: camc314 added this pull request to the Graphite merge queue.
Mar 24, 10:12 PM UTC: Merged by the Graphite merge queue.

`run_init` wrote `.oxlintrc.json` to the process current directory instead of the `CliRunner` cwd. In the oxlint test suite, `test_init_config` relied on that behavior and created/deleted a real config file under `apps/oxlint`. That leaked shared filesystem state across tests. In parallel runs, ancestor config discovery for `test_import_plugin_detects_cycles_with_auto_discovered_tsconfig_paths` could briefly observe the temporary crate-level `.oxlintrc.json`, then fail when it had already been removed by another test. This showed up as a flaky `InvalidOptionConfig`/snapshot failure instead of the expected `import/no-cycle` diagnostic. Fix this by writing `--init` output relative to the runner cwd, and update `test_init_config` to use an isolated temporary directory rather than mutating repo state. fixes #20684

# Oxlint ### 💥 BREAKING CHANGES - c0ebbce linter: [**BREAKING**] Report error on unknown builtin rule (#20464) (camc314) ### 🚀 Features - 04f85e5 linter/no-unused-vars: Add safe-fix option for import fixes (#20839) (Marcell Toth) - 32a3706 linter/eslint-vitest-plugin: Implements `require-test-timeout` rule (#20806) (Said Atrahouch) - ae03653 linter: Implement suggestion for `eslint/no-useless-computed-key` rule (#20805) (Mikhail Baev) - 6624513 linter/prefer-string-starts-ends-with: Move rule from nursery to style (#20797) (camc314) - 58941f8 linter/prefer-readonly: Move rule from nursery to style (#20796) (camc314) - 8837ffd linter/prefer-regexp-exec: Move rule from nursery to style (#20795) (camc314) - 7e88871 linter/prefer-find: Move rule out of nursery (#20794) (camc314) - ca6e5bc linter/vitest: Implement prefer-called-exactly-once-with (#17562) (Said Atrahouch) - e80c0bf linter/eslint-plugin-vitest: Implement `require-mock-type-parameters` (#20785) (Said Atrahouch) - cec8b8f linter/vitest: Implement require-awaited-expect-poll rule (#20702) (Said Atrahouch) - d8e9d01 linter/eslint-plugin-vitest: Set `prefer-to-have-been-called-times` compatible with jest (#20703) (Said Atrahouch) - caf8231 linter: Enhance import plugin diagnostics with help messages (#20766) (离谱) - f44adfa linter: Improve the oxlint config generated by `--init`. (#20632) (connorshea) - 43f4827 linter: Add help text to jest and promise diagnostics (#20640) (kszongic) - 16516de linter: Enhance types for `DummyRule` (#20751) (camc314) - 27374e8 linter: Add hint about node version when ts config fail to import (#20570) (camc314) - 8e34150 linter/eslint-plugin-vitest: Sync rule with JS implementation (#20679) (Said Atrahouch) ### 🐛 Bug Fixes - df057d5 linter/no-noninteractive-tabindex: Add missing composite widget … (#20860) (bab) - bb34073 linter: Mark vitest/valid-title as a compatible jest rules (#20463) (Nicolas Le Cam) - bd2c76b linter: Handle shadowed locals in no-restricted-globals (#20811) (Ulrich Stark) - 62e39be linter: Sort nested object keys in fix of `eslint/sort-keys` in one pass (#20838) (Ulrich Stark) - 3ef37da oxlint/lsp: Error on unknown command (#20841) (Sysix) - ab1070d oxlint/cli: Skip parsing base config again for nested config search (#20809) (Sysix) - 2be3728 oxlint/lsp: Skip parsing base config again for nested config search (#20808) (Sysix) - 6171217 oxlint: Respect `NO_COLOR` env for `format=stylish` (#20804) (Sysix) - d89ae8f linter/plugins: Patch `WeakMap` to emulate `WeakMap`s keyed by `sourceCode` (#20799) (overlookmotel) - c610666 linter/no-shadow: Respect env settings when builtinGlobals is enabled (#20429) (vvnikita74) - 6bb502f linter/no-invalid-void-type: Allow void generic args in heritage clauses (#20780) (camc314) - 365bb7d linter: Skip typed nested literals in explicit-module-boundary-types (#20776) (camc314) - 0aa1ff0 linter/plugins: Ensure `after` hook is always called in ESLint compat mode (#20721) (overlookmotel) - 31145a9 linter/plugins: Fire `after` hook after CFG events in ESLint compat (#20720) (overlookmotel) - c09a5ab diagnostics: Skip minified fallback for single-line reporters (#20716) (camc314) - e4dc9a1 linter: Isolate `--init` config writes from parallel tests (#20717) (camc314) - 7e394ec linter: Clarify empty replacement fixer help text (#20698) (camc314) - d15a99c linter/jsx-curly-brace-presence: Flag empty string literals (#20690) (camc314) ### 📚 Documentation - c722495 linter: Update JS Plugins + LS references (#20843) (camc314) - e1f9748 linter/jsdoc/require-property: Fix typo (#20792) (Benjaming61001) - be3dcc1 linter: Add note about node version + custom TS plugin (#19381) (camc314) # Oxfmt ### 🚀 Features - 6ef440a oxfmt: Support bool for object style options (#20853) (leaysgur) - 23050fa oxfmt: Support markdown-in-js substitution (#20683) (leaysgur) - 4087295 oxfmt: Support angular-in-js substitution (#20676) (leaysgur)

camc314 marked this pull request as ready for review March 24, 2026 21:53

Copilot AI review requested due to automatic review settings March 24, 2026 21:53

github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Mar 24, 2026

camc314 self-assigned this Mar 24, 2026

github-actions bot added the C-bug Category - Bug label Mar 24, 2026

camc314 changed the title ~~fix(oxlint): isolate --init config writes from parallel tests~~ fix(linter): isolate --init config writes from parallel tests Mar 24, 2026

Copilot started reviewing on behalf of camc314 March 24, 2026 21:54 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 24, 2026

graphite-app bot force-pushed the c/03-24-fix_oxlint_isolate_--init_config_writes_from_parallel_tests branch from 8887601 to e4dc9a1 Compare March 24, 2026 22:08

graphite-app bot merged commit e4dc9a1 into main Mar 24, 2026
24 checks passed

graphite-app bot deleted the c/03-24-fix_oxlint_isolate_--init_config_writes_from_parallel_tests branch March 24, 2026 22:12

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 24, 2026

camc314 mentioned this pull request Mar 24, 2026

ci(linter): flakey linter test case #20684

Closed

Boshen mentioned this pull request Mar 30, 2026

release(apps): oxlint v1.58.0 && oxfmt v0.43.0 #20867

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(linter): isolate `--init` config writes from parallel tests#20717

fix(linter): isolate `--init` config writes from parallel tests#20717
graphite-app[bot] merged 1 commit intomainfrom
c/03-24-fix_oxlint_isolate_--init_config_writes_from_parallel_tests

camc314 commented Mar 24, 2026 •

edited

Loading

Uh oh!

camc314 commented Mar 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

camc314 commented Mar 24, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

camc314 commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Mar 24, 2026

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

camc314 commented Mar 24, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camc314 commented Mar 24, 2026 •

edited

Loading

camc314 commented Mar 24, 2026 •

edited by graphite-app bot

Loading