OCPBUGS-11146: Mark cluster un-upgradeable when CSI migration is disabled by dobsonj · Pull Request #145 · openshift/vmware-vsphere-csi-driver-operator

dobsonj · 2023-03-22T00:40:13Z

https://issues.redhat.com/browse/STOR-1269
/cc @openshift/storage

This PR depends on openshift/cluster-storage-operator#351 for the RBAC change

openshift-ci-robot · 2023-03-22T00:40:16Z

@dobsonj: This pull request references STOR-1269 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1269
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dobsonj · 2023-03-22T16:48:14Z

W0322 02:07:04.450168 1 reflector.go:424] k8s.io/client-go@v0.26.1/tools/cache/reflector.go:169: failed to list *v1.FeatureGate: featuregates.config.openshift.io is forbidden: User "system:serviceaccount:openshift-cluster-csi-drivers:vmware-vsphere-csi-driver-operator" cannot list resource "featuregates" in API group "config.openshift.io" at the cluster scope
I pushed an RBAC change to openshift/cluster-storage-operator#351 to allow the operator to read featuregates.

dobsonj · 2023-03-28T00:11:30Z

We're not adding a new FeatureSet after all, and we're not blocking upgrades.
/close

openshift-ci · 2023-03-28T00:11:42Z

@dobsonj: Closed this PR.

Details

In response to this:

We're not adding a new FeatureSet after all, and we're not blocking upgrades.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dobsonj · 2023-03-29T16:46:19Z

Turns out we do need to block upgrades based on the API discussion. I'm going to re-use this PR, although it needs significant updates for the revised API.
/reopen

openshift-ci-robot · 2023-03-29T16:48:29Z

@dobsonj: This pull request references STOR-1269 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1269
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-29T16:48:33Z

@dobsonj: Reopened this PR.

Details

In response to this:

Turns out we do need to block upgrades based on the API discussion. I'm going to re-use this PR, although it needs significant updates for the revised API.
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-30T00:18:13Z

@dobsonj: This pull request references STOR-1269 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1269
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-30T00:18:13Z

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: STOR-1269: Mark cluster un-upgradeable when CSI migration is disabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-30T00:18:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dobsonj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-03-30T00:21:55Z

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: STOR-1269: Mark cluster un-upgradeable when CSI migration is disabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-30T00:21:55Z

@dobsonj: This pull request references STOR-1269 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1269
/cc @openshift/storage

TODO:

bump api after OCPBUGS-11146: Add CSI migration option to Storage operator spec api#1433 merges

fix unit tests under pkg/operator/vspherecontroller and add a new test case

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-30T00:22:12Z

@dobsonj: This pull request references STOR-1269 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1269
/cc @openshift/storage

TODO:

bump api after this merges: OCPBUGS-11146: Add CSI migration option to Storage operator spec api#1433

fix unit tests under pkg/operator/vspherecontroller and add a new test case

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-30T00:22:13Z

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: STOR-1269: Mark cluster un-upgradeable when CSI migration is disabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/operator/vspherecontroller/checks/check_migration_disabled.go

pkg/operator/vspherecontroller/vspherecontroller.go

openshift-ci-robot · 2023-03-30T15:30:11Z

@dobsonj: This pull request references STOR-1269 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1269
/cc @openshift/storage

TODO:

fix unit tests under pkg/operator/vspherecontroller and add a new test case

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dobsonj · 2023-04-05T23:12:02Z

/label backport-risk-assessed

ropatil010 · 2023-04-14T14:32:14Z

/label cherry-pick-approved

ropatil010 · 2023-04-18T14:58:38Z

/label qe-approved
/retest

dobsonj · 2023-04-18T16:29:27Z

These should pass now that openshift/cluster-storage-operator#351 merged with the RBAC change.
/test e2e-vsphere-csi
/test e2e-vsphere
And it should merge after the e2e tests pass.
/unhold

dobsonj · 2023-04-18T19:14:12Z

/retest

openshift-ci-robot · 2023-04-18T21:53:34Z

/retest-required

Remaining retests: 0 against base HEAD 9eb1e6c and 2 for PR HEAD 1368ba7 in total

dobsonj · 2023-04-19T00:25:24Z

/test e2e-vsphere-csi
/test e2e-vsphere

dobsonj · 2023-04-19T02:09:32Z

/retest

dobsonj · 2023-04-19T06:31:35Z

/retest

dobsonj · 2023-04-19T12:10:43Z

/retest

dobsonj · 2023-04-19T17:08:32Z

/retest

openshift-ci · 2023-04-19T18:28:28Z

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-04-19T18:37:35Z

@dobsonj: Jira Issue OCPBUGS-11146: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/vsphere-problem-detector#108 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-11146 has not been moved to the MODIFIED state.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1269
/cc @openshift/storage

This PR depends on openshift/cluster-storage-operator#351 for the RBAC change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-04-28T05:20:28Z

Fix included in accepted release 4.13.0-0.nightly-2023-04-27-232707

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 22, 2023

openshift-ci bot requested a review from a team March 22, 2023 00:40

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 22, 2023

dobsonj force-pushed the STOR-1269 branch from 3109d0d to 5811cc5 Compare March 22, 2023 00:53

dobsonj mentioned this pull request Mar 22, 2023

STOR-1266: Add CSI migration option to Storage operator spec openshift/api#1423

Merged

openshift-ci bot closed this Mar 28, 2023

openshift-ci bot reopened this Mar 29, 2023

dobsonj changed the base branch from master to release-4.13 March 30, 2023 00:18

dobsonj force-pushed the STOR-1269 branch from 5811cc5 to 0adfcf5 Compare March 30, 2023 00:18

jsafrane reviewed Mar 30, 2023

View reviewed changes

pkg/operator/vspherecontroller/checks/check_migration_disabled.go Outdated Show resolved Hide resolved

jsafrane mentioned this pull request Mar 30, 2023

OCPBUGS-11294: Add CSI migration metric #146

Merged

jsafrane reviewed Mar 30, 2023

View reviewed changes

pkg/operator/vspherecontroller/vspherecontroller.go Show resolved Hide resolved

STOR-1267: Bump openshift/api

01ac8b1

dobsonj force-pushed the STOR-1269 branch from 0adfcf5 to 945be8c Compare March 30, 2023 15:28

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 5, 2023

openshift-ci bot assigned chao007, duanwei33, Phaow, radeore and ropatil010 Apr 5, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 14, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 18, 2023

openshift-ci-robot mentioned this pull request Apr 18, 2023

OCPBUGS-11146: cluster-storage-operator must re-create in-tree StorageClass openshift/cluster-storage-operator#351

Merged

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2023

openshift-ci-robot mentioned this pull request Apr 18, 2023

OCPBUGS-11146: KCMO and MCO must set env var for CSI migration openshift/cluster-kube-controller-manager-operator#718

Merged

openshift-ci-robot mentioned this pull request Apr 18, 2023

OCPBUGS-11146: update cloud provider flags on vSphere for storage options openshift/machine-config-operator#3655

Merged

openshift-ci-robot mentioned this pull request Apr 19, 2023

OCPBUGS-11146: Enable CSI migration configuration via env vars openshift/kubernetes#1514

Merged

openshift-merge-robot merged commit 0881334 into openshift:release-4.13 Apr 19, 2023

openshift-ci-robot mentioned this pull request Apr 19, 2023

OCPBUGS-11146: Check migration status openshift/vsphere-problem-detector#108

Merged

dobsonj mentioned this pull request May 23, 2023

OCPBUGS-13914: allow removal of vsphereStorageDriver field in 4.14 openshift/api#1464

Merged

Conversation

dobsonj commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 22, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dobsonj commented Mar 22, 2023

Uh oh!

dobsonj commented Mar 28, 2023

Uh oh!

openshift-ci bot commented Mar 28, 2023

Uh oh!

dobsonj commented Mar 29, 2023

Uh oh!

openshift-ci-robot commented Mar 29, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Mar 29, 2023

Uh oh!

openshift-ci-robot commented Mar 30, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Mar 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Mar 30, 2023

Uh oh!

openshift-ci bot commented Mar 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 30, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 30, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Mar 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 30, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dobsonj commented Apr 5, 2023

Uh oh!

ropatil010 commented Apr 14, 2023

Uh oh!

ropatil010 commented Apr 18, 2023

Uh oh!

dobsonj commented Apr 18, 2023

Uh oh!

dobsonj commented Apr 18, 2023

Uh oh!

openshift-ci-robot commented Apr 18, 2023

Uh oh!

dobsonj commented Apr 19, 2023

Uh oh!

dobsonj commented Apr 19, 2023

Uh oh!

dobsonj commented Apr 19, 2023

Uh oh!

dobsonj commented Apr 19, 2023

Uh oh!

dobsonj commented Apr 19, 2023

Uh oh!

openshift-ci bot commented Apr 19, 2023

Uh oh!

openshift-ci-robot commented Apr 19, 2023

Uh oh!

openshift-merge-robot commented Apr 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

dobsonj commented Mar 22, 2023 •

edited

Loading

openshift-ci-robot commented Mar 22, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 29, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 30, 2023 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Mar 30, 2023 •

edited

Loading

openshift-ci bot commented Mar 30, 2023 •

edited

Loading

openshift-ci-robot commented Mar 30, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 30, 2023 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Mar 30, 2023 •

edited

Loading

openshift-ci-robot commented Mar 30, 2023 •

edited by openshift-ci bot

Loading