STOR-1266: Add CSI migration option to Storage operator spec

[dobsonj]

https://issues.redhat.com/browse/STOR-1266
/cc @openshift/storage

Dependent PR's:

• OCPBUGS-11146: Enable CSI migration configuration via env vars kubernetes#1514
• WIP: STOR-1267: Bump openshift/api cluster-kube-apiserver-operator#1466
• WIP: STOR-1267: Bump openshift/api cluster-kube-controller-manager-operator#710
• WIP: STOR-1267: Bump openshift/api cluster-kube-scheduler-operator#469
• WIP: STOR-1267: Bump openshift/api machine-config-operator#3614
• OCPBUGS-11146: cluster-storage-operator must re-create in-tree StorageClass cluster-storage-operator#351
• OCPBUGS-11146: Mark cluster un-upgradeable when CSI migration is disabled vmware-vsphere-csi-driver-operator#145

[openshift-ci-robot]

@dobsonj: This pull request references STOR-1266 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1266
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1266
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Hello @dobsonj! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[elmiko]

i've created a library-go change to help with the CCM reversion process, it will need this to work properly.

openshift/library-go#1490

[openshift-ci-robot]

@dobsonj: This pull request references STOR-1266 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1266
/cc @openshift/storage

Dependent PR's:

• OCPBUGS-11146: Enable CSI migration configuration via env vars kubernetes#1514
• WIP: STOR-1267: Bump openshift/api cluster-kube-apiserver-operator#1466
• WIP: STOR-1267: Bump openshift/api cluster-kube-controller-manager-operator#710
• WIP: STOR-1267: Bump openshift/api cluster-kube-scheduler-operator#469
• WIP: STOR-1267: Bump openshift/api machine-config-operator#3614
• OCPBUGS-11146: cluster-storage-operator must re-create in-tree StorageClass cluster-storage-operator#351
• OCPBUGS-11146: Mark cluster un-upgradeable when CSI migration is disabled vmware-vsphere-csi-driver-operator#145
• add ability to detect vsphere csi migration library-go#1490

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dobsonj]

Updated to implement the latest proposal
/hold for testing

[openshift-ci-robot]

@dobsonj: This pull request references STOR-1266 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1266
/cc @openshift/storage

Dependent PR's:

• OCPBUGS-11146: Enable CSI migration configuration via env vars kubernetes#1514
• WIP: STOR-1267: Bump openshift/api cluster-kube-apiserver-operator#1466
• WIP: STOR-1267: Bump openshift/api cluster-kube-controller-manager-operator#710
• WIP: STOR-1267: Bump openshift/api cluster-kube-scheduler-operator#469
• WIP: STOR-1267: Bump openshift/api machine-config-operator#3614
• OCPBUGS-11146: cluster-storage-operator must re-create in-tree StorageClass cluster-storage-operator#351

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@dobsonj: This pull request references STOR-1266 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1266
/cc @openshift/storage

Dependent PR's:

• OCPBUGS-11146: Enable CSI migration configuration via env vars kubernetes#1514
• WIP: STOR-1267: Bump openshift/api cluster-kube-apiserver-operator#1466
• WIP: STOR-1267: Bump openshift/api cluster-kube-controller-manager-operator#710
• WIP: STOR-1267: Bump openshift/api cluster-kube-scheduler-operator#469
• WIP: STOR-1267: Bump openshift/api machine-config-operator#3614
• OCPBUGS-11146: cluster-storage-operator must re-create in-tree StorageClass cluster-storage-operator#351
• OCPBUGS-11146: Mark cluster un-upgradeable when CSI migration is disabled vmware-vsphere-csi-driver-operator#145

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[deads2k]

test for

- name: Should not allow disabling the vSphere migration for vSphere
  initial: |
    apiVersion: operator.openshift.io/v1
    kind: Storage
    spec:
      csiMigrationVSphere: Enabled
   updated: |
     apiVersion: operator.openshift.io/v1
     kind: Storage
     spec:
       csiMigrationVSphere:""
   expectedError: "csiMigrationVSphere may not be unset once Enabled"

appears missing. there is a test for missing, but not for empty (near as I see)

[dobsonj]

there is a test for missing, but not for empty (near as I see)

Added in latest push here:
https://github.com/dobsonj/api/blob/426d59473937ba3aaec1e6ef768051090d1c78ac/operator/v1/stable.storage.testsuite.yaml#L82-L93

[openshift-ci]

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[deads2k]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dobsonj]

/unhold