OCPBUGS-11146: KCMO and MCO must set env var for CSI migration by dobsonj · Pull Request #718 · openshift/cluster-kube-controller-manager-operator

dobsonj · 2023-03-31T22:48:40Z

https://issues.redhat.com/browse/STOR-1287
/cc @openshift/storage

STOR-1267: Bump openshift/api
STOR-1287: KCMO and MCO must set env var for CSI migration

openshift-ci-robot · 2023-03-31T22:48:42Z

@dobsonj: This pull request references STOR-1287 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1287
/cc @openshift/storage

STOR-1267: Bump openshift/api

DO NOT MERGE: testing library-go bump

STOR-1287: KCMO and MCO must set env var for CSI migration

WIP until openshift/library-go#1495 merges

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-31T22:48:45Z

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: STOR-1287: KCMO and MCO must set env var for CSI migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-31T22:48:55Z

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1287
/cc @openshift/storage

STOR-1267: Bump openshift/api

DO NOT MERGE: testing library-go bump

STOR-1287: KCMO and MCO must set env var for CSI migration

WIP until openshift/library-go#1495 merges

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-31T22:48:55Z

@dobsonj: This pull request references STOR-1287 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1287
/cc @openshift/storage

STOR-1267: Bump openshift/api

DO NOT MERGE: testing library-go bump

STOR-1287: KCMO and MCO must set env var for CSI migration

WIP until openshift/library-go#1495 merges

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-31T22:49:07Z

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: STOR-1287: KCMO and MCO must set env var for CSI migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jsafrane · 2023-04-03T14:12:13Z

looks good to me, but what do I know about KCM-operator

dobsonj · 2023-04-03T16:26:52Z

looks good to me, but what do I know about KCM-operator

Works on my cluster ¯\_(ツ)_/¯

openshift-ci-robot · 2023-04-05T23:08:32Z

@dobsonj: This pull request references STOR-1287 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1287
/cc @openshift/storage

STOR-1267: Bump openshift/api

STOR-1287: KCMO and MCO must set env var for CSI migration

WIP until openshift/library-go#1495 merges

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-05T23:08:33Z

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: STOR-1287: KCMO and MCO must set env var for CSI migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-04-05T23:08:49Z

@dobsonj: This pull request references STOR-1287 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1287
/cc @openshift/storage

STOR-1267: Bump openshift/api

STOR-1287: KCMO and MCO must set env var for CSI migration

Depends on openshift/library-go#1495

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-05T23:08:50Z

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: STOR-1287: KCMO and MCO must set env var for CSI migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-05T23:09:35Z

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

STOR-1287: KCMO and MCO must set env var for CSI migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-05T23:10:25Z

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-11146: KCMO and MCO must set env var for CSI migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-04-05T23:10:27Z

@dobsonj: This pull request references Jira Issue OCPBUGS-11146, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-11144 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-11144 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1287
/cc @openshift/storage

STOR-1267: Bump openshift/api

STOR-1287: KCMO and MCO must set env var for CSI migration

Depends on openshift/library-go#1495

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dobsonj · 2023-04-05T23:13:41Z

/hold for testing

dobsonj · 2023-04-05T23:19:43Z

/cc @jsafrane @deads2k
for review / approve

atiratree

/approve

pkg/operator/starter.go

pkg/operator/targetconfigcontroller/targetconfigcontroller.go

atiratree · 2023-04-06T21:27:52Z

/test e2e-aws-operator-preferred-host
/lgtm

@dobsonj feel free to unhold once you have completed your testing

openshift-ci · 2023-04-06T21:28:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [atiratree]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

atiratree · 2023-04-06T21:33:41Z

for backport-risk-assessed
/assign @ingvagabund @soltysh

openshift-ci · 2023-04-06T22:16:33Z

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ropatil010 · 2023-04-18T14:59:44Z

/label cherry-pick-approved
/label qe-approved

openshift-ci · 2023-04-18T15:08:36Z

@ropatil010: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label cherry-pick-approved
/label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knobunc · 2023-04-18T16:04:30Z

/label backport-risk-assessed
/label cherry-pick-approved

openshift-ci · 2023-04-18T16:04:55Z

@knobunc: Can not set label backport-risk-assessed: Must be member in one of these teams: []

Details

In response to this:

/label backport-risk-assessed
/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-18T16:05:00Z

@knobunc: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label backport-risk-assessed
/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dobsonj · 2023-04-18T17:13:12Z

/unhold

openshift-ci-robot · 2023-04-18T17:18:53Z

@dobsonj: Jira Issue OCPBUGS-11146: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/vmware-vsphere-csi-driver-operator#145 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-11146 has not been moved to the MODIFIED state.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1287
/cc @openshift/storage

STOR-1267: Bump openshift/api

STOR-1287: KCMO and MCO must set env var for CSI migration

Depends on openshift/library-go#1495

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-04-28T05:20:31Z

Fix included in accepted release 4.13.0-0.nightly-2023-04-27-232707

STOR-1267: Bump openshift/api

efbc7b8

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 31, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2023

STOR-1287: KCMO and MCO must set env var for CSI migration

34bb797

dobsonj force-pushed the STOR-1287 branch from 834b782 to 34bb797 Compare April 5, 2023 23:08

dobsonj changed the title ~~WIP: STOR-1287: KCMO and MCO must set env var for CSI migration~~ STOR-1287: KCMO and MCO must set env var for CSI migration Apr 5, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2023

dobsonj changed the title ~~STOR-1287: KCMO and MCO must set env var for CSI migration~~ OCPBUGS-11146: KCMO and MCO must set env var for CSI migration Apr 5, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 5, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2023

openshift-ci bot requested review from deads2k and jsafrane April 5, 2023 23:19

atiratree reviewed Apr 6, 2023

View reviewed changes

pkg/operator/starter.go Outdated Show resolved Hide resolved

pkg/operator/starter.go Outdated Show resolved Hide resolved

pkg/operator/starter.go Show resolved Hide resolved

pkg/operator/targetconfigcontroller/targetconfigcontroller.go Outdated Show resolved Hide resolved

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023

STOR-1287: make imports more consistent, add env only to KCM

5756419

openshift-ci bot assigned atiratree Apr 6, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023

openshift-ci bot assigned ingvagabund and soltysh Apr 6, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 18, 2023

knobunc added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Apr 18, 2023

openshift-ci bot assigned kasturinarra, xingxingxia and zhouying7780 Apr 18, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2023

openshift-merge-robot merged commit 9f53628 into openshift:release-4.13 Apr 18, 2023

This was referenced Apr 19, 2023

OCPBUGS-11146: Mark cluster un-upgradeable when CSI migration is disabled openshift/vmware-vsphere-csi-driver-operator#145

Merged

OCPBUGS-11146: Check migration status openshift/vsphere-problem-detector#108

Merged

dobsonj mentioned this pull request May 23, 2023

OCPBUGS-13914: allow removal of vsphereStorageDriver field in 4.14 openshift/api#1464

Merged

Conversation

dobsonj commented Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 31, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 31, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsafrane commented Apr 3, 2023

Uh oh!

dobsonj commented Apr 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 5, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 5, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 5, 2023

Uh oh!

openshift-ci-robot commented Apr 5, 2023

Uh oh!

dobsonj commented Apr 5, 2023

Uh oh!

dobsonj commented Apr 5, 2023

Uh oh!

atiratree left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

atiratree commented Apr 6, 2023

Uh oh!

openshift-ci bot commented Apr 6, 2023

Uh oh!

atiratree commented Apr 6, 2023

Uh oh!

openshift-ci bot commented Apr 6, 2023

Uh oh!

ropatil010 commented Apr 18, 2023

Uh oh!

openshift-ci bot commented Apr 18, 2023

Uh oh!

knobunc commented Apr 18, 2023

Uh oh!

openshift-ci bot commented Apr 18, 2023

Uh oh!

openshift-ci bot commented Apr 18, 2023

Uh oh!

dobsonj commented Apr 18, 2023

Uh oh!

openshift-ci-robot commented Apr 18, 2023

Uh oh!

openshift-merge-robot commented Apr 28, 2023

Uh oh!

Reviewers

Assignees

dobsonj commented Mar 31, 2023 •

edited

Loading

openshift-ci-robot commented Mar 31, 2023 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Mar 31, 2023 •

edited

Loading

openshift-ci bot commented Mar 31, 2023 •

edited

Loading

openshift-ci-robot commented Mar 31, 2023 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Mar 31, 2023 •

edited

Loading

dobsonj commented Apr 3, 2023 •

edited

Loading

openshift-ci-robot commented Apr 5, 2023 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Apr 5, 2023 •

edited

Loading

openshift-ci-robot commented Apr 5, 2023 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Apr 5, 2023 •

edited

Loading

openshift-ci bot commented Apr 5, 2023 •

edited

Loading