Skip to content

OCPBUGS-11146: cluster-storage-operator must re-create in-tree StorageClass#351

Merged
openshift-merge-robot merged 7 commits intoopenshift:release-4.13from
dobsonj:STOR-1272
Apr 18, 2023
Merged

OCPBUGS-11146: cluster-storage-operator must re-create in-tree StorageClass#351
openshift-merge-robot merged 7 commits intoopenshift:release-4.13from
dobsonj:STOR-1272

Conversation

@dobsonj
Copy link
Member

@dobsonj dobsonj commented Mar 15, 2023 •
edited
Loading

https://issues.redhat.com/browse/STOR-1272
https://issues.redhat.com/browse/STOR-1283
/cc @openshift/storage

This PR depends on openshift/origin#27831 so we don't break the DisableStorageClass test

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 15, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 15, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: This pull request references STOR-1272 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1272
/cc @openshift/storage

This is a work in progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2023

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1272
/cc @openshift/storage

This is a work in progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 20, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: This pull request references STOR-1272 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1272
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dobsonj
Copy link
Member Author

dobsonj commented Mar 21, 2023

/retest

This was referenced Mar 22, 2023
Merged
Merged
Merged
@dobsonj dobsonj force-pushed the STOR-1272 branch 4 times, most recently from 32fd74c to b3c7c28 Compare March 28, 2023 21:46
@dobsonj dobsonj changed the base branch from master to release-4.13 March 29, 2023 22:21
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 29, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: This pull request references STOR-1272 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1272
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2023 •
edited
Loading

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: STOR-1272: cluster-storage-operator must re-create in-tree StorageClass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 29, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: This pull request references STOR-1272 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1272
https://issues.redhat.com/browse/STOR-1283
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2023 •
edited
Loading

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: STOR-1272: cluster-storage-operator must re-create in-tree StorageClass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane
Copy link
Contributor

jsafrane commented Mar 30, 2023

lgtm-ish, pending final API upgrade.

@dobsonj dobsonj changed the title WIP: STOR-1272: cluster-storage-operator must re-create in-tree StorageClass STOR-1272: cluster-storage-operator must re-create in-tree StorageClass Mar 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023 •
edited
Loading

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

STOR-1272: cluster-storage-operator must re-create in-tree StorageClass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@duanwei33
Copy link

duanwei33 commented Apr 6, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 6, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@jsafrane
Copy link
Contributor

jsafrane commented Apr 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@dobsonj
Copy link
Member Author

dobsonj commented Apr 13, 2023

Need to bump API one more time to get openshift/api#1441
It's just a one-line change to the doc text in the API, could be bumped in a separate PR if really needed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2023
@dobsonj
Copy link
Member Author

dobsonj commented Apr 14, 2023

Need to bump API one more time to get openshift/api#1441 It's just a one-line change to the doc text in the API, could be bumped in a separate PR if really needed.

Pushed in a new commit

@gnufied
Copy link
Member

gnufied commented Apr 14, 2023

/lgtm

@dobsonj
Copy link
Member Author

dobsonj commented Apr 14, 2023

Pulled in 1-line RBAC change from #359 to help with @gnufied 's changes in openshift/vsphere-problem-detector#107

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2023

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovn-vsphere 32fd74c link false /test e2e-ovn-vsphere
ci/prow/e2e-azure-csi 781b2c7 link false /test e2e-azure-csi
ci/prow/e2e-hypershift-ovn-conformance 781b2c7 link false /test e2e-hypershift-ovn-conformance
ci/prow/e2e-vsphere-ovn 781b2c7 link false /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ropatil010
Copy link

ropatil010 commented Apr 18, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 18, 2023
@dobsonj
Copy link
Member Author

dobsonj commented Apr 18, 2023

I think this is ready to go now, and the other PR's depend on this merging first.
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0e7835e into openshift:release-4.13 Apr 18, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2023

@dobsonj: Jira Issue OCPBUGS-11146: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-11146 has not been moved to the MODIFIED state.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1272
https://issues.redhat.com/browse/STOR-1283
/cc @openshift/storage

This PR depends on openshift/origin#27831 so we don't break the DisableStorageClass test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 19, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Apr 28, 2023

Fix included in accepted release 4.13.0-0.nightly-2023-04-27-232707

@dobsonj dobsonj mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane jsafrane left review comments

Assignees

@gnufied gnufied

@jsafrane jsafrane

@chao007 chao007

@duanwei33 duanwei33

@ropatil010 ropatil010

@Phaow Phaow

@radeore radeore

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@dobsonj @openshift-ci-robot @jsafrane @duanwei33 @gnufied @ropatil010 @openshift-merge-robot @chao007 @Phaow @radeore