Skip to content

OCPBUGS-11146: Enable CSI migration configuration via env vars#1514

Merged
openshift-merge-robot merged 4 commits intoopenshift:release-4.13from
dobsonj:STOR-1270
Apr 19, 2023
Merged

OCPBUGS-11146: Enable CSI migration configuration via env vars#1514
openshift-merge-robot merged 4 commits intoopenshift:release-4.13from
dobsonj:STOR-1270

Conversation

@dobsonj
Copy link
Member

@dobsonj dobsonj commented Mar 15, 2023 •
edited by openshift-ci bot
Loading

https://issues.redhat.com/browse/STOR-1270
https://issues.redhat.com/browse/STOR-1271

  • UPSTREAM: 116342: Unlock CSIMigrationvSphere feature gate until there is a supported vSphere CSI driver available
  • UPSTREAM: : STOR-1270: Restore carry patch that enables CSI migration in any order
  • UPSTREAM: : STOR-1270: Enable CSI migration configuration via env vars
  • UPSTREAM: : STOR-1270: Admission plugin to deny deletion of storages.operator.openshift.io

/cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 15, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 15, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: This pull request references STOR-1270 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1270
https://issues.redhat.com/browse/STOR-1271

  • UPSTREAM: 116342: Unlock CSIMigrationvSphere feature gate until there is a supported vSphere CSI driver available
  • UPSTREAM: : STOR-1270: Restore carry patch that enables CSI migration in any order

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2023 •
edited
Loading

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1270
https://issues.redhat.com/browse/STOR-1271

  • UPSTREAM: 116342: Unlock CSIMigrationvSphere feature gate until there is a supported vSphere CSI driver available
  • UPSTREAM: : STOR-1270: Restore carry patch that enables CSI migration in any order

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 15, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: This pull request references STOR-1270 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1270
https://issues.redhat.com/browse/STOR-1271

  • UPSTREAM: 116342: Unlock CSIMigrationvSphere feature gate until there is a supported vSphere CSI driver available
  • UPSTREAM: : STOR-1270: Restore carry patch that enables CSI migration in any order

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 15, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

  • [b52d2d8|UPSTREAM: : STOR-1270: Restore carry patch that enables CSI migration in any order](b52d2d8): does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Mar 17, 2023
@dobsonj dobsonj changed the title STOR-1270: Restore carry patch that enables CSI migration in any order WIP: STOR-1270: Restore carry patch that enables CSI migration in any order Mar 17, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2023
@dobsonj
Copy link
Member Author

dobsonj commented Mar 17, 2023

Marking as WIP because this PR depends on openshift/api#1423 merging first.
There is an admission plugin that checks valid FeatureSet values, and I had to bump the api and add the new FeatureSet to the "knownFeatureSets" list that the admission plugin checks. Without that change, setting the FeatureSet fails with:

# * spec.featureSet: Unsupported value: "InTreeVSphereVolumes": supported values: "", "CustomNoUpgrade", "LatencySensitive", "TechPreviewNoUpgrade"

@dobsonj dobsonj mentioned this pull request Mar 22, 2023
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

  • [952567a|UPSTREAM: : STOR-1270: Restore carry patch that enables CSI migration in any order](952567a): does not specify an upstream backport in the commit message
  • [e557ad7|UPSTREAM: : STOR-1270: add OPENSHIFT_DO_VSPHERE_MIGRATION env check](e557ad7): does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@jsafrane
Copy link

jsafrane commented Mar 28, 2023 •
edited by openshift-ci bot
Loading

/retitle WIP: STOR-1270: Enable CSI migration configuration via env. vars

@openshift-ci openshift-ci bot changed the title WIP: STOR-1270: Restore carry patch that enables CSI migration in any order WIP: STOR-1270: Enable CSI migration configuration via env. vars Mar 28, 2023
@deads2k
Copy link

deads2k commented Mar 28, 2023

I think we want this ONLY in 4.13.

deads2k
deads2k reviewed Mar 28, 2023
View reviewed changes
deads2k
deads2k reviewed Mar 28, 2023
View reviewed changes
@dobsonj dobsonj changed the base branch from master to release-4.13 March 28, 2023 17:16
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 28, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: This pull request references STOR-1270 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1270
https://issues.redhat.com/browse/STOR-1271

  • UPSTREAM: 116342: Unlock CSIMigrationvSphere feature gate until there is a supported vSphere CSI driver available
  • UPSTREAM: : STOR-1270: Restore carry patch that enables CSI migration in any order

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 28, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

  • [0c49efd|UPSTREAM: : STOR-1270: Restore carry patch that enables CSI migration in any order](0c49efd): does not specify an upstream backport in the commit message
  • [a3d004b|UPSTREAM: : STOR-1270: add OPENSHIFT_DO_VSPHERE_MIGRATION env check](a3d004b): does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci
Copy link

openshift-ci bot commented Mar 28, 2023 •
edited
Loading

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: STOR-1270: Enable CSI migration configuration via env. vars

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 28, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

  • [0c49efd|UPSTREAM: : STOR-1270: Restore carry patch that enables CSI migration in any order](0c49efd): does not specify an upstream backport in the commit message
  • [7810d2b|UPSTREAM: : STOR-1270: Enable CSI migration configuration via env vars](7810d2b): does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@knobunc knobunc added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Apr 18, 2023
@tkashem
Copy link

tkashem commented Apr 18, 2023

/remove-label backports/unvalidated-commits
/label backports/validated-commits
/approve

/cc @soltysh

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Apr 18, 2023
@tkashem
Copy link

tkashem commented Apr 18, 2023

(given the team had already tagged it before)
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, gnufied, jsafrane, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dobsonj
Copy link
Member Author

dobsonj commented Apr 18, 2023

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Apr 18, 2023 •
edited
Loading

@dobsonj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade e557ad728b0aecd3753bcfc59648f3179fc4e0ec link false /test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member Author

dobsonj commented Apr 18, 2023

/retest-required

@dobsonj
Copy link
Member Author

dobsonj commented Apr 19, 2023

This can merge now that the KCM-O and MCO changes have merged.
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2023
@openshift-merge-robot openshift-merge-robot merged commit b404935 into openshift:release-4.13 Apr 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 19, 2023

@dobsonj: Jira Issue OCPBUGS-11146: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-11146 has not been moved to the MODIFIED state.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1270
https://issues.redhat.com/browse/STOR-1271

  • UPSTREAM: 116342: Unlock CSIMigrationvSphere feature gate until there is a supported vSphere CSI driver available
  • UPSTREAM: : STOR-1270: Restore carry patch that enables CSI migration in any order
  • UPSTREAM: : STOR-1270: Enable CSI migration configuration via env vars
  • UPSTREAM: : STOR-1270: Admission plugin to deny deletion of storages.operator.openshift.io

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 19, 2023
Merged
Merged
sebsoto added a commit to sebsoto/windows-machine-config-operator that referenced this pull request Apr 21, 2023
@sebsoto
[nodeconfig] Disable vSphere CSI migration
dca4fb3 
Enables the use of in-tree storage for vSphere.
This feature flag was locked to true until recently upstream, and is
still in the process of making its way into openshift/kubernetes.
Because it is not yet downstreamed, this cannot be tested. When it is
downstreamed, fc6517f, can be
cherry-picked in order to test this change.

See openshift/kubernetes#1514 for more
context.
sebsoto added a commit to sebsoto/windows-machine-config-operator that referenced this pull request Apr 24, 2023
@sebsoto
[nodeconfig] Disable vSphere CSI migration
48c8b28 
Enables the use of in-tree storage for vSphere.
This feature flag was locked to true until recently upstream, and is
still in the process of making its way into openshift/kubernetes.
Because it is not yet downstreamed, this cannot be tested. When it is
downstreamed, fc6517f, can be
cherry-picked in order to test this change.

See openshift/kubernetes#1514 for more
context.
@openshift-merge-robot
Copy link

openshift-merge-robot commented Apr 28, 2023

Fix included in accepted release 4.13.0-0.nightly-2023-04-27-232707

@dobsonj dobsonj mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@jsafrane jsafrane Awaiting requested review from jsafrane

@soltysh soltysh Awaiting requested review from soltysh

1 more reviewer

@tkashem tkashem tkashem left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@gnufied gnufied

@jsafrane jsafrane

@kasturinarra kasturinarra

@tkashem tkashem

@zhouying7780 zhouying7780

@xingxingxia xingxingxia

@sunilcio sunilcio

@duanwei33 duanwei33

@wangke19 wangke19

@gangwgr gangwgr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.