Skip to content

OCPBUGS-11146: Add CSI migration option to Storage operator spec#1433

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
dobsonj:STOR-1266-4.13
Mar 30, 2023
Merged

OCPBUGS-11146: Add CSI migration option to Storage operator spec#1433
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
dobsonj:STOR-1266-4.13

Conversation

@dobsonj
Copy link
Member

@dobsonj dobsonj commented Mar 29, 2023

https://issues.redhat.com/browse/STOR-1266
/cc @openshift/storage @JoelSpeed @deads2k @jsafrane

This is a simple backport of #1423
git cherry-pick 426d59473937ba3aaec1e6ef768051090d1c78ac

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 29, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 29, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: This pull request references STOR-1266 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1266
/cc @openshift/storage @JoelSpeed @deads2k @jsafrane

This is a simple backport of #1423
git cherry-pick 426d59473937ba3aaec1e6ef768051090d1c78ac

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2023 •
edited
Loading

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

STOR-1266: Add CSI migration option to Storage operator spec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2023

Hello @dobsonj! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2023

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1266
/cc @openshift/storage @JoelSpeed @deads2k @jsafrane

This is a simple backport of #1423
git cherry-pick 426d59473937ba3aaec1e6ef768051090d1c78ac

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dobsonj dobsonj changed the title STOR-1266: Add CSI migration option to Storage operator spec [4.13] STOR-1266: Add CSI migration option to Storage operator spec Mar 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2023 •
edited
Loading

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[4.13] STOR-1266: Add CSI migration option to Storage operator spec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2023

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dobsonj dobsonj mentioned this pull request Mar 30, 2023
Merged
@jsafrane
Copy link
Contributor

jsafrane commented Mar 30, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2023
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Mar 30, 2023

/approve
/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

@JoelSpeed: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

Details

In response to this:

/approve
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, JoelSpeed, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2023
@knobunc knobunc added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 30, 2023
@knobunc
Copy link
Contributor

knobunc commented Mar 30, 2023

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

@knobunc: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dobsonj
Copy link
Member Author

dobsonj commented Mar 30, 2023

/retitle OCPBUGS-11146: Add CSI migration option to Storage operator spec
/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 30, 2023 •
edited by openshift-ci bot
Loading

@dobsonj: This pull request references STOR-1266 which is a valid jira issue.

Details

In response to this:

/retitle OCPBUGS-11146: Add CSI migration option to Storage operator spec
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [4.13] STOR-1266: Add CSI migration option to Storage operator spec OCPBUGS-11146: Add CSI migration option to Storage operator spec Mar 30, 2023
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 30, 2023

@dobsonj: This pull request references Jira Issue OCPBUGS-11146, which is invalid:

  • expected Jira Issue OCPBUGS-11146 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1266
/cc @openshift/storage @JoelSpeed @deads2k @jsafrane

This is a simple backport of #1423
git cherry-pick 426d59473937ba3aaec1e6ef768051090d1c78ac

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

@dobsonj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-11146: Add CSI migration option to Storage operator spec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dobsonj
Copy link
Member Author

dobsonj commented Mar 30, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 30, 2023

@dobsonj: This pull request references Jira Issue OCPBUGS-11146, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-11144 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-11144 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 30, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0563585 into openshift:release-4.13 Mar 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 30, 2023

@dobsonj: Jira Issue OCPBUGS-11146: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11146 has been moved to the MODIFIED state.

Details

In response to this:

https://issues.redhat.com/browse/STOR-1266
/cc @openshift/storage @JoelSpeed @deads2k @jsafrane

This is a simple backport of #1423
git cherry-pick 426d59473937ba3aaec1e6ef768051090d1c78ac

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 1, 2023
Merged
This was referenced Apr 18, 2023
Merged
Merged
Merged
Merged
Merged
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Apr 28, 2023

Fix included in accepted release 4.13.0-0.nightly-2023-04-27-232707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@deads2k deads2k Awaiting requested review from deads2k

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@jsafrane jsafrane

@xingxingxia xingxingxia

@wangke19 wangke19

@gangwgr gangwgr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@dobsonj @openshift-ci-robot @jsafrane @JoelSpeed @knobunc @openshift-merge-robot @xingxingxia @wangke19 @gangwgr