OCPBUGS-13914: allow removal of vsphereStorageDriver field in 4.14

[dobsonj]

https://issues.redhat.com/browse/OCPBUGS-13914
IMO we can allow the vsphereStorageDriver field to be removed from the Storage object now as long as we do not allow the value to be set to LegacyDeprecatedInTreeDriver.
/cc @openshift/storage @jsafrane @JoelSpeed

[openshift-ci]

Hello @dobsonj! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-13914, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ropatil010

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-13914
/cc @openshift/storage @jsafrane @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-13914
/cc @openshift/storage @jsafrane @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-13914, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ropatil010

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-13914
IMO we can allow the vsphereStorageDriver field to be removed from the Storage object now as long as we do not allow the value to be set to LegacyDeprecatedInTreeDriver.
/cc @openshift/storage @jsafrane @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

@dobsonj Can you please make sure to link the PR that proves the newly allowed change doesn't change behaviour in the cluster, ie the operator PR

[dobsonj]

@JoelSpeed All of these PR's went into 4.13 only, and intentionally bypassed 4.14:

• OCPBUGS-11146: Enable CSI migration configuration via env vars kubernetes#1514
• OCPBUGS-11146: cluster-storage-operator must re-create in-tree StorageClass cluster-storage-operator#351
• OCPBUGS-11146: Mark cluster un-upgradeable when CSI migration is disabled vmware-vsphere-csi-driver-operator#145
• OCPBUGS-11146: KCMO and MCO must set env var for CSI migration cluster-kube-controller-manager-operator#718
• OCPBUGS-11146: update cloud provider flags on vSphere for storage options machine-config-operator#3655

So taking the o/k PR for example, you can see the feature gate is locked and patch_kube_features.go does not exist in 4.14.

[JoelSpeed]

/lgtm

Discussed on slack, this starts the timer for removal of this field. It will have zero effect on the product from 4.14 onwards so should be removed in 4.18.

@dobsonj I think we should add a deprecation notice to the godoc here and make sure docs are notified to mark the field deprecated in release notes

/hold in case you want to do that in this PR

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dobsonj]

@dobsonj I think we should add a deprecation notice to the godoc here and make sure docs are notified to mark the field deprecated in release notes

Ack, thanks, the godoc already has a deprecation notice and I just added a release note to the bug so the docs team will pick it up in the 4.14 release notes.

/unhold

[openshift-ci]

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@dobsonj: Jira Issue OCPBUGS-13914: All pull requests linked via external trackers have merged:

• openshift/api#1464

Jira Issue OCPBUGS-13914 has been moved to the MODIFIED state.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-13914
IMO we can allow the vsphereStorageDriver field to be removed from the Storage object now as long as we do not allow the value to be set to LegacyDeprecatedInTreeDriver.
/cc @openshift/storage @jsafrane @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.