OCPBUGS-53249: feat: support platform type external #29623
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@mtulio: This pull request references Jira Issue OCPBUGS-53249, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
Skipping CI for Draft Pull Request. |
|
/test ? |
|
@mtulio: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-external-aws-ccm |
|
/lgtm |
|
/lgtm |
openshift-ci
bot
added
the
approved
|
Adding explicitly the hold label as we are waiting for the presubmit job updates[1] to test here. We wont expect the job to pass, but we should have at least the same result when not setting /hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
openshift/release#63367 merged. Testing again: /test e2e-external-aws-ccm |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 2eca6b8
New tests seen in this PR at sha: 2eca6b8
|
|
Fixed the pkg call to register the external provider, got success testing locally, re-testing: /test e2e-external-aws-ccm |
|
Okay, e2e-external presubmit job ran and we are where we wanted:
This PR is ready for review. /unhold [1] job result before provider flag: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29623/pull-ci-openshift-origin-main-e2e-external-aws-ccm/1904250996830244864 |
openshift-ci
bot
removed
do-not-merge/work-in-progress
|
/hold Holding for now till tests are done just to make sure we are happy. |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtulio, stbenjam, vr4manta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test images |
|
Looking the failures, there are massive image build issues across many jobs. I will wait for stable Ci to triggering tests |
|
I am seeing AWS advanced from previous failed steps, calling more common jobs to get readiness: |
|
re-calling required failed in the image issues: |
|
failures>
the last two are touching where we are changing, and the required job for platform external is passing to the point we wanted (blocked by two test failures we are trying to skip in openshift/kubernetes#2247 ). Even with a lot of CI flakes, I get confidence with finished jobs. I am unblock to keep working on openshift/kubernetes#2247. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 7aacc91
New tests seen in this PR at sha: 7aacc91
|
|
@mtulio: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit ea71886
into
openshift:main
|
@mtulio: Jira Issue OCPBUGS-53249: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-53249 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
|
We'll need to backport this to OCP 4.18 as the failed test was introduced in kube 1.31. /cherry-pick release-4.18 |
|
@mtulio: new pull request created: #29666 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
This change register the platform type
externalas a validprovider(flag) when running the conformance tests.This is required if we need more refinement when running conformance tests in that platform type (
External), which was design inheriting fromNone. EP for more information: https://github.com/openshift/enhancements/blob/master/enhancements/cloud-integration/infrastructure-external-platform-type.mdFor more information about the tests executed in this PR, see this comment: #29623 (comment)
[1] OCPBUGS-53249 - The following PR implements granular skips for platform specific on tests coming from kubernetes suites: openshift/kubernetes#2247