-
Notifications
You must be signed in to change notification settings - Fork 2.1k
SPLAT-2191: pext/aws: enforce provider on platform type External clusters #64359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPLAT-2191: pext/aws: enforce provider on platform type External clusters #64359
Conversation
Now provider external is supported in 4.18+, we'll need to prepare to make the flag as default for all platform type External clusters. https://issues.redhat.com/browse/SPLAT-2191 This change depends on support of provider external to <4.18 in the test framework: https://issues.redhat.com/browse/SPLAT-2190
|
@mtulio: This pull request references SPLAT-2191 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
[REHEARSALNOTIFIER]
A total of 12654 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm periodic-ci-openshift-release-master-nightly-4.20-e2e-external-vsphere-ccm periodic-ci-openshift-release-master-nightly-4.19-e2e-external-aws |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/test all |
|
Flag Running auto-ack. |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
/pj-rehearse periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mtulio: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
…m fixes Add skip to prevent permanent job failures caused by permanent test failures fixed in o/k repo. The final solution are coordinated with several changes in the test framework, which depends on: - https://issues.redhat.com/browse/SPLAT-2190: introduce external provider to the test framework 4.17- - https://issues.redhat.com/browse/SPLAT-2191: update e2e step to set the provider across all jobs - openshift#64359 : once merged, fixes 4.18+, but 4.17- depends on SPLAT-2190 - [remove test skips for fixed permanent failures](https://issues.redhat.com/browse/SPLAT-2192)
|
I will hold until test framework changes are merged:
/hold |
…64657) Add skip to prevent permanent job failures caused by permanent test failures fixed in o/k repo. The final solution are coordinated with several changes in the test framework, which depends on: - https://issues.redhat.com/browse/SPLAT-2190: introduce external provider to the test framework 4.17- - https://issues.redhat.com/browse/SPLAT-2191: update e2e step to set the provider across all jobs - #64359 : once merged, fixes 4.18+, but 4.17- depends on SPLAT-2190 - [remove test skips for fixed permanent failures](https://issues.redhat.com/browse/SPLAT-2192)
|
/lgtm |
|
This PR is ok to as we have 4.16+ support on pext-external. |
|
@mtulio: This pull request references SPLAT-2191 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mtulio: This pull request references SPLAT-2191 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcpowermac, mtulio, neisw, vr4manta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
88a6891
into
openshift:master
…m fixes (openshift#64657) Add skip to prevent permanent job failures caused by permanent test failures fixed in o/k repo. The final solution are coordinated with several changes in the test framework, which depends on: - https://issues.redhat.com/browse/SPLAT-2190: introduce external provider to the test framework 4.17- - https://issues.redhat.com/browse/SPLAT-2191: update e2e step to set the provider across all jobs - openshift#64359 : once merged, fixes 4.18+, but 4.17- depends on SPLAT-2190 - [remove test skips for fixed permanent failures](https://issues.redhat.com/browse/SPLAT-2192)
Now provider external is supported in 4.18+, we'll need to prepare to make the flag as default for all platform type External clusters. https://issues.redhat.com/browse/SPLAT-2191 This change depends on support of provider external to <4.18 in the test framework: https://issues.redhat.com/browse/SPLAT-2190
…m fixes (openshift#64657) Add skip to prevent permanent job failures caused by permanent test failures fixed in o/k repo. The final solution are coordinated with several changes in the test framework, which depends on: - https://issues.redhat.com/browse/SPLAT-2190: introduce external provider to the test framework 4.17- - https://issues.redhat.com/browse/SPLAT-2191: update e2e step to set the provider across all jobs - openshift#64359 : once merged, fixes 4.18+, but 4.17- depends on SPLAT-2190 - [remove test skips for fixed permanent failures](https://issues.redhat.com/browse/SPLAT-2192)
Now provider external is supported in 4.18+, we'll need to prepare to make the flag as default for all platform type External clusters. https://issues.redhat.com/browse/SPLAT-2191 This change depends on support of provider external to <4.18 in the test framework: https://issues.redhat.com/browse/SPLAT-2190
Now provider external is supported in 4.18+, we'll need to prepare to make the flag as default for all platform type External clusters.
https://issues.redhat.com/browse/SPLAT-2191
Those are the dependencies and status: