Skip to content

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Apr 29, 2025

Now provider external is supported in 4.18+, we'll need to prepare to make the flag as default for all platform type External clusters.
https://issues.redhat.com/browse/SPLAT-2191

Those are the dependencies and status:

Now provider external is supported in 4.18+, we'll need
to prepare to make the flag as default for all platform type External
clusters.
https://issues.redhat.com/browse/SPLAT-2191

This change depends on support of provider external to <4.18 in the test
framework: https://issues.redhat.com/browse/SPLAT-2190
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 29, 2025

@mtulio: This pull request references SPLAT-2191 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Now provider external is supported in 4.18+, we'll need to prepare to make the flag as default for all platform type External clusters.
https://issues.redhat.com/browse/SPLAT-2191

This change depends on support of provider external to <4.18 in the test framework: https://issues.redhat.com/browse/SPLAT-2190

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mtulio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-machine-approver-master-okd-scos-e2e-aws-ovn openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-master-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.20-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.19-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.18-okd-scos-e2e-aws-ovn openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.18-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.17-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.16-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.15-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.14-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.13-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.12-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.11-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.10-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.9-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.8-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.7-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.6-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.5-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.4-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.3-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.2-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.1-e2e-aws openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-master-e2e-aws-capi-techpreview openshift/cluster-machine-approver presubmit Registry content changed
pull-ci-openshift-cluster-machine-approver-release-4.20-e2e-aws-capi-techpreview openshift/cluster-machine-approver presubmit Registry content changed

A total of 12654 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mtulio
Copy link
Contributor Author

mtulio commented May 2, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm periodic-ci-openshift-release-master-nightly-4.20-e2e-external-vsphere-ccm periodic-ci-openshift-release-master-nightly-4.19-e2e-external-aws

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented May 2, 2025

/test all

@mtulio mtulio marked this pull request as ready for review May 2, 2025 16:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2025
@mtulio
Copy link
Contributor Author

mtulio commented May 2, 2025

Flag --provider '{"type":"external"}' is set to impacted periodic jobs.

Running auto-ack.
/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot requested review from smg247 and stbenjam May 2, 2025 16:48
@vr4manta
Copy link
Contributor

vr4manta commented May 2, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2025
@openshift-ci-robot
Copy link
Contributor

@mtulio, pj-rehearse: failed to create rehearsal jobs ERROR:

failed waiting for prowjobs to finish: context deadline exceeded

If the problem persists, please contact Test Platform.

@mtulio
Copy link
Contributor Author

mtulio commented May 2, 2025

/pj-rehearse periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2025

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/machine-api-provider-openstack/main/okd-scos-e2e-aws-ovn 47eae8b link unknown /pj-rehearse pull-ci-openshift-machine-api-provider-openstack-main-okd-scos-e2e-aws-ovn
ci/rehearse/openshift/machine-api-provider-openstack/release-4.19/e2e-openstack-dualstack 47eae8b link unknown /pj-rehearse pull-ci-openshift-machine-api-provider-openstack-release-4.19-e2e-openstack-dualstack
ci/rehearse/openshift/machine-api-provider-openstack/release-4.20/e2e-openstack-dualstack 47eae8b link unknown /pj-rehearse pull-ci-openshift-machine-api-provider-openstack-release-4.20-e2e-openstack-dualstack
ci/rehearse/openshift/machine-api-provider-openstack/main/e2e-openstack-dualstack 47eae8b link unknown /pj-rehearse pull-ci-openshift-machine-api-provider-openstack-main-e2e-openstack-dualstack
ci/rehearse/openshift/machine-api-provider-openstack/release-4.18/okd-scos-e2e-aws-ovn 47eae8b link unknown /pj-rehearse pull-ci-openshift-machine-api-provider-openstack-release-4.18-okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio
Copy link
Contributor Author

mtulio commented May 5, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 5, 2025
mtulio added a commit to mtulio/release that referenced this pull request May 7, 2025
mtulio added a commit to mtulio/release that referenced this pull request May 7, 2025
…m fixes

Add skip to prevent permanent job failures caused by permanent test failures fixed in o/k repo.

The final solution are coordinated with several changes in the test framework, which depends on:

- https://issues.redhat.com/browse/SPLAT-2190: introduce external provider to the test framework 4.17-
- https://issues.redhat.com/browse/SPLAT-2191: update e2e step to set the provider across all jobs
    - openshift#64359 : once merged, fixes 4.18+, but 4.17- depends on SPLAT-2190
- [remove test skips for fixed permanent failures](https://issues.redhat.com/browse/SPLAT-2192)
@mtulio
Copy link
Contributor Author

mtulio commented May 7, 2025

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2025
openshift-merge-bot bot pushed a commit that referenced this pull request May 9, 2025
…64657)

Add skip to prevent permanent job failures caused by permanent test failures fixed in o/k repo.

The final solution are coordinated with several changes in the test framework, which depends on:

- https://issues.redhat.com/browse/SPLAT-2190: introduce external provider to the test framework 4.17-
- https://issues.redhat.com/browse/SPLAT-2191: update e2e step to set the provider across all jobs
    - #64359 : once merged, fixes 4.18+, but 4.17- depends on SPLAT-2190
- [remove test skips for fixed permanent failures](https://issues.redhat.com/browse/SPLAT-2192)
@jcpowermac
Copy link
Contributor

/lgtm

@mtulio
Copy link
Contributor Author

mtulio commented May 16, 2025

This PR is ok to as we have 4.16+ support on pext-external.
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2025

@mtulio: This pull request references SPLAT-2191 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Now provider external is supported in 4.18+, we'll need to prepare to make the flag as default for all platform type External clusters.
https://issues.redhat.com/browse/SPLAT-2191

This change depends on support of provider external to <4.18 in the test framework: https://issues.redhat.com/browse/SPLAT-2190

Those are the dependencies resolved so far:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2025

@mtulio: This pull request references SPLAT-2191 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Now provider external is supported in 4.18+, we'll need to prepare to make the flag as default for all platform type External clusters.
https://issues.redhat.com/browse/SPLAT-2191

Those are the dependencies and status:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@neisw
Copy link
Contributor

neisw commented May 16, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, mtulio, neisw, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 88a6891 into openshift:master May 16, 2025
16 of 21 checks passed
@mtulio mtulio deleted the SPLAT-2090-set-provider-external branch May 16, 2025 17:24
tbuskey pushed a commit to tbuskey/release that referenced this pull request May 19, 2025
…m fixes (openshift#64657)

Add skip to prevent permanent job failures caused by permanent test failures fixed in o/k repo.

The final solution are coordinated with several changes in the test framework, which depends on:

- https://issues.redhat.com/browse/SPLAT-2190: introduce external provider to the test framework 4.17-
- https://issues.redhat.com/browse/SPLAT-2191: update e2e step to set the provider across all jobs
    - openshift#64359 : once merged, fixes 4.18+, but 4.17- depends on SPLAT-2190
- [remove test skips for fixed permanent failures](https://issues.redhat.com/browse/SPLAT-2192)
tbuskey pushed a commit to tbuskey/release that referenced this pull request May 19, 2025
Now provider external is supported in 4.18+, we'll need
to prepare to make the flag as default for all platform type External
clusters.
https://issues.redhat.com/browse/SPLAT-2191

This change depends on support of provider external to <4.18 in the test
framework: https://issues.redhat.com/browse/SPLAT-2190
tareqalayan pushed a commit to tareqalayan/release that referenced this pull request May 26, 2025
…m fixes (openshift#64657)

Add skip to prevent permanent job failures caused by permanent test failures fixed in o/k repo.

The final solution are coordinated with several changes in the test framework, which depends on:

- https://issues.redhat.com/browse/SPLAT-2190: introduce external provider to the test framework 4.17-
- https://issues.redhat.com/browse/SPLAT-2191: update e2e step to set the provider across all jobs
    - openshift#64359 : once merged, fixes 4.18+, but 4.17- depends on SPLAT-2190
- [remove test skips for fixed permanent failures](https://issues.redhat.com/browse/SPLAT-2192)
abraham2512 pushed a commit to abraham2512/release that referenced this pull request May 29, 2025
Now provider external is supported in 4.18+, we'll need
to prepare to make the flag as default for all platform type External
clusters.
https://issues.redhat.com/browse/SPLAT-2191

This change depends on support of provider external to <4.18 in the test
framework: https://issues.redhat.com/browse/SPLAT-2190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants