Skip to content

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Apr 29, 2025

Support platform type External as a valid provider in the test framework. The external platform initially act as None, and not require additional configuration at this moment. This change will add the minimum support to allow CI readiness for this platform.

The initial support has been added to 4.19, in order to skip permanent failures added in upstream kube on 4.18.

As the --provider flag is added in the CI step level, and that step does not support release check, it will be complex to implement a logic in CI instead of just global support of --provider across all versions the platform type external jobs are tested: 4.15+.

References:

Support platform type `External` as a valid provider in the test
framework. The external platform initially act as None, and not require
additional configuration at this moment. This change will add the
minimum support to allow CI readiness for this platform.

The initial support has been added to 4.19, in order to skip
permanent failures added in upstream kube on 4.18.

As the --provider flag is added in the CI step level, and that step does
not support release check, it will be complex to implement a logic in CI
instead of just global support of --provider across all versions the
platform type external jobs are tested: 4.15+.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 29, 2025
@openshift-ci-robot
Copy link

@mtulio: This pull request references Jira Issue OCPBUGS-55476, which is invalid:

  • expected Jira Issue OCPBUGS-55476 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Support platform type External as a valid provider in the test framework. The external platform initially act as None, and not require additional configuration at this moment. This change will add the minimum support to allow CI readiness for this platform.

The initial support has been added to 4.19, in order to skip permanent failures added in upstream kube on 4.18.

As the --provider flag is added in the CI step level, and that step does not support release check, it will be complex to implement a logic in CI instead of just global support of --provider across all versions the platform type external jobs are tested: 4.15+.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and sjenning April 29, 2025 17:37
@mtulio
Copy link
Contributor Author

mtulio commented Apr 29, 2025

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2025

@mtulio: The following commands are available to trigger required jobs:

/test e2e-aws-jenkins
/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-image-registry
/test e2e-aws-ovn-serial
/test e2e-gcp-ovn
/test e2e-gcp-ovn-builds
/test e2e-gcp-ovn-image-ecosystem
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test images
/test lint
/test unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-agent-connected-ovn-dualstack-metal3
/test e2e-agent-connected-ovn-ipv4-metal3
/test e2e-agent-disconnected-ovn-dualstack-metal3
/test e2e-agnostic-ovn-cmd
/test e2e-aws
/test e2e-aws-csi
/test e2e-aws-disruptive
/test e2e-aws-etcd-recovery
/test e2e-aws-multitenant
/test e2e-aws-ovn
/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-etcd-scaling
/test e2e-aws-ovn-ipsec-serial
/test e2e-aws-ovn-kubevirt
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-single-node-serial
/test e2e-aws-ovn-single-node-upgrade
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-upi
/test e2e-aws-proxy
/test e2e-azure
/test e2e-azure-ovn-etcd-scaling
/test e2e-azure-ovn-upgrade
/test e2e-baremetalds-kubevirt
/test e2e-gcp-csi
/test e2e-gcp-disruptive
/test e2e-gcp-fips-serial
/test e2e-gcp-ovn-etcd-scaling
/test e2e-gcp-ovn-rt-upgrade
/test e2e-gcp-ovn-techpreview
/test e2e-gcp-ovn-techpreview-serial
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-dualstack-local-gateway
/test e2e-metal-ipi-sdn
/test e2e-metal-ipi-serial
/test e2e-metal-ipi-serial-ovn-ipv6
/test e2e-metal-ipi-virtualmedia
/test e2e-openstack-ovn
/test e2e-openstack-serial
/test e2e-vsphere
/test e2e-vsphere-ovn-dualstack-primaryv6
/test e2e-vsphere-ovn-etcd-scaling
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-release-4.16-e2e-agnostic-ovn-cmd
pull-ci-openshift-origin-release-4.16-e2e-aws-csi
pull-ci-openshift-origin-release-4.16-e2e-aws-ovn-cgroupsv2
pull-ci-openshift-origin-release-4.16-e2e-aws-ovn-edge-zones
pull-ci-openshift-origin-release-4.16-e2e-aws-ovn-fips
pull-ci-openshift-origin-release-4.16-e2e-aws-ovn-serial
pull-ci-openshift-origin-release-4.16-e2e-aws-ovn-single-node
pull-ci-openshift-origin-release-4.16-e2e-aws-ovn-single-node-serial
pull-ci-openshift-origin-release-4.16-e2e-aws-ovn-single-node-upgrade
pull-ci-openshift-origin-release-4.16-e2e-aws-ovn-upgrade
pull-ci-openshift-origin-release-4.16-e2e-azure-ovn-upgrade
pull-ci-openshift-origin-release-4.16-e2e-gcp-csi
pull-ci-openshift-origin-release-4.16-e2e-gcp-ovn
pull-ci-openshift-origin-release-4.16-e2e-gcp-ovn-builds
pull-ci-openshift-origin-release-4.16-e2e-gcp-ovn-rt-upgrade
pull-ci-openshift-origin-release-4.16-e2e-gcp-ovn-upgrade
pull-ci-openshift-origin-release-4.16-e2e-metal-ipi-ovn-dualstack-local-gateway
pull-ci-openshift-origin-release-4.16-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-origin-release-4.16-e2e-metal-ipi-sdn
pull-ci-openshift-origin-release-4.16-e2e-openstack-ovn
pull-ci-openshift-origin-release-4.16-e2e-vsphere-ovn-dualstack-primaryv6
pull-ci-openshift-origin-release-4.16-images
pull-ci-openshift-origin-release-4.16-lint
pull-ci-openshift-origin-release-4.16-unit
pull-ci-openshift-origin-release-4.16-verify
pull-ci-openshift-origin-release-4.16-verify-deps
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mtulio
Copy link
Contributor Author

mtulio commented May 2, 2025

This PR is ready for review.

/assign @rvanderp3 @jupierce

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2025

@mtulio: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

Details

In response to this:

This PR is ready for review.

/assign @rvanderp3 @jupierce
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mtulio
Copy link
Contributor Author

mtulio commented May 14, 2025

/jira refresh

@openshift-ci-robot
Copy link

@mtulio: This pull request references Jira Issue OCPBUGS-55476, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Release Pending (Done) instead
  • expected Jira Issue OCPBUGS-55476 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
Copy link
Contributor Author

mtulio commented May 14, 2025

/jira refresh

@openshift-ci-robot
Copy link

@mtulio: This pull request references Jira Issue OCPBUGS-55476, which is invalid:

  • expected Jira Issue OCPBUGS-55476 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
Copy link
Contributor Author

mtulio commented May 14, 2025

/jira refresh

@openshift-ci-robot
Copy link

@mtulio: This pull request references Jira Issue OCPBUGS-55476, which is invalid:

  • expected Jira Issue OCPBUGS-55476 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@jcpowermac: This pull request references Jira Issue OCPBUGS-55476, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-55476 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@jcpowermac: This pull request references Jira Issue OCPBUGS-55476, which is invalid:

  • expected Jira Issue OCPBUGS-55476 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@jcpowermac: This pull request references Jira Issue OCPBUGS-55476, which is invalid:

  • expected Jira Issue OCPBUGS-55476 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
Copy link
Contributor Author

mtulio commented May 14, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 14, 2025
@openshift-ci-robot
Copy link

@mtulio: This pull request references Jira Issue OCPBUGS-55476, which is valid.

9 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-55451 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent bug Jira Issue OCPBUGS-55451 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-55451 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • dependent Jira Issue OCPBUGS-55451 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@neisw
Copy link
Contributor

neisw commented May 14, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, mtulio, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@jupierce jupierce added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 14, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3073d4b and 2 for PR HEAD a1aa22e in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3073d4b and 2 for PR HEAD a1aa22e in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3073d4b and 2 for PR HEAD a1aa22e in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2025

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade a1aa22e link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial a1aa22e link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway a1aa22e link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 a1aa22e link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-aws-ovn-upgrade a1aa22e link false /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio
Copy link
Contributor Author

mtulio commented May 16, 2025

/test e2e-aws-ovn-edge-zones

@openshift-merge-bot openshift-merge-bot bot merged commit c7747b3 into openshift:release-4.16 May 16, 2025
22 of 27 checks passed
@openshift-ci-robot
Copy link

@mtulio: Jira Issue OCPBUGS-55476: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55476 has been moved to the MODIFIED state.

Details

In response to this:

Support platform type External as a valid provider in the test framework. The external platform initially act as None, and not require additional configuration at this moment. This change will add the minimum support to allow CI readiness for this platform.

The initial support has been added to 4.19, in order to skip permanent failures added in upstream kube on 4.18.

As the --provider flag is added in the CI step level, and that step does not support release check, it will be complex to implement a logic in CI instead of just global support of --provider across all versions the platform type external jobs are tested: 4.15+.

References:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio mtulio deleted the OCPBUGS-55476 branch May 16, 2025 13:19
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202505161336.p0.gc7747b3.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.