Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #29623

/assign mtulio

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-53249 has been cloned as Jira Issue OCPBUGS-54807. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-54807: feat: support platform type external

Details

In response to this:

This is an automated cherry-pick of #29623

/assign mtulio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-53249: feat: support platform type external [release-4.18] OCPBUGS-54807: feat: support platform type external Apr 9, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 9, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-54807, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-53249 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #29623

/assign mtulio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning April 9, 2025 16:22
@mtulio
Copy link
Contributor

mtulio commented Apr 9, 2025

/test e2e-external-aws-ccm

@mtulio
Copy link
Contributor

mtulio commented Apr 9, 2025

/retitle "[release-4.18] OCPBUGS-54807: support provider type external"

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-54807: feat: support platform type external "[release-4.18] OCPBUGS-54807: support provider type external" Apr 9, 2025
@mtulio
Copy link
Contributor

mtulio commented Apr 9, 2025

/retitle [release-4.18] OCPBUGS-54807: support provider type external

@openshift-ci openshift-ci bot changed the title "[release-4.18] OCPBUGS-54807: support provider type external" [release-4.18] OCPBUGS-54807: support provider type external Apr 9, 2025
@mtulio
Copy link
Contributor

mtulio commented Apr 10, 2025

A lot of errors, looks like unrelated. Testing again

/test e2e-external-aws-ccm

@rvanderp3
Copy link
Contributor

/lgtm

@mtulio
Copy link
Contributor

mtulio commented Apr 10, 2025

/jira-refresh

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2025
@mtulio
Copy link
Contributor

mtulio commented Apr 10, 2025

/test e2e-external-aws

@mtulio
Copy link
Contributor

mtulio commented Apr 10, 2025

e2e-external-aws-ccm is failing with the expected tests (target to be fixed by openshift/kubernetes#2268).

LGTM this test, this PR is ready for review.

@mtulio
Copy link
Contributor

mtulio commented Apr 10, 2025

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

@mtulio: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@neisw
Copy link
Contributor

neisw commented Apr 10, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, openshift-cherrypick-robot, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-kube-apiserver-rollout f12c5fc link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node-upgrade f12c5fc link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout f12c5fc link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ipi-ovn f12c5fc link false /test e2e-metal-ipi-ovn
ci/prow/e2e-aws-ovn-single-node f12c5fc link false /test e2e-aws-ovn-single-node
ci/prow/e2e-external-aws-ccm f12c5fc link false /test e2e-external-aws-ccm
ci/prow/e2e-external-aws f12c5fc link false /test e2e-external-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio
Copy link
Contributor

mtulio commented Apr 11, 2025

/assign @jupierce

@jupierce jupierce added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 11, 2025
@jupierce jupierce added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 11, 2025
@mtulio
Copy link
Contributor

mtulio commented Apr 11, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 11, 2025
@openshift-ci-robot
Copy link

@mtulio: This pull request references Jira Issue OCPBUGS-54807, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-53249 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-53249 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 04a35da and 2 for PR HEAD f12c5fc in total

@openshift-merge-bot openshift-merge-bot bot merged commit bf5bfee into openshift:release-4.18 Apr 11, 2025
24 of 31 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-54807: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-54807 has not been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #29623

/assign mtulio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202504120004.p0.gbf5bfee.assembly.stream.el9.
All builds following this will include this PR.

@mtulio
Copy link
Contributor

mtulio commented Apr 29, 2025

I will need to cherry pick to all version we support currently as I can't set the provider by release in the e2e step with minor changes, thus <4.18 jobs will start to fail. note: we don't need o/k changes as the perm failures tests were introduced in upstream kube for 4.18.

https://github.com/openshift/release/blob/master/ci-operator/step-registry/openshift/e2e/test/openshift-e2e-test-commands.sh#L201-L211

/cherry-pick release-4.17

@mtulio
Copy link
Contributor

mtulio commented Apr 29, 2025

^ cc @rvanderp3 @jupierce

@openshift-cherrypick-robot
Copy link
Author

@mtulio: new pull request created: #29734

Details

In response to this:

I will need to cherry pick to all version we support currently as I can't set the provider by release in the e2e step with minor changes, thus <4.18 jobs will start to fail. note: we don't need o/k changes as the perm failures tests were introduced in upstream kube for 4.18.

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.