Skip to content

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Apr 18, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 18, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2025

@mtulio: This pull request references SPLAT-2090 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Remove explicit test skips for workflows running on platform type External.

The provider type external is now being supported by the test framework, and permanent failures must be skipped in the framework level.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from benluddy and deads2k April 18, 2025 01:28
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2025

@mtulio: This pull request references SPLAT-2090 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Remove explicit test skips for workflows running on platform type External.

The provider type external is now being supported by the test framework, and permanent failures must be skipped in the framework level.

References:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 18, 2025

/pj-rehearse pull-ci-openshift-origin-release-4.19-e2e-external-aws-ccm pull-ci-openshift-kubernetes-release-4.19-e2e-external-aws-ccm periodic-ci-openshift-release-master-nightly-4.18-e2e-external-vsphere-ccm periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@mtulio: job(s): either don't exist or were not found to be affected, and cannot be rehearsed

@mtulio
Copy link
Contributor Author

mtulio commented Apr 18, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 18, 2025

The 4.18 PR was merged today in Kubernetes. I will need to wait a bit for the next test cycle on 4.18.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 22, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2025
@openshift-ci-robot
Copy link
Contributor

@mtulio: job(s): periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm either don't exist or were not found to be affected, and cannot be rehearsed

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Apr 22, 2025

Rebased
/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 22, 2025

Cluster profile has been changed[1] in mainstream, making the platform external jobs to fail as hosted zone is changed. Trying to unset in the workflow level before investigating with CI infra

[1] #64080

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 22, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2025
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 22, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Apr 22, 2025

Rebased again. I am going to prevent requiring the BASE_DOMAIN in the Pext/AWS steps, leaving the step ipi-conf to set it.

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 22, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 19, 2025

@mtulio: This pull request references SPLAT-2192 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Remove explicit test skips for workflows running on platform type External.

The provider type external is now being supported by the test framework, and permanent failures must be skipped in the framework level.

References:

This PR is blocked by origin changes:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 19, 2025

@mtulio: This pull request references SPLAT-2192 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Remove explicit test skips for workflows running on platform type External.

The provider type external is now being supported by the test framework, and permanent failures must be skipped in the framework level.

References:

This PR is blocked by origin changes:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mtulio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kubernetes-release-4.19-e2e-external-aws-ccm openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-release-4.20-e2e-external-aws-ccm openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-release-4.18-e2e-external-aws-ccm openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-release-4.21-e2e-external-aws-ccm openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-origin-main-e2e-external-aws openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-external-aws-ccm openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-external-vsphere-ccm openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.19-e2e-external-aws openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.19-e2e-external-aws-ccm openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.19-e2e-external-vsphere-ccm openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.17-e2e-external-aws openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.17-e2e-external-aws-ccm openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.20-e2e-external-aws openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.20-e2e-external-aws-ccm openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.20-e2e-external-vsphere-ccm openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.18-e2e-external-aws openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.18-e2e-external-aws-ccm openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.18-e2e-external-vsphere-ccm openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.21-e2e-external-aws openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.21-e2e-external-aws-ccm openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.21-e2e-external-vsphere-ccm openshift/origin presubmit Registry content changed
pull-ci-openshift-installer-main-e2e-external-aws openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-main-e2e-external-aws-ccm openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.21-e2e-external-aws openshift/installer presubmit Registry content changed

A total of 51 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2025
@mtulio
Copy link
Contributor Author

mtulio commented May 19, 2025

testing in other impacted repos
/pj-rehearse pull-ci-openshift-kubernetes-release-4.19-e2e-external-aws-ccm pull-ci-openshift-origin-release-4.19-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented May 20, 2025

Looks like a bug in 4.19, re-trying in 4.18:
/pj-rehearse pull-ci-openshift-kubernetes-release-4.18-e2e-external-aws-ccm pull-ci-openshift-origin-release-4.18-e2e-external-aws-ccm periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 20, 2025

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.18-e2e-external-vsphere-ccm e38c4fd link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-vsphere-ccm
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.19-e2e-external-aws-ccm 6fdb9e7 link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.19-e2e-external-aws-ccm
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.19-e2e-external-aws 6de348b link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.19-e2e-external-aws
ci/rehearse/openshift/origin/release-4.19/e2e-external-aws-ccm 6de348b link unknown /pj-rehearse pull-ci-openshift-origin-release-4.19-e2e-external-aws-ccm
ci/rehearse/openshift/kubernetes/release-4.19/e2e-external-aws-ccm 6de348b link unknown /pj-rehearse pull-ci-openshift-kubernetes-release-4.19-e2e-external-aws-ccm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio
Copy link
Contributor Author

mtulio commented May 20, 2025

/pj-rehearse pull-ci-openshift-origin-release-4.18-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented May 20, 2025

We have enough runs to mark this PR as ready.
/pj-rehearse ack

@mtulio mtulio marked this pull request as ready for review May 20, 2025 19:49
@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 20, 2025
@openshift-ci openshift-ci bot requested review from AlexNPavel and jcpowermac May 20, 2025 19:50
@mtulio
Copy link
Contributor Author

mtulio commented May 20, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2025
@neisw
Copy link
Contributor

neisw commented May 21, 2025

/approve

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jcpowermac, mtulio, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e1859d9 into openshift:master May 21, 2025
22 of 25 checks passed
@mtulio mtulio deleted the pext-rm-skips branch May 21, 2025 12:23
abraham2512 pushed a commit to abraham2512/release that referenced this pull request May 29, 2025
Test skips from workflow and jobs must be removed as all known issues
have been resolved*, and permanent failures was skipped in the test
framework for platform type external (provider type).

See the consolidated Jira task for more information about all changes:
https://issues.redhat.com/browse/SPLAT-2090

*except 4.15, non-blocking, which is blocked in review phase:
openshift/origin#29739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants