-
Notifications
You must be signed in to change notification settings - Fork 2.1k
SPLAT-2192: Platform External: Remove fixed test skips #64021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mtulio: This pull request references SPLAT-2090 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mtulio: This pull request references SPLAT-2090 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse pull-ci-openshift-origin-release-4.19-e2e-external-aws-ccm pull-ci-openshift-kubernetes-release-4.19-e2e-external-aws-ccm periodic-ci-openshift-release-master-nightly-4.18-e2e-external-vsphere-ccm periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mtulio: job(s): either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
The 4.18 PR was merged today in Kubernetes. I will need to wait a bit for the next test cycle on 4.18. |
|
/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mtulio: job(s): periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm either don't exist or were not found to be affected, and cannot be rehearsed |
|
Rebased |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Cluster profile has been changed[1] in mainstream, making the platform external jobs to fail as hosted zone is changed. Trying to unset in the workflow level before investigating with CI infra [1] #64080 /pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Rebased again. I am going to prevent requiring the BASE_DOMAIN in the Pext/AWS steps, leaving the step /pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm |
|
@mtulio: This pull request references SPLAT-2192 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@mtulio: This pull request references SPLAT-2192 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[REHEARSALNOTIFIER]
A total of 51 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
testing in other impacted repos |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Looks like a bug in 4.19, re-trying in 4.18: |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mtulio: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse pull-ci-openshift-origin-release-4.18-e2e-external-aws-ccm |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
We have enough runs to mark this PR as ready. |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/hold cancel |
|
/approve |
bertinatto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jcpowermac, mtulio, neisw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e1859d9
into
openshift:master
Test skips from workflow and jobs must be removed as all known issues have been resolved*, and permanent failures was skipped in the test framework for platform type external (provider type). See the consolidated Jira task for more information about all changes: https://issues.redhat.com/browse/SPLAT-2090 *except 4.15, non-blocking, which is blocked in review phase: openshift/origin#29739
Remove explicit test skips for workflows running on platform type External.
The provider type
externalis now being supported by the test framework, and permanent failures must be skipped in the framework level.References:
This PR is blocked by origin changes: