Skip to content

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Apr 2, 2025

Enforce presubmit jobs of platform type External clusters running on kubernetes fork to set the expected provider flag.

This change is used to validate the PR openshift/kubernetes#2247. This behavior will be the default in the near future when the test framework supports it across all release tested by the e2e workflow.

This change was already tested here: openshift/origin#29623

Summary of relevant jobs rehearsed:

Not impacted, triggered by file change:

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 2, 2025
@openshift-ci-robot
Copy link
Contributor

@mtulio: This pull request references Jira Issue OCPBUGS-53249, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Enforce presubmit jobs of platform type External clusters running on kubernetes fork to set the expected provider flag.

This change is used to validate the PR openshift/kubernetes#2247. This behavior will be the default in the near future when the test framework supports it across all release tested by the e2e workflow.

This change was already tested here: openshift/origin#29623

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 2, 2025

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot requested review from smg247 and sosiouxme April 2, 2025 14:06
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mtulio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ran-profile openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.18-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.18-e2e-aws-ran-profile openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.17-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.17-e2e-aws-ran-profile openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.16-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.16-e2e-aws-ran-profile openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.15-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.15-e2e-aws-ran-profile openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.14-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.14-e2e-aws-ran-profile openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.13-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.13-e2e-aws-ran-profile openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.12-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.12-e2e-aws-ran-profile openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.11-e2e-aws-ran-profile openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.10-e2e-aws-ran-profile openshift-kni/cnf-features-deploy presubmit Registry content changed
pull-ci-openshift-oc-mirror-main-okd-scos-e2e-aws-ovn openshift/oc-mirror presubmit Registry content changed
pull-ci-openshift-oc-mirror-release-4.18-okd-scos-e2e-aws-ovn openshift/oc-mirror presubmit Registry content changed
pull-ci-openshift-alibaba-cloud-csi-driver-release-4.15-e2e-alibabacloud-disk-csi openshift/alibaba-cloud-csi-driver presubmit Registry content changed
pull-ci-openshift-alibaba-cloud-csi-driver-release-4.14-e2e-alibabacloud-disk-csi openshift/alibaba-cloud-csi-driver presubmit Registry content changed
pull-ci-openshift-alibaba-cloud-csi-driver-release-4.13-e2e-alibabacloud-disk-csi openshift/alibaba-cloud-csi-driver presubmit Registry content changed
pull-ci-openshift-alibaba-cloud-csi-driver-release-4.12-e2e-alibabacloud-disk-csi openshift/alibaba-cloud-csi-driver presubmit Registry content changed
pull-ci-openshift-alibaba-cloud-csi-driver-release-4.11-e2e-alibabacloud-disk-csi openshift/alibaba-cloud-csi-driver presubmit Registry content changed

A total of 12670 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@vr4manta
Copy link
Contributor

vr4manta commented Apr 2, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Apr 2, 2025

/assign @stbenjam @bertinatto

@mtulio
Copy link
Contributor Author

mtulio commented Apr 2, 2025

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm pull-ci-openshift-origin-release-4.19-e2e-external-vsphere-ccm periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 3, 2025

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 3, 2025

pull-ci-openshift-origin-release-4.19-e2e-external-vsphere-ccm is failing for a different reason no matching TEST_SKIPS. I will address it in another PR.

Now that the origin is supporting the provider=external, the most important job (kubernetes) is expected to fail in the test phase. Let’s check it:

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 3, 2025

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 3, 2025

This test is also not expected to pass due 2 LoadBalancer tests, but nothing else:

/pj-rehearse pull-ci-openshift-origin-main-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 3, 2025

Jobs accepted:

$ ./openshift-tests run openshift/conformance/parallel --provider '{"type":"external"}' -o ./artifacts/e2e.log --junit-dir ./artifacts/junit --dry-run --provider='{"type":"vsphere"}' | grep 'provisioning should mount multiple PV pointing to the same storage on the same node' | egrep ^'"\[' | wc -l
48

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 3, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Apr 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtulio, vr4manta Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

This PR is ready for review.

/assign neisw

FWIW/additional information: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1743533487666609

@mtulio
Copy link
Contributor Author

mtulio commented Apr 3, 2025

@openshift-ci-robot
Copy link
Contributor

@mtulio: This pull request references Jira Issue OCPBUGS-53249, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Enforce presubmit jobs of platform type External clusters running on kubernetes fork to set the expected provider flag.

This change is used to validate the PR openshift/kubernetes#2247. This behavior will be the default in the near future when the test framework supports it across all release tested by the e2e workflow.

This change was already tested here: openshift/origin#29623

Summary of relevant jobs rehearsed:

Not impacted, triggered by file change:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/okd-machine-os/release-4.17/e2e-aws-ovn e863b81 link unknown /pj-rehearse pull-ci-openshift-okd-machine-os-release-4.17-e2e-aws-ovn
ci/rehearse/openshift/origin/release-4.19/e2e-external-vsphere-ccm e863b81 link unknown /pj-rehearse pull-ci-openshift-origin-release-4.19-e2e-external-vsphere-ccm
ci/rehearse/openshift/okd-machine-os/release-4.20/e2e-aws-ovn e863b81 link unknown /pj-rehearse pull-ci-openshift-okd-machine-os-release-4.20-e2e-aws-ovn
ci/rehearse/openshift/okd-machine-os/release-4.19/e2e-aws-ovn e863b81 link unknown /pj-rehearse pull-ci-openshift-okd-machine-os-release-4.19-e2e-aws-ovn
ci/rehearse/openshift/okd-machine-os/master/e2e-aws-ovn e863b81 link unknown /pj-rehearse pull-ci-openshift-okd-machine-os-master-e2e-aws-ovn
ci/rehearse/openshift/okd-machine-os/release-4.18/e2e-aws-ovn e863b81 link unknown /pj-rehearse pull-ci-openshift-okd-machine-os-release-4.18-e2e-aws-ovn
ci/rehearse/openshift/origin/main/e2e-external-aws-ccm e863b81 link unknown /pj-rehearse pull-ci-openshift-origin-main-e2e-external-aws-ccm
ci/rehearse/openshift/alibaba-cloud-csi-driver/release-4.11/e2e-alibabacloud-disk-csi e863b81 link unknown /pj-rehearse pull-ci-openshift-alibaba-cloud-csi-driver-release-4.11-e2e-alibabacloud-disk-csi
ci/rehearse/openshift/alibaba-cloud-csi-driver/release-4.15/e2e-alibabacloud-disk-csi e863b81 link unknown /pj-rehearse pull-ci-openshift-alibaba-cloud-csi-driver-release-4.15-e2e-alibabacloud-disk-csi
ci/rehearse/openshift/alibaba-cloud-csi-driver/release-4.13/e2e-alibabacloud-disk-csi e863b81 link unknown /pj-rehearse pull-ci-openshift-alibaba-cloud-csi-driver-release-4.13-e2e-alibabacloud-disk-csi
ci/rehearse/openshift/alibaba-cloud-csi-driver/release-4.14/e2e-alibabacloud-disk-csi e863b81 link unknown /pj-rehearse pull-ci-openshift-alibaba-cloud-csi-driver-release-4.14-e2e-alibabacloud-disk-csi
ci/rehearse/openshift/kubernetes/master/e2e-external-aws-ccm e863b81 link unknown /pj-rehearse pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm
ci/rehearse/openshift/alibaba-cloud-csi-driver/release-4.12/e2e-alibabacloud-disk-csi e863b81 link unknown /pj-rehearse pull-ci-openshift-alibaba-cloud-csi-driver-release-4.12-e2e-alibabacloud-disk-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dgoodwin
Copy link
Contributor

dgoodwin commented Apr 4, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, mtulio, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit b1e970a into openshift:master Apr 4, 2025
12 of 25 checks passed
@openshift-ci-robot
Copy link
Contributor

@mtulio: Jira Issue OCPBUGS-53249: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-53249 has not been moved to the MODIFIED state.

Details

In response to this:

Enforce presubmit jobs of platform type External clusters running on kubernetes fork to set the expected provider flag.

This change is used to validate the PR openshift/kubernetes#2247. This behavior will be the default in the near future when the test framework supports it across all release tested by the e2e workflow.

This change was already tested here: openshift/origin#29623

Summary of relevant jobs rehearsed:

Not impacted, triggered by file change:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants