-
Notifications
You must be signed in to change notification settings - Fork 2.1k
OCPBUGS-53249: set provider to e2e on kube presubmit #63446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-53249: set provider to e2e on kube presubmit #63446
Conversation
|
@mtulio: This pull request references Jira Issue OCPBUGS-53249, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse auto-ack |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 12670 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
/assign @stbenjam @bertinatto |
|
/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm pull-ci-openshift-origin-release-4.19-e2e-external-vsphere-ccm periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
e2e-external-aws-ccm failed where we wanted[1] considering dependency[2] isn't merged yet. [1] https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/63446/rehearse-63446-pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm/1907481005665554432#1:build-log.txt%3A195 Another affected job passed as expected as it's not setting the provider flag: /periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm /pj-rehearse auto-ack |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Now that the origin is supporting the provider=external, the most important job (kubernetes) is expected to fail in the test phase. Let’s check it: /pj-rehearse pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
This test is also not expected to pass due 2 LoadBalancer tests, but nothing else: /pj-rehearse pull-ci-openshift-origin-main-e2e-external-aws-ccm |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Jobs accepted:
/pj-rehearse ack |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
This PR is ready for review. /assign neisw FWIW/additional information: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1743533487666609 |
|
Summary of relevant jobs:
Not impacted, triggered by file change: |
|
@mtulio: This pull request references Jira Issue OCPBUGS-53249, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mtulio: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, mtulio, vr4manta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
b1e970a
into
openshift:master
|
@mtulio: Jira Issue OCPBUGS-53249: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-53249 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Enforce presubmit jobs of platform type External clusters running on kubernetes fork to set the expected provider flag.
This change is used to validate the PR openshift/kubernetes#2247. This behavior will be the default in the near future when the test framework supports it across all release tested by the e2e workflow.
This change was already tested here: openshift/origin#29623
Summary of relevant jobs rehearsed:
Not impacted, triggered by file change: