Skip to content

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Apr 1, 2025

This change is enforcing the provider type to external when running e2e workflow on presubmit jobs in the origin repository to test the following change: openshift/origin#29623 . (currently all presubmit jobs for platform type External are failing in certain repositories)

This is required if we want to skip tests only in platform type external, such as openshift/kubernetes#2247

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 1, 2025
@openshift-ci-robot
Copy link
Contributor

@mtulio: This pull request references Jira Issue OCPBUGS-53249, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 1, 2025

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm pull-ci-openshift-origin-release-4.18-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 1, 2025

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm pull-ci-openshift-origin-release-4.18-e2e-external-aws-ccm

Once above are acceptable, we don't want to broke periodics (ToDo):

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws-ccm periodic-ci-openshift-release-master-nightly-4.19-e2e-external-aws-ccm periodic-ci-openshift-release-master-nightly-4.18-e2e-external-vsphere-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: This pull request references Jira Issue OCPBUGS-53249, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

This change is enforcing the provider type to external when running e2e workflow.

This is required if we want to skip tests only in platform type external, such as openshift/kubernetes#2247

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 1, 2025

/test all

@mtulio mtulio force-pushed the OCPBUGS-53249-provider-external branch from 18804d5 to b2c01a0 Compare April 1, 2025 18:00
@mtulio
Copy link
Contributor Author

mtulio commented Apr 1, 2025

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm pull-ci-openshift-origin-release-4.18-e2e-external-aws-ccm periodic-ci-openshift-release-master-nightly-4.19-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Forcing the provider to external on presubmits on origin repository
(currently those are optional and are failing).
@mtulio mtulio force-pushed the OCPBUGS-53249-provider-external branch from b2c01a0 to fa88e52 Compare April 1, 2025 18:10
@mtulio
Copy link
Contributor Author

mtulio commented Apr 1, 2025

testing with broad match

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm pull-ci-openshift-origin-release-4.18-e2e-external-aws-ccm periodic-ci-openshift-release-master-nightly-4.19-e2e-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mtulio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-multus-cni-main-okd-scos-e2e-aws-ovn openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-main-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.20-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.19-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.18-okd-scos-e2e-aws-ovn openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.18-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.17-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.16-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.15-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.14-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.13-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.12-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.11-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.10-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.9-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.8-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.7-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.6-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.5-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.4-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.3-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.2-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.1-e2e-aws openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-main-e2e-aws-upgrade openshift/multus-cni presubmit Registry content changed
pull-ci-openshift-multus-cni-release-4.20-e2e-aws-upgrade openshift/multus-cni presubmit Registry content changed

A total of 12479 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 1, 2025

OKay, expected job to pass is passing[1], I will trigger overall rehearsals and get the PR ready for review.

[1] Periodic in stable and know platform: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/63367/rehearse-63367-periodic-ci-openshift-release-master-nightly-4.19-e2e-external-aws-ccm/1907134697998127104

/pj-rehearse auto-ack

@mtulio mtulio marked this pull request as ready for review April 1, 2025 20:46
@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2025
@openshift-ci openshift-ci bot requested review from neisw and stbenjam April 1, 2025 20:46
@openshift-ci-robot
Copy link
Contributor

@mtulio: This pull request references Jira Issue OCPBUGS-53249, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

This change is enforcing the provider type to external when running e2e workflow on presubmit jobs in the origin repository to test the following change: openshift/origin#29623 . (currently all presubmit jobs for platform type External is failing in certain repositories)

This is required if we want to skip tests only in platform type external, such as openshift/kubernetes#2247

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio mtulio changed the title OCPBUGS-53249: set provider external on e2e run OCPBUGS-53249: set provider external on e2e run on origin Apr 1, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Apr 1, 2025

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

This notification was skipped:

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@stbenjam
Copy link
Member

stbenjam commented Apr 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtulio, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 2, 2025

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/kubernetes/master/e2e-external-aws-ccm fa88e52 link unknown /pj-rehearse pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm
ci/rehearse/openshift/oc/master/okd-scos-e2e-aws-ovn fa88e52 link unknown /pj-rehearse pull-ci-openshift-oc-master-okd-scos-e2e-aws-ovn
ci/rehearse/openshift/origin/release-4.18/e2e-external-aws-ccm fa88e52 link unknown /pj-rehearse pull-ci-openshift-origin-release-4.18-e2e-external-aws-ccm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8d5d3fb into openshift:master Apr 2, 2025
20 of 23 checks passed
@openshift-ci-robot
Copy link
Contributor

@mtulio: Jira Issue OCPBUGS-53249: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-53249 has not been moved to the MODIFIED state.

Details

In response to this:

This change is enforcing the provider type to external when running e2e workflow on presubmit jobs in the origin repository to test the following change: openshift/origin#29623 . (currently all presubmit jobs for platform type External is failing in certain repositories)

This is required if we want to skip tests only in platform type external, such as openshift/kubernetes#2247

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

@mtulio: Jira Issue OCPBUGS-53249: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-53249 has not been moved to the MODIFIED state.

Details

In response to this:

This change is enforcing the provider type to external when running e2e workflow on presubmit jobs in the origin repository to test the following change: openshift/origin#29623 . (currently all presubmit jobs for platform type External are failing in certain repositories)

This is required if we want to skip tests only in platform type external, such as openshift/kubernetes#2247

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio mtulio deleted the OCPBUGS-53249-provider-external branch April 2, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants