bug 1686775 - Typo in Example #1 #14458
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erry-pick-13568-to-master [master] Update the monitoring diagram
…orm - enterprise "v3.11" tag is correct on OpenShift Container Platform (enterprise version), not "v3.11.0".
Correct the cluster autoscaler image tag on enterprise version
Adding [4.0] as the drop down option
bug 1673314 amended federation section
Setting encoding for script
bug 1670732 need to update master-config.yaml for a cert change
Updated list of allowed people for previews
3.9.68 async release notes
…otes 3.10.111 release notes stub added
…se-notes 3.11.82 release notes and latest-tags
bug 1664579 corrected command syntax
Improve advanced audit configuration
issue 13527 removed xPaaS image links
… update for CRUD VMs (including underlying Events, Consoles, NICs and Disks) and CRUD VM Templates. Primary BZ#1666251 that spawned BZ#1673453 & BZ#1676572.
Remove duplicate content
Added release notes for 3.9.74
Added release notes for 3.10.127
Added RHSA-2019:0739 to the release notes
"router-metrics-tls" secret should be service serving certificates secret. "router-certs" secret is using as wild card certificates and not service serving certificates secret. - Fix: https://bugzilla.redhat.com/show_bug.cgi?id=1672011
[enterprise-3.11] Correct a annotation for overriding existing cookie name
Fix incorrect deployment syntax
rotate-server-certificates gets set to false when set separately
bug 1656374 added notes for NetworkPolicy feature support
made changes to release notes syntax corrected date on release notes
Correct the steps for redeploying router certificates
Add missing registry examples to Ansible Broker Configuration
3.11.98 Release notes and tags
making guidance for variables in paths explicit
openshift-ci-robot
added
the
size/XS
Author
|
Link to BugZilla bug: https://bugzilla.redhat.com/show_bug.cgi?id=1686775 |
Contributor
|
@bgaydosrh - is this ready for review? If yes, request QE review by setting the bug on ON_QA and/or tagging the QE associate here. |
Author
|
Hi Vikram,
Yes, I'll tag this for QE and peer review. I'll also add a note to not
merge for 4.0.
I saw your email last night and was a little unsure if I should request
review or hold off.
Thanks,
Bob
…On Tue, Apr 16, 2019 at 7:06 AM Vikram Goyal ***@***.***> wrote:
@bgaydosrh <https://github.com/bgaydosrh> - is this ready for review? If
yes, request QE review by setting the bug on ON_QA and/or tagging the QE
associate here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14458 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALQXFOPZWKGI5LBWSJOMG4DPQWXKBANCNFSM4HGEMWSA>
.
|
Author
|
@openshift/team-documentation PTAL for peer review |
Author
|
This should be all set for peer and QE review now. Thanks for labeling the
release Vikram.
Bob
…On Tue, Apr 16, 2019 at 9:55 AM Robert Gaydos ***@***.***> wrote:
Hi Vikram,
Yes, I'll tag this for QE and peer review. I'll also add a note to not
merge for 4.0.
I saw your email last night and was a little unsure if I should request
review or hold off.
Thanks,
Bob
On Tue, Apr 16, 2019 at 7:06 AM Vikram Goyal ***@***.***>
wrote:
> @bgaydosrh <https://github.com/bgaydosrh> - is this ready for review? If
> yes, request QE review by setting the bug on ON_QA and/or tagging the QE
> associate here.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#14458 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ALQXFOPZWKGI5LBWSJOMG4DPQWXKBANCNFSM4HGEMWSA>
> .
>
|
Contributor
|
@bgaydosrh LGTM from a docs perspective. |
Author
|
Thanks Michael!
…On Tue, Apr 16, 2019 at 12:08 PM Michael Burke ***@***.***> wrote:
@bgaydosrh <https://github.com/bgaydosrh> LGTM from a docs perspective.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14458 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALQXFOP7TPGRHF2HORAS45DPQX2XLANCNFSM4HGEMWSA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Example 1. Horizontal Pod Autoscaler Object Definition, replaced 'apps/v1' with 'apps.openshift.io/v1' in the spec.scaleTargetRef.apiVersion field in BOTH VERSIONS of this example (the primary and alternate methods).