Correct a annotation for overriding existing cookie name

[bysnupy]

• Fix: [DOCS] Correct a annotation for overriding existing cookie name

• Version: v3.11

• Description:
  Correct a annotation for specifying custom cookie name of Route.
  Refer the router's haproxy-config.template as follows.
  The cookie name will be configured the value of router.openshift.io/cookie_name annotation.

 cookie {{firstMatch $cookieNamePattern (index $cfg.Annotations "router.openshift.io/cookie_name") (env "ROUTER_COOKIE_NAME" "") $cfg.RoutingKeyName}} insert indirect nocache httponly

This allows the application receiving route traffic to know the cookie route. is wrong explanation, because the cookie is removed from transmitted request if indirect and insert options are configured.
HAProxy 1.8 - coookie:

indirect:
          ...
          In "insert" mode, this will additionally remove cookies from the
          requests transmitted to the server, making the persistence
          mechanism totally transparent from an application point of view.

Refer the router's haproxy-config.template as follows.

 cookie {{..snip..}} insert indirect nocache httponly

[openshift-ci-robot]

Hi @bysnupy. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vikram-redhat]

/ok-to-test

[vikram-redhat]

@xingxingxia can you confirm this from QE?

[xingxingxia]

@vikram-redhat , though its changes involve CLI, it is route feature specific. @lihongan , could you help review? Thanks.

[lihongan]

The changes LGTM. Thank you, @bysnupy.
@vikram-redhat I think we also need backport to 3.7, 3.9 and 3.10.

[vikram-redhat]

/cherrypick enterprise-3.11

[vikram-redhat]

/cherrypick enterprise-3.10

[openshift-cherrypick-robot]

@vikram-redhat: new pull request created: #14407

Details

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@vikram-redhat: new pull request created: #14408

Details

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vikram-redhat]

/cherrypick enterprise-3.9

[vikram-redhat]

/cherrypick enterprise-3.7

[openshift-cherrypick-robot]

@vikram-redhat: #14362 failed to apply on top of branch "enterprise-3.9":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	dev_guide/routes.adoc
Falling back to patching base and 3-way merge...
Auto-merging dev_guide/routes.adoc
CONFLICT (content): Merge conflict in dev_guide/routes.adoc
Patch failed at 0001 Correct annotation for overriding cookie name, and wrong explanation

Details

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@vikram-redhat: #14362 failed to apply on top of branch "enterprise-3.7":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	dev_guide/routes.adoc
Falling back to patching base and 3-way merge...
Auto-merging dev_guide/routes.adoc
CONFLICT (content): Merge conflict in dev_guide/routes.adoc
Patch failed at 0001 Correct annotation for overriding cookie name, and wrong explanation

Details

In response to this:

/cherrypick enterprise-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.